Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fastcomp-only DOUBLE_MODE setting #11862

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Remove fastcomp-only DOUBLE_MODE setting #11862

merged 1 commit into from
Aug 11, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 11, 2020 •
edited
Loading

After removing it, things are always in DOUBLE_MODE == 1
basically (that is, doubles are normal doubles, no asm.js weirdness).

See #11860

@kripken kripken requested a review from sbc100 August 11, 2020 19:46
@sbc100
Copy link
Collaborator

sbc100 commented Aug 11, 2020

See #11860

sbc100
sbc100 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprising tiny change...

@kripken kripken merged commit 45d3f10 into master Aug 11, 2020
@kripken kripken deleted the no-DOUBLE_MODE branch August 11, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kripken @sbc100