Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastcomp-only ALIASING_FUNCTION_POINTERS setting #11882

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 12, 2020

Also removes the code block around it in emscripten.py. That's an obvious
easy win as it's a fastcomp-only function, and it's faster to remove such a
thing (when it's easily identifiable like here) rather than let future PRs remove
it line by line. Also removes the call chain to that function, also of fastcomp-
only functions (also easy wins, and necessary due to flake8).

See #11860

@kripken kripken requested a review from sbc100 August 12, 2020 19:50
@kripken kripken merged commit 83e3000 into master Aug 14, 2020
@kripken kripken deleted the no-ALIASING_FUNCTION_POINTERS branch August 14, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants