Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bitcode autodebugger (autodebugger.py) #12145

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Remove bitcode autodebugger (autodebugger.py) #12145

merged 1 commit into from
Sep 10, 2020

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 10, 2020

This was only used in fastcomp builds. AFAICT the llvm
backend uses binaryen passes to do this stuff.

See: #11860

@sbc100
Remove bitcode autodebugger (autodebugger.py)
d33cbf4 
This was only used in fastcomp builds.  AFAICT the llvm
backend uses binaryen passes to do this stuff.

See: #11860
@sbc100 sbc100 requested a review from kripken September 10, 2020 02:41
kripken
kripken approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a (small) chance we may want something like this in the future. But if that happens we can restore the code.

@sbc100 sbc100 merged commit fd583b2 into master Sep 10, 2020
@sbc100 sbc100 deleted the remove_autodebug branch September 10, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken