Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastcomp-only ELIMINATE_DUPLICATE_FUNCTIONS* options #11876

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 12, 2020

This has been a no-op on wasm, and this PR keeps it that way (we do
duplicate function elimination in binaryen automatically).

See #11860

@kripken kripken requested a review from sbc100 August 12, 2020 15:24
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving these changes!

@kripken kripken merged commit 574f381 into master Aug 12, 2020
@kripken kripken deleted the no-ELIMINATE_DUPLICATE_FUNCTIONS branch August 12, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants