Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing #7771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreyfel
force-pushed
the
create-record-with-setter-bug
branch
from
67824e0 to
3de8197
Compare
runspired
force-pushed
the
create-record-with-setter-bug
branch
from
3de8197 to
fcc49b4
Compare
runspired
changed the title
createRecord crashes when a setter which sets an attribute is involved in the createRecord.
runspired
force-pushed
the
create-record-with-setter-bug
branch
from
fcc49b4 to
fdac634
Compare
runspired
added a commit
that referenced
this pull request
Dec 15, 2021
…ed to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]>
runspired
added a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
runspired
added a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
runspired
added a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
Merged
runspired
added a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
snewcomer
pushed a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
snewcomer
pushed a commit
that referenced
this pull request
Dec 15, 2021
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
snewcomer
added a commit
that referenced
this pull request
Dec 15, 2021
* Backport Train for Beta (#7803) * deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> * fix Co-authored-by: Chris Thoburn <[email protected]> Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
snewcomer
pushed a commit
that referenced
this pull request
Feb 3, 2022
…ed to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]>
snewcomer
added a commit
that referenced
this pull request
Feb 3, 2022
…ed to ensure proper setup timing (#7771) (#7856) * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * rm import Co-authored-by: Andrey Fel <[email protected]> Co-authored-by: Chris Thoburn <[email protected]>
runspired
added a commit
that referenced
this pull request
Apr 14, 2022
* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
runspired
added a commit
that referenced
this pull request
Apr 14, 2022
* Backport Train for Beta (#7803) * deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> * fix lint * fix ie11 Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createRecord crashes when a setter which sets an attribute is involved
in the createRecord.
resolves #7772