fix: A(PromiseManyArray) should have no-effect #7802

runspired · 2021-12-15T10:08:04Z

resolves #7727

github-actions · 2021-12-15T10:11:08Z

Asset Size Report for 28e59e8

Modern Builds

EmberData increased by -57.0 B (+14.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +57.0 B.

Changeset


EmberData +179.72 KB +57.0 B (+38.59 KB +14.0 B compressed)
    @ember-data/model +28.79 KB +57.0 B (+6.18 KB +14.0 B compressed)
        @ember-data/model/-private +28.31 KB +57.0 B (+6.08 KB +14.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.72 KB' │
│ compressed │ '38.59 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.47 KB' │
│  compressed  │ '15.56 KB' │
│ % Of Library │   '40.3'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.56 KB  | 15.36 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 200.96 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.79 KB' │
│  compressed  │ '6.18 KB'  │
│ % Of Library │   '16.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.31 KB  | 6.08 KB    | 98.4          | 15.8
	@ember-data/model/index                           | 486.00 B  | 104.34 B   | 1.6           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.10 KB' │
│  compressed  │ '5.17 KB'  │
│ % Of Library │   '13.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.10 KB  | 5.17 KB    | 100.0         | 13.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.73 KB' │
│  compressed  │ '4.24 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.20 KB   | 1.55 KB    | 36.5          | 4.0
	@ember-data/serializer/-private                   | 5.52 KB   | 1.18 KB    | 28.0          | 3.1
	@ember-data/serializer/json-api                   | 3.75 KB   | 824.48 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.80 KB   | 614.71 B   | 14.2          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 55.39 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.16 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.75 KB' │
│  compressed  │ '3.38 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.95 KB   | 1.71 KB    | 50.5          | 4.4
	@ember-data/adapter/-private                      | 3.79 KB   | 833.93 B   | 24.1          | 2.1
	@ember-data/adapter/error                         | 1.96 KB   | 430.49 B   | 12.4          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 227.80 B   | 6.6           | 0.6
	@ember-data/adapter/json-api                      | 1.01 KB   | 223.08 B   | 6.4           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '2.01 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 531.62 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 467.63 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 261.30 B   | 12.7          | 0.7
	ember-data/setup-container                        | 368.00 B  | 79.01 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 68.27 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.83 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.89 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.60 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.17 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.17 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.74 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.88 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.81 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.52 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.66 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.66 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.80 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.56 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 636.40 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 349.33 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 101.55 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 101.12 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.08 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 75.57 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 68.27 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.55 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '619.22 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 510.79 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 108.42 B   | 17.5          | 0.3

Modern Builds (No Rollup)

EmberData increased by -64.0 B (+34.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/model has increased by +64.0 B.

Changeset


EmberData +220.34 KB +64.0 B (+42.04 KB +34.0 B compressed)
    @ember-data/model +32.9 KB +64.0 B (+6.28 KB +34.0 B compressed)
        @ember-data/model/-private/system/promise-many-array +3.87 KB +64.0 B (+755.28 B +34.0 B compressed)

Full Asset Analysis (Modern)


Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.34 KB' │
│ compressed │ '42.04 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.22 KB' │
│  compressed  │ '18.55 KB' │
│ % Of Library │   '44.1'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.41 KB  | 3.32 KB    | 17.9          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.52 KB  | 2.77 KB    | 14.9          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.45 KB   | 1.04 KB    | 5.6           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.16 KB   | 1008.82 B  | 5.3           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.50 KB   | 879.86 B   | 4.6           | 2.0
	@ember-data/store/-private/system/record-array-manager                             | 4.18 KB   | 817.47 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.92 KB   | 765.77 B   | 4.0           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.46 KB   | 675.54 B   | 3.6           | 1.6
	@ember-data/store/-private/index                                                   | 3.36 KB   | 656.46 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 605.14 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.87 KB   | 560.50 B   | 3.0           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 445.46 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.94 KB   | 379.64 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 349.12 B   | 1.8           | 0.8
	@ember-data/store/-private/system/references/has-many                              | 1.54 KB   | 300.28 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 296.27 B   | 1.6           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 258.69 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 257.73 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 222.82 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 190.58 B   | 1.0           | 0.4
	@ember-data/store/-private/system/references/record                                | 984.00 B  | 187.72 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 178.56 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 923.00 B  | 176.08 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 174.75 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 169.02 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 153.00 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.65 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 699.00 B  | 133.35 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 133.35 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 116.18 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.08 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 100.53 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 94.24 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.90 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 86.61 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.78 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 66.39 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.76 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.28 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.32 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.70 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.02 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.97 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.44 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.06 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.24 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.85 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.71 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.52 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.52 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.76 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.76 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.99 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.42 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.85 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.85 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.90 KB' │
│  compressed  │ '6.28 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.93 KB   | 1.90 KB    | 30.2          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.19 KB    | 18.9          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.87 KB   | 755.28 B   | 11.8          | 1.8
	@ember-data/model/-private/system/many-array                          | 2.86 KB   | 558.21 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.10 KB   | 410.16 B   | 6.4           | 1.0
	@ember-data/model/-private/index                                      | 1.42 KB   | 277.77 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 255.06 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 166.73 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 161.20 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 131.25 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 123.62 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 92.71 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 86.23 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.27 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.32 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 81.46 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.15 KB' │
│  compressed  │ '5.94 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.28 KB   | 1.58 KB    | 26.6          | 3.8
	@ember-data/record-data/-private/graph/index                                      | 4.92 KB   | 960.17 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.21 KB   | 628.03 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.86 KB   | 557.83 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 397.76 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 378.50 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.13 B   | 4.9           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 206.22 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.94 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 186.38 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 152.23 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 132.01 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 129.15 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.45 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.89 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.40 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.62 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.61 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.15 KB' │
│  compressed  │ '4.23 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.20 KB   | 1.37 KB    | 32.5          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.41 KB   | 861.73 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 732.58 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.80 KB   | 546.19 B   | 12.6          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 230.83 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.11 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 97.48 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 86.42 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.68 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.80 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.22 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.11 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.01 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.88 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.95 KB   | 1.52 KB    | 44.5          | 3.6
	@ember-data/adapter/error                                     | 1.96 KB   | 382.50 B   | 11.0          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 377.73 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 202.41 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.46 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.01 KB   | 198.21 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 790.00 B  | 150.71 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 108.36 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 94.24 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.61 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 351.00 B  | 66.96 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.35 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.04 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.81 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 472.36 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 376.59 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 232.17 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 70.20 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.20 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.66 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.27 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.88 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.74 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.35 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.35 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.97 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.21 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.26 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.11 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.35 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.35 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.58 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.71 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 565.45 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.39 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.23 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 89.85 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.15 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.15 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.66 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.46 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '550.20 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 453.85 B   | 82.5          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.34 B    | 17.5          | 0.2

github-actions · 2021-12-15T10:35:32Z

Performance Report for 28e59e8

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-37ms to 10ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-10ms to 11ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-16ms to 8ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-10ms to 4ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-8ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-19ms to 23ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-10ms to 11ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-10ms to 17ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-6ms to 5ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [-2ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-4ms to 36ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-12ms to 7ms]
⚠️ Phase [start-push-payload] => [start-destroy-records]
phase estimated regression +21ms [5ms to 36ms] OR +1.53% [0.39% to 2.66%]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-10ms to 6ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-11ms to 23ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-5ms to 19ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-8ms to 9ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-5ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [-1ms to 2ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-35ms to 4ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-20ms to 1ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-21ms to 6ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-2ms to 2ms]

* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

* Backport Train for Beta (#7803) * deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> * fix Co-authored-by: Chris Thoburn <[email protected]> Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

* deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

* Backport Train for Beta (#7803) * deactivate broken partner tests * feat: autotracking for reference id access (#7796) * feat: autotracking for reference id access * ensure references are torn down * fix build * add dep * add to deps * fix invalid json:api support and add valid json:api support * autotracking tests and cleanup * fix test failure, add comment * skip tests when feature not available * update test and fix lid reflection (#7800) * update test and fix lid reflection * remove debugger * fix ff off branch * add test and fix push of duplicate identifiers to a relationship (#7801) * add test + fix for chained async has many (#7691) * [bugfix]: fix for chained async has many * add fix and update tests * remove console.logs * make work with flags off * fix test for lts Co-authored-by: Chris Thoburn <[email protected]> * Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771) * Add failing test case which illustrates the createRecord bug createRecord crashes when a setter which sets an attribute is involved in the createRecord. * update test location and add fix Co-authored-by: Chris Thoburn <[email protected]> * fix: A(PromiseManyArray) should have no-effect (#7802) Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]> * fix lint * fix ie11 Co-authored-by: Sylvain Mina <[email protected]> Co-authored-by: Andrey Fel <[email protected]>

fix: A(PromiseManyArray) should have no-effect

28e59e8

runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue bugfix-3-28 labels Dec 15, 2021

runspired merged commit 644ee76 into master Dec 15, 2021

delete-merged-branch bot deleted the runspired/fix-array-clobber branch December 15, 2021 10:29

runspired added a commit that referenced this pull request Dec 15, 2021

fix: A(PromiseManyArray) should have no-effect (#7802)

e3f81db

runspired mentioned this pull request Dec 15, 2021

Backport Train for Release #7804

Merged

runspired mentioned this pull request Dec 15, 2021

Backport Train for LTS #7805

Merged

snewcomer mentioned this pull request Dec 15, 2021

Backport Train for Beta (#7803) #7806

Closed

snewcomer mentioned this pull request Dec 15, 2021

Backport Train for Release (#7803) #7807

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: A(PromiseManyArray) should have no-effect #7802

fix: A(PromiseManyArray) should have no-effect #7802

runspired commented Dec 15, 2021 •

edited

Loading

github-actions bot commented Dec 15, 2021

Warnings

Warnings

github-actions bot commented Dec 15, 2021

fix: A(PromiseManyArray) should have no-effect #7802

fix: A(PromiseManyArray) should have no-effect #7802

Conversation

runspired commented Dec 15, 2021 • edited Loading

github-actions bot commented Dec 15, 2021

Warnings

Warnings

github-actions bot commented Dec 15, 2021

runspired commented Dec 15, 2021 •

edited

Loading