Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Train for LTS #7805

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Backport Train for LTS #7805

merged 3 commits into from
Apr 14, 2022

Conversation

runspired
Copy link
Contributor

Co-authored-by: Chris Thoburn [email protected]

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

  • update test location and add fix

Co-authored-by: Chris Thoburn [email protected]

Co-authored-by: Sylvain Mina [email protected]
Co-authored-by: Andrey Fel [email protected]

@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue backport-lts PR targets the current lts branch labels Dec 15, 2021
@sly7-7
Copy link
Contributor

sly7-7 commented Dec 16, 2021

A big thank you to you @runspired, @snewcomer @andreyfel for this hard work.

@allison-strandberg
Copy link

Hi all—my team is waiting for this PR to upgrade to 3.28, since we need the fix implemented in #7771. Is anyone available to look at the failing check and merge this? Thank you!

cc @andreyfel @runspired

@snewcomer
Copy link
Contributor

@allison-strandberg Thanks for the reminder! Seems like we could cherry pick that single commit from the linked PR to 3.28. I can try and get to that tonight.

@snewcomer
Copy link
Contributor

@allison-strandberg 3.28.8 released!

runspired and others added 2 commits April 13, 2022 18:18
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-lts PR targets the current lts branch 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants