Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test and fix lid reflection #7800

Merged
merged 3 commits into from
Dec 15, 2021
Merged

Conversation

runspired
Copy link
Contributor

fixes #7783

@runspired runspired added 🎯 beta PR should be backported to beta 🎯 release PR should be backported to release 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🏷️ bug This PR primarily fixes a reported issue bugfix-3-28 labels Dec 15, 2021
@github-actions
Copy link

github-actions bot commented Dec 15, 2021

Asset Size Report for fae0927

Modern Builds

EmberData increased by -72.0 B (-21.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +61.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +11.0 B.

Changeset


EmberData +179.73 KB +72.0 B (+38.55 KB -21.0 B compressed)
    @ember-data/store +72.53 KB +61.0 B (+15.56 KB -17.79 B compressed)
        @ember-data/store/-private +71.62 KB +61.0 B (+15.36 KB -17.79 B compressed)
    @ember-data/record-data +24.11 KB +11.0 B (+5.17 KB -3.21 B compressed)
        @ember-data/record-data/-private +24.11 KB +11.0 B (+5.17 KB -3.21 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '179.73 KB' │
│ compressed │ '38.55 KB'  │
│  packages  │      8      │
│  modules   │     44      │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '72.53 KB' │
│  compressed  │ '15.56 KB' │
│ % Of Library │   '40.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/-private                        | 71.62 KB  | 15.36 KB   | 98.7          | 39.8
	@ember-data/store/index                           | 936.00 B  | 200.77 B   | 1.3           | 0.5

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '28.73 KB' │
│  compressed  │ '6.16 KB'  │
│ % Of Library │   '16.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 28.26 KB  | 6.06 KB    | 98.3          | 15.7
	@ember-data/model/index                           | 486.00 B  | 104.24 B   | 1.7           | 0.3

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '24.11 KB' │
│  compressed  │ '5.17 KB'  │
│ % Of Library │   '13.4'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 24.11 KB  | 5.17 KB    | 100.0         | 13.4

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '19.73 KB' │
│  compressed  │ '4.23 KB'  │
│ % Of Library │   '11.0'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.20 KB   | 1.55 KB    | 36.5          | 4.0
	@ember-data/serializer/-private                   | 5.52 KB   | 1.18 KB    | 28.0          | 3.1
	@ember-data/serializer/json-api                   | 3.75 KB   | 823.69 B   | 19.0          | 2.1
	@ember-data/serializer/rest                       | 2.80 KB   | 614.12 B   | 14.2          | 1.6
	@ember-data/serializer/index                      | 258.00 B  | 55.34 B    | 1.3           | 0.1
	@ember-data/serializer/transform                  | 215.00 B  | 46.11 B    | 1.1           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.75 KB' │
│  compressed  │ '3.38 KB'  │
│ % Of Library │   '8.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.95 KB   | 1.71 KB    | 50.5          | 4.4
	@ember-data/adapter/-private                      | 3.79 KB   | 833.12 B   | 24.1          | 2.1
	@ember-data/adapter/error                         | 1.96 KB   | 430.07 B   | 12.4          | 1.1
	@ember-data/adapter/index                         | 1.04 KB   | 227.58 B   | 6.6           | 0.6
	@ember-data/adapter/json-api                      | 1.01 KB   | 222.86 B   | 6.4           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.35 KB' │
│  compressed  │ '2.01 KB' │
│ % Of Library │   '5.2'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 531.10 B   | 25.9          | 1.3
	ember-data/-private                               | 2.13 KB   | 467.18 B   | 22.8          | 1.2
	ember-data/adapters/errors                        | 1.19 KB   | 261.04 B   | 12.7          | 0.7
	ember-data/setup-container                        | 368.00 B  | 78.93 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 68.21 B    | 3.3           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 58.77 B    | 2.9           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 53.84 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 52.55 B    | 2.6           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 52.12 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 52.12 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 51.69 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 50.83 B    | 2.5           | 0.1
	ember-data/serializer                             | 232.00 B  | 49.76 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 48.47 B    | 2.4           | 0.1
	ember-data/model                                  | 222.00 B  | 47.61 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 47.61 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 46.76 B    | 2.3           | 0.1
	ember-data/version                                | 161.00 B  | 34.53 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.44 KB' │
│ % Of Library │   '3.7'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 635.78 B   | 43.1          | 1.6
	ember-inflector/lib/system/inflections            | 1.59 KB   | 348.99 B   | 23.7          | 0.9
	ember-inflector/index                             | 473.00 B  | 101.45 B   | 6.9           | 0.3
	ember-inflector/lib/system                        | 471.00 B  | 101.03 B   | 6.9           | 0.3
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 80.00 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 75.50 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 68.21 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 63.49 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '618.62 B' │
│ % Of Library │   '1.6'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 510.29 B   | 82.5          | 1.3
	@ember-data/debug/setup                           | 505.00 B  | 108.32 B   | 17.5          | 0.3

Modern Builds (No Rollup)

EmberData increased by -72.0 B (+27.0 B compressed) which is within the allowed tolerance of 75 bytes uncompressed

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +61.0 B.
⚠️ The uncompressed size of the package @ember-data/record-data has increased by +11.0 B.

Changeset


EmberData +220.34 KB +72.0 B (+42.03 KB +27.0 B compressed)
    @ember-data/store +97.28 KB +61.0 B (+18.56 KB +22.88 B compressed)
        @ember-data/store/-private/system/model/states +5.51 KB +61.0 B (+1.05 KB +22.88 B compressed)
    @ember-data/record-data +31.16 KB +11.0 B (+5.94 KB +4.13 B compressed)
        @ember-data/record-data/-private/record-data +8.29 KB +11.0 B (+1.58 KB +4.13 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '220.34 KB' │
│ compressed │ '42.03 KB'  │
│  packages  │      8      │
│  modules   │     148     │
└────────────┴─────────────┘

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '97.28 KB' │
│  compressed  │ '18.56 KB' │
│ % Of Library │   '44.2'   │
└──────────────┴────────────┘
	Module                                                                             | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/store/-private/system/core-store                                       | 17.41 KB  | 3.32 KB    | 17.9          | 7.9
	@ember-data/store/-private/system/model/internal-model                             | 14.52 KB  | 2.77 KB    | 14.9          | 6.6
	@ember-data/store/-private/system/model/states                                     | 5.51 KB   | 1.05 KB    | 5.7           | 2.5
	@ember-data/store/-private/system/fetch-manager                                    | 5.16 KB   | 1008.62 B  | 5.3           | 2.3
	@ember-data/store/-private/system/store/finders                                    | 4.50 KB   | 879.68 B   | 4.6           | 2.0
	@ember-data/store/-private/system/record-array-manager                             | 4.18 KB   | 817.31 B   | 4.3           | 1.9
	@ember-data/store/-private/identifiers/cache                                       | 3.92 KB   | 765.62 B   | 4.0           | 1.8
	@ember-data/store/-private/system/store/record-data-store-wrapper                  | 3.46 KB   | 675.40 B   | 3.6           | 1.6
	@ember-data/store/-private/index                                                   | 3.36 KB   | 656.33 B   | 3.5           | 1.5
	@ember-data/store/-private/system/snapshot                                         | 3.10 KB   | 605.02 B   | 3.2           | 1.4
	@ember-data/store/-private/system/store/internal-model-factory                     | 2.87 KB   | 560.39 B   | 2.9           | 1.3
	@ember-data/store/-private/system/record-arrays/record-array                       | 2.28 KB   | 445.37 B   | 2.3           | 1.0
	@ember-data/store/-private/system/ds-model-store                                   | 1.94 KB   | 379.57 B   | 2.0           | 0.9
	@ember-data/store/-private/system/request-cache                                    | 1.79 KB   | 349.05 B   | 1.8           | 0.8
	@ember-data/store/-private/system/references/has-many                              | 1.54 KB   | 300.22 B   | 1.6           | 0.7
	@ember-data/store/-private/system/schema-definition-service                        | 1.52 KB   | 296.21 B   | 1.6           | 0.7
	@ember-data/store/-private/system/references/belongs-to                            | 1.32 KB   | 258.64 B   | 1.4           | 0.6
	@ember-data/store/-private/system/model/shim-model-class                           | 1.32 KB   | 257.68 B   | 1.4           | 0.6
	@ember-data/store/-private/system/store/serializer-response                        | 1.14 KB   | 222.78 B   | 1.2           | 0.5
	@ember-data/store/-private/identifiers/utils/uuid-v4                               | 999.00 B  | 190.54 B   | 1.0           | 0.4
	@ember-data/store/-private/system/references/record                                | 984.00 B  | 187.68 B   | 1.0           | 0.4
	@ember-data/store/index                                                            | 936.00 B  | 178.53 B   | 0.9           | 0.4
	@ember-data/store/-private/system/record-arrays/adapter-populated-record-array     | 923.00 B  | 176.05 B   | 0.9           | 0.4
	@ember-data/store/-private/system/references/reference                             | 916.00 B  | 174.71 B   | 0.9           | 0.4
	@ember-data/store/-private/system/internal-model-map                               | 886.00 B  | 168.99 B   | 0.9           | 0.4
	@ember-data/store/-private/system/errors-utils                                     | 802.00 B  | 152.97 B   | 0.8           | 0.4
	@ember-data/store/-private/system/snapshot-record-array                            | 753.00 B  | 143.62 B   | 0.8           | 0.3
	@ember-data/store/-private/system/record-notification-manager                      | 699.00 B  | 133.32 B   | 0.7           | 0.3
	@ember-data/store/-private/utils/construct-resource                                | 699.00 B  | 133.32 B   | 0.7           | 0.3
	@ember-data/store/-private/system/promise-proxies                                  | 609.00 B  | 116.16 B   | 0.6           | 0.3
	@ember-data/store/-private/system/references                                       | 598.00 B  | 114.06 B   | 0.6           | 0.3
	@ember-data/store/-private/system/store/common                                     | 527.00 B  | 100.51 B   | 0.5           | 0.2
	@ember-data/store/-private/system/coerce-id                                        | 494.00 B  | 94.22 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-arrays                                    | 487.00 B  | 92.88 B    | 0.5           | 0.2
	@ember-data/store/-private/system/identity-map                                     | 454.00 B  | 86.59 B    | 0.5           | 0.2
	@ember-data/store/-private/system/record-data-for                                  | 392.00 B  | 74.76 B    | 0.4           | 0.2
	@ember-data/store/-private/ts-interfaces/identifier                                | 348.00 B  | 66.37 B    | 0.3           | 0.2
	@ember-data/store/-private/identifiers/is-stable-identifier                        | 329.00 B  | 62.75 B    | 0.3           | 0.1
	@ember-data/store/-private/ts-interfaces/fetch-manager                             | 316.00 B  | 60.27 B    | 0.3           | 0.1
	@ember-data/store/-private/utils/promise-record                                    | 290.00 B  | 55.31 B    | 0.3           | 0.1
	@ember-data/store/-private/system/backburner                                       | 271.00 B  | 51.69 B    | 0.3           | 0.1
	@ember-data/store/-private/system/deprecated-evented                               | 257.00 B  | 49.01 B    | 0.3           | 0.1
	@ember-data/store/-private/system/normalize-model-name                             | 220.00 B  | 41.96 B    | 0.2           | 0.1
	@ember-data/store/-private/utils/is-non-empty-string                               | 212.00 B  | 40.43 B    | 0.2           | 0.1
	@ember-data/store/-debug/index                                                     | 210.00 B  | 40.05 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-serializer-interface              | 169.00 B  | 32.23 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-record-wrapper                | 167.00 B  | 31.85 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/minimum-adapter-interface                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-store-wrapper                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/schema-definition-service                 | 166.00 B  | 31.66 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-json-api                      | 161.00 B  | 30.70 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ember-data-json-api                       | 160.00 B  | 30.51 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data-schemas                       | 160.00 B  | 30.51 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/promise-proxies                           | 156.00 B  | 29.75 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-instance                           | 156.00 B  | 29.75 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/record-data                               | 152.00 B  | 28.99 B    | 0.2           | 0.1
	@ember-data/store/-private/ts-interfaces/ds-model                                  | 149.00 B  | 28.42 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/store                                     | 146.00 B  | 27.84 B    | 0.1           | 0.1
	@ember-data/store/-private/ts-interfaces/utils                                     | 146.00 B  | 27.84 B    | 0.1           | 0.1

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '32.83 KB' │
│  compressed  │ '6.26 KB'  │
│ % Of Library │   '14.9'   │
└──────────────┴────────────┘
	Module                                                                | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------
	@ember-data/model/-private/model                                      | 9.93 KB   | 1.89 KB    | 30.3          | 4.5
	@ember-data/model/-private/record-state                               | 6.23 KB   | 1.19 KB    | 19.0          | 2.8
	@ember-data/model/-private/system/promise-many-array                  | 3.80 KB   | 742.92 B   | 11.6          | 1.7
	@ember-data/model/-private/system/many-array                          | 2.86 KB   | 558.10 B   | 8.7           | 1.3
	@ember-data/model/-private/errors                                     | 2.10 KB   | 410.08 B   | 6.4           | 1.0
	@ember-data/model/-private/index                                      | 1.42 KB   | 277.71 B   | 4.3           | 0.6
	@ember-data/model/-private/system/relationships/relationship-meta     | 1.31 KB   | 255.01 B   | 4.0           | 0.6
	@ember-data/model/-private/attr                                       | 874.00 B  | 166.70 B   | 2.6           | 0.4
	@ember-data/model/-private/notify-changes                             | 845.00 B  | 161.17 B   | 2.5           | 0.4
	@ember-data/model/-private/belongs-to                                 | 688.00 B  | 131.22 B   | 2.0           | 0.3
	@ember-data/model/-private/has-many                                   | 648.00 B  | 123.59 B   | 1.9           | 0.3
	@ember-data/model/index                                               | 486.00 B  | 92.69 B    | 1.4           | 0.2
	@ember-data/model/-private/system/diff-array                          | 452.00 B  | 86.21 B    | 1.3           | 0.2
	@ember-data/model/-private/system/promise-belongs-to                  | 447.00 B  | 85.26 B    | 1.3           | 0.2
	@ember-data/model/-private/util                                       | 442.00 B  | 84.30 B    | 1.3           | 0.2
	@ember-data/model/-private/system/model-for-mixin                     | 427.00 B  | 81.44 B    | 1.3           | 0.2

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '31.16 KB' │
│  compressed  │ '5.94 KB'  │
│ % Of Library │   '14.1'   │
└──────────────┴────────────┘
	Module                                                                            | Bytes     | Compressed | % of Package  | % Of Library
	-------------------------------------------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private/record-data                                      | 8.29 KB   | 1.58 KB    | 26.6          | 3.8
	@ember-data/record-data/-private/graph/index                                      | 4.92 KB   | 959.98 B   | 15.8          | 2.2
	@ember-data/record-data/-private/graph/operations/replace-related-records         | 3.21 KB   | 627.91 B   | 10.3          | 1.5
	@ember-data/record-data/-private/graph/-edge-definition                           | 2.86 KB   | 557.72 B   | 9.2           | 1.3
	@ember-data/record-data/-private/relationships/state/has-many                     | 2.04 KB   | 397.69 B   | 6.5           | 0.9
	@ember-data/record-data/-private/relationships/state/belongs-to                   | 1.94 KB   | 378.42 B   | 6.2           | 0.9
	@ember-data/record-data/-private/graph/operations/update-relationship             | 1.51 KB   | 295.07 B   | 4.8           | 0.7
	@ember-data/record-data/-private/graph/-utils                                     | 1.06 KB   | 206.18 B   | 3.4           | 0.5
	@ember-data/record-data/-private/graph/operations/replace-related-record          | 1.04 KB   | 203.89 B   | 3.4           | 0.5
	@ember-data/record-data/-private/index                                            | 977.00 B  | 186.35 B   | 3.1           | 0.4
	@ember-data/record-data/-private/graph/operations/add-to-related-records          | 798.00 B  | 152.20 B   | 2.5           | 0.4
	@ember-data/record-data/-private/relationships/state/implicit                     | 692.00 B  | 131.99 B   | 2.2           | 0.3
	@ember-data/record-data/-private/graph/operations/remove-from-related-records     | 677.00 B  | 129.13 B   | 2.1           | 0.3
	@ember-data/record-data/-private/coerce-id                                        | 406.00 B  | 77.43 B    | 1.3           | 0.2
	@ember-data/record-data/-private/graph/-state                                     | 293.00 B  | 55.88 B    | 0.9           | 0.1
	@ember-data/record-data/-private/normalize-link                                   | 238.00 B  | 45.39 B    | 0.7           | 0.1
	@ember-data/record-data/-private/ts-interfaces/relationship-record-data           | 171.00 B  | 32.61 B    | 0.5           | 0.1
	@ember-data/record-data/-private/graph/-operations                                | 150.00 B  | 28.61 B    | 0.5           | 0.1

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '22.15 KB' │
│  compressed  │ '4.23 KB'  │
│ % Of Library │   '10.1'   │
└──────────────┴────────────┘
	Module                                                     | Bytes     | Compressed | % of Package  | % Of Library
	--------------------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                                | 7.20 KB   | 1.37 KB    | 32.5          | 3.3
	@ember-data/serializer/-private/embedded-records-mixin     | 4.41 KB   | 861.56 B   | 19.9          | 2.0
	@ember-data/serializer/json-api                            | 3.75 KB   | 732.43 B   | 16.9          | 1.7
	@ember-data/serializer/rest                                | 2.80 KB   | 546.08 B   | 12.6          | 1.3
	@ember-data/serializer/-private/index                      | 1.18 KB   | 230.79 B   | 5.3           | 0.5
	@ember-data/serializer/-private/transforms/date            | 530.00 B  | 101.09 B   | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/boolean         | 511.00 B  | 97.46 B    | 2.3           | 0.2
	@ember-data/serializer/-private/transforms/number          | 453.00 B  | 86.40 B    | 2.0           | 0.2
	@ember-data/serializer/-private/transforms/string          | 381.00 B  | 72.67 B    | 1.7           | 0.2
	@ember-data/serializer/-private/utils                      | 303.00 B  | 57.79 B    | 1.3           | 0.1
	@ember-data/serializer/index                               | 258.00 B  | 49.21 B    | 1.1           | 0.1
	@ember-data/serializer/-private/transforms/transform       | 226.00 B  | 43.10 B    | 1.0           | 0.1
	@ember-data/serializer/transform                           | 215.00 B  | 41.00 B    | 0.9           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '17.88 KB' │
│  compressed  │ '3.41 KB'  │
│ % Of Library │   '8.1'    │
└──────────────┴────────────┘
	Module                                                        | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                                      | 7.95 KB   | 1.52 KB    | 44.5          | 3.6
	@ember-data/adapter/error                                     | 1.96 KB   | 382.43 B   | 11.0          | 0.9
	@ember-data/adapter/-private/build-url-mixin                  | 1.93 KB   | 377.66 B   | 10.8          | 0.9
	@ember-data/adapter/index                                     | 1.04 KB   | 202.37 B   | 5.8           | 0.5
	@ember-data/adapter/-private/index                            | 1.03 KB   | 201.42 B   | 5.8           | 0.5
	@ember-data/adapter/json-api                                  | 1.01 KB   | 198.17 B   | 5.7           | 0.5
	@ember-data/adapter/-private/utils/serialize-query-params     | 790.00 B  | 150.68 B   | 4.3           | 0.4
	@ember-data/adapter/-private/utils/determine-body-promise     | 568.00 B  | 108.33 B   | 3.1           | 0.3
	@ember-data/adapter/-private/utils/parse-response-headers     | 494.00 B  | 94.22 B    | 2.7           | 0.2
	@ember-data/adapter/-private/utils/fetch                      | 454.00 B  | 86.59 B    | 2.5           | 0.2
	@ember-data/adapter/-private/utils/serialize-into-hash        | 351.00 B  | 66.94 B    | 1.9           | 0.2
	@ember-data/adapter/-private/utils/continue-on-reject         | 222.00 B  | 42.34 B    | 1.2           | 0.1
	@ember-data/adapter/-private/fastboot-interface               | 147.00 B  | 28.03 B    | 0.8           | 0.1

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '9.51 KB' │
│  compressed  │ '1.81 KB' │
│ % Of Library │   '4.3'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 2.42 KB   | 472.26 B   | 25.4          | 1.1
	ember-data/-private/index                         | 1.93 KB   | 376.51 B   | 20.3          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 232.12 B   | 12.5          | 0.5
	ember-data/-private/core                          | 368.00 B  | 70.19 B    | 3.8           | 0.2
	ember-data/setup-container                        | 368.00 B  | 70.19 B    | 3.8           | 0.2
	ember-data/relationships                          | 318.00 B  | 60.65 B    | 3.3           | 0.1
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 52.26 B    | 2.8           | 0.1
	ember-data/serializers/json-api                   | 251.00 B  | 47.87 B    | 2.6           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 46.73 B    | 2.5           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 46.34 B    | 2.5           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 46.34 B    | 2.5           | 0.1
	ember-data/transform                              | 241.00 B  | 45.96 B    | 2.5           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 45.20 B    | 2.4           | 0.1
	ember-data/serializer                             | 232.00 B  | 44.25 B    | 2.4           | 0.1
	ember-data/adapter                                | 226.00 B  | 43.10 B    | 2.3           | 0.1
	ember-data/model                                  | 222.00 B  | 42.34 B    | 2.3           | 0.1
	ember-data/store                                  | 222.00 B  | 42.34 B    | 2.3           | 0.1
	ember-data/attr                                   | 218.00 B  | 41.58 B    | 2.2           | 0.1
	ember-data/version                                | 161.00 B  | 30.70 B    | 1.7           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.71 KB' │
│  compressed  │ '1.28 KB' │
│ % Of Library │   '3.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.89 KB   | 565.34 B   | 43.1          | 1.3
	ember-inflector/lib/system/inflections            | 1.59 KB   | 310.33 B   | 23.7          | 0.7
	ember-inflector/index                             | 473.00 B  | 90.21 B    | 6.9           | 0.2
	ember-inflector/lib/system                        | 471.00 B  | 89.83 B    | 6.9           | 0.2
	ember-inflector/lib/helpers/pluralize             | 373.00 B  | 71.14 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 352.00 B  | 67.13 B    | 5.1           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 60.65 B    | 4.6           | 0.1
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 56.45 B    | 4.3           | 0.1

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '2.82 KB'  │
│  compressed  │ '550.09 B' │
│ % Of Library │   '1.3'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.32 KB   | 453.76 B   | 82.5          | 1.1
	@ember-data/debug/setup                           | 505.00 B  | 96.32 B    | 17.5          | 0.2

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

Performance Report for fae0927

Scenario - materialization: ☑️ Performance is stable

☑️ duration
phase no difference [-35ms to 9ms]
☑️ Phase [navigationStart] => [start-find-all]
phase no difference [-13ms to 5ms]
☑️ Phase [start-find-all] => [start-materialization]
phase no difference [-11ms to 11ms]
☑️ Phase [start-materialization] => [end-materialization]
phase no difference [-4ms to 6ms]
☑️ Phase [end-materialization] => [Test End]
phase no difference [-8ms to 3ms]

Scenario - unload: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 15ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 8ms]
☑️ Phase [start-push-payload] => [start-unload-records]
phase no difference [-20ms to 6ms]
☑️ Phase [start-unload-records] => [end-unload-records]
phase no difference [-1ms to 6ms]
☑️ Phase [end-unload-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - destroy: ☑️ Performance is stable

☑️ duration
phase no difference [-36ms to 3ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-19ms to 3ms]
✅ Phase [start-push-payload] => [start-destroy-records]
phase estimated improvement -15ms [-30ms to -1ms] OR -1.1% [-2.25% to -0.04%]
☑️ Phase [start-destroy-records] => [end-destroy-records]
phase no difference [-1ms to 9ms]
☑️ Phase [end-destroy-records] => [Test End]
phase no difference [0ms to 0ms]

Scenario - add-children: ☑️ Performance is stable

☑️ duration
phase no difference [-7ms to 30ms]
☑️ Phase [navigationStart] => [start-push-initial-payload]
phase no difference [-12ms to 16ms]
☑️ Phase [start-push-initial-payload] => [start-push-update-payload]
phase no difference [-1ms to 14ms]
☑️ Phase [start-push-update-payload] => [end-push-update-payload]
phase no difference [-4ms to 2ms]
☑️ Phase [end-push-update-payload] => [Test End]
phase no difference [0ms to 1ms]

Scenario - unused-relationships: ☑️ Performance is stable

☑️ duration
phase no difference [-29ms to 8ms]
☑️ Phase [navigationStart] => [start-push-payload]
phase no difference [-14ms to 7ms]
☑️ Phase [start-push-payload] => [end-push-payload]
phase no difference [-18ms to 9ms]
☑️ Phase [end-push-payload] => [Test End]
phase no difference [-3ms to 1ms]

@runspired runspired force-pushed the runspired/fix-lid-reflection branch from 115ebfe to fae0927 Compare December 15, 2021 09:08
@runspired runspired merged commit b181049 into master Dec 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the runspired/fix-lid-reflection branch December 15, 2021 10:11
runspired added a commit that referenced this pull request Dec 15, 2021
* update test and fix lid reflection

* remove debugger

* fix ff off branch
runspired added a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
runspired added a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
runspired added a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
runspired added a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
snewcomer pushed a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
snewcomer pushed a commit that referenced this pull request Dec 15, 2021
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
snewcomer added a commit that referenced this pull request Dec 15, 2021
* Backport Train for Beta (#7803)

* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>

* fix

Co-authored-by: Chris Thoburn <[email protected]>
Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
runspired added a commit that referenced this pull request Apr 14, 2022
* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
runspired added a commit that referenced this pull request Apr 14, 2022
* Backport Train for Beta (#7803)

* deactivate broken partner tests

* feat: autotracking for reference id access (#7796)

* feat: autotracking for reference id access

* ensure references are torn down

* fix build

* add dep

* add to deps

* fix invalid json:api support and add valid json:api support

* autotracking tests and cleanup

* fix test failure, add comment

* skip tests when feature not available

* update test and fix lid reflection (#7800)

* update test and fix lid reflection

* remove debugger

* fix ff off branch

* add test and fix push of duplicate identifiers to a relationship (#7801)

* add test + fix for chained async has many (#7691)

* [bugfix]: fix for chained async has many

* add fix and update tests

* remove console.logs

* make work with flags off

* fix test for lts

Co-authored-by: Chris Thoburn <[email protected]>

* Fix: assign unknown properties in init after initialization is finished to ensure proper setup timing (#7771)

* Add failing test case which illustrates the createRecord bug

createRecord crashes when a setter which sets an attribute is involved
in the createRecord.

* update test location and add fix

Co-authored-by: Chris Thoburn <[email protected]>

* fix: A(PromiseManyArray) should have no-effect (#7802)

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>

* fix lint

* fix ie11

Co-authored-by: Sylvain Mina <[email protected]>
Co-authored-by: Andrey Fel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 beta PR should be backported to beta 🎯 canary PR is targeting canary (default) 🎯 lts The PR should be backported to the most recent LTS 🎯 release PR should be backported to release 🏷️ bug This PR primarily fixes a reported issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: sideposted record id doesn't get updated after save
1 participant