-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add failing test case which illustrates the createRecord bug
createRecord crashes when a setter which sets an attribute is involved in the createRecord.
- Loading branch information
Showing
1 changed file
with
25 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,8 @@ import JSONAPISerializer from '@ember-data/serializer/json-api'; | |
import RESTSerializer from '@ember-data/serializer/rest'; | ||
import deepCopy from '@ember-data/unpublished-test-infra/test-support/deep-copy'; | ||
import testInDebug from '@ember-data/unpublished-test-infra/test-support/test-in-debug'; | ||
import Model, { attr } from '@ember-data/model'; | ||
import { set } from '@ember/object'; | ||
|
||
const Person = DS.Model.extend({ | ||
name: DS.attr('string'), | ||
|
@@ -1289,3 +1291,26 @@ module('integration/store - queryRecord', function (hooks) { | |
} | ||
}); | ||
}); | ||
|
||
module('integration/store - createRecord', function (hooks) { | ||
setupTest(hooks); | ||
|
||
test("createRecord doesn't crash when setter is involved", async function (assert) { | ||
class User extends Model { | ||
@attr() email; | ||
|
||
get name() { | ||
return this.email ? this.email.substring(0, this.email.indexOf('@')) :''; | ||
} | ||
|
||
set name(value) { | ||
set(this, 'email', `${value.toLowerCase()}@ember.js`); | ||
} | ||
} | ||
this.owner.register(`model:user`, User); | ||
const store = this.owner.lookup('service:store'); | ||
|
||
const user = store.createRecord('user', { name: 'Robert' }); | ||
assert.strictEqual(user.email, '[email protected]'); | ||
}); | ||
}); |