Skip to content

Commit

Permalink
Add failing test case which illustrates the createRecord bug
Browse files Browse the repository at this point in the history
createRecord crashes when a setter which sets an attribute is involved
in the createRecord.
  • Loading branch information
andreyfel committed Nov 22, 2021
1 parent 2adee46 commit 67824e0
Showing 1 changed file with 25 additions and 0 deletions.
25 changes: 25 additions & 0 deletions packages/-ember-data/tests/integration/store-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import JSONAPISerializer from '@ember-data/serializer/json-api';
import RESTSerializer from '@ember-data/serializer/rest';
import deepCopy from '@ember-data/unpublished-test-infra/test-support/deep-copy';
import testInDebug from '@ember-data/unpublished-test-infra/test-support/test-in-debug';
import Model, { attr } from '@ember-data/model';
import { set } from '@ember/object';

const Person = DS.Model.extend({
name: DS.attr('string'),
Expand Down Expand Up @@ -1289,3 +1291,26 @@ module('integration/store - queryRecord', function (hooks) {
}
});
});

module('integration/store - createRecord', function (hooks) {
setupTest(hooks);

test("createRecord doesn't crash when setter is involved", async function (assert) {
class User extends Model {
@attr() email;

get name() {
return this.email ? this.email.substring(0, this.email.indexOf('@')) :'';
}

set name(value) {
set(this, 'email', `${value.toLowerCase()}@ember.js`);
}
}
this.owner.register(`model:user`, User);
const store = this.owner.lookup('service:store');

const user = store.createRecord('user', { name: 'Robert' });
assert.strictEqual(user.email, '[email protected]');
});
});

0 comments on commit 67824e0

Please sign in to comment.