Run through Ember Build Pipeline #2687

seanpdoyle · 2015-01-08T23:37:10Z

Share build process found in emberjs/emberjs-build
Easiest approach was to copy paste from emberjs/ember.js
In the long term, we should move common build tasks / setup to
emberjs/emberjs-build

seanpdoyle · 2015-01-08T23:37:22Z

This is currently a WIP in concert with emberjs/emberjs-build#39

seanpdoyle · 2015-01-08T23:42:44Z

Current blocker:

Uncaught Error: Could not find module ember-inflector/system/string

Ember Build can't accept additional ES6 modules (like those found here https://github.com/emberjs/emberjs-build/blob/6b68577851a92ab989754f93ad832c14b8a54cc9/lib/get-vendored-packages.js#L13-L17)

bmac · 2015-01-16T00:35:34Z

Hey @seanpdoyle whats the current status on this pr. Are you still blocked on importing ember-inflector?

seanpdoyle · 2015-01-16T14:39:40Z

@bmac yes, sort of. @twokul has recently refactored some of the emberjs-build project, so I have to catch up to the work he's done there. I might have some new issues stemming from his changes, but my biggest problem has been figuring out how to properly vendor / import / concat ember-data, activemodel_adapter, and ember-inflector

rwjblue · 2015-01-16T14:42:30Z

@seanpdoyle - I'd be happy to do a hangout early next week to make a plan on this.

seanpdoyle · 2015-01-16T14:51:08Z

@rwjblue 👍 feel free to connect through email, hangouts, screenhero (all seandoyle at thoughtbot.com)

seanpdoyle · 2015-01-26T16:17:39Z

ping @rwjblue: do you have availability this week?

seanpdoyle · 2015-01-26T20:52:43Z

I'm running against https://github.com/seanpdoyle/emberjs-build/compare/wip-get-vendored-packages

and when I visit http://localhost:4200/tests/index.html and put a breakpoint on

 if (!registry[name]) {
  throw new Error("Could not find module " + name);
}

ember-inflector doesn't have a top level module. ember-inflector/main is the closest thing:

cc: @twokul @rwjblue -- Any ideas?

rwjblue · 2015-01-26T21:34:09Z

@seanpdoyle - ember-inflector/lib/main.js should be moved to ember-inflector.js which would make it ember-inflector module. In other words packages/<some-name>/lib/main.js is <some-name> module.

fivetanley · 2015-01-26T21:35:40Z

i will gladly merge any commits to ember-inflector for it.

as for activemodel-adapter we have made plans to extract it into its own repository. We can start work on that and transfer it to the emberjs org later if that's more convenient.

seanpdoyle · 2015-01-26T21:51:16Z

@rwjblue do you mean in a build step, or do you mean in the actual source code at stefanpenner/ember-inflector?

rwjblue · 2015-01-26T21:52:53Z

@seanpdoyle - Build step. https://github.com/emberjs/emberjs-build/blob/master/lib/htmlbars-package.js does roughly what you want (but you need to supply a libPath like in emberjs/emberjs-build#63).

seanpdoyle · 2015-01-26T21:54:53Z

Brocfile.js

+  vendoredPackages: {
+    'loader': vendoredPackage('loader'),
+    'ember-inflector': vendoredES6Package('ember-inflector', {
+      libPath: 'bower_components/ember-inflector/packages/ember-inflector/lib',


@rwjblue I thought this did what you're talking about in #2687 (comment)

Note that https://github.com/emberjs/emberjs-build/blob/master/lib/es6-vendored-package.js does not move main.js to <package-name.js> like the section I linked. But we should probably consolidate the htmlbarsPackage and vendoredES6Package...

@rwjblue does this section https://github.com/emberjs/emberjs-build/blob/master/lib/htmlbars-package.js#L20-L28 do the renaming through the includes option for Funnel?

Crap, I'm making this as clear as mud. This is what you need to move main up to the main package name: https://github.com/emberjs/emberjs-build/blob/master/lib/vendored-package.js#L28-L37

👌 that seems to have worked, but now

It can't find <script src="qunit_configuration"> and 0 tests are running.

I might just hold off until we have our hangout. I don't think I fully understand all the moving parts

Basically this:

seanpdoyle · 2015-01-28T21:16:19Z

package.json

-    "es6-module-transpiler": "^0.9.5",
-    "es6-module-transpiler-amd-formatter": "^0.2.4",
-    "es6-module-transpiler-package-resolver": "^1.0.1",
+    "emberjs-build": "file:../emberjs-build",


@rwjblue this needs to be replaced, obviously, but this PR depends on emberjs/emberjs-build#65

seanpdoyle · 2015-01-28T21:46:02Z

I'll try and tidy up the git history to tell a clearer story.

seanpdoyle · 2015-01-28T22:10:38Z

Heres the diff of ember build --environment production, with master on the left and this branch on the right

https://www.diffchecker.com/2nix5m8n

twokul · 2015-01-28T22:19:17Z

@seanpdoyle no source maps?

seanpdoyle · 2015-01-28T22:26:48Z

@rwjblue how does ember proper export source maps?

rwjblue · 2015-01-29T14:23:37Z

@seanpdoyle / @twokul - emberjs-build does not currently generate sourcemaps. I am nearly finished with the migration to esperanto as the module transpiler, and we should be able to support sourcemaps for both projects once that effort is finished.

seanpdoyle · 2015-01-29T16:32:36Z

@rwjblue ember build is only outputting the ember-data.debug.js. It's skipping the .prod and .min versions of both ember-data and ember-data-tests.

I'm using this version of ember-build.

Any ideas?

seanpdoyle · 2015-01-29T16:57:54Z

bin/run-tests.js

+});
+testFunctions.push(function() {
+  return run('dist=prod&emberchannel=' + emberChannel);
+});


@rwjblue I'm trying to setup npm test to run against debug, prod and min versions of the code.

ember build is only outputting the ember-data.debug.js. It's skipping the .prod and .min versions of both ember-data and ember-data-tests.

I'm using this version of ember-build.

They exist when I run ember build --environment production, which is fine for CI where broccoli's environment is production, but locally only the first test run will work.

ember proper doesn't seem to be doing anything differently from the ember-build perspective.

Any ideas?

seanpdoyle · 2015-01-29T17:39:56Z

@rwjblue @twokul I think this is ready for a final look. Once I get the ok I'll squash into more meaningful commits

rwjblue · 2015-01-29T18:46:29Z

ember build is only outputting the ember-data.debug.js. It's skipping the .prod and .min versions of both ember-data and ember-data-tests.

@seanpdoyle - It only generates prod and min output when running against the production environment (this ensures that dev builds are MUCH faster). So ember build --environment=production should do the trick here.

seanpdoyle · 2015-01-29T18:50:02Z

Looks like this is failing against canary because of too many deprecation warnings logged.

https://travis-ci.org/emberjs/data/jobs/48790205

Should this PR address that?

seanpdoyle · 2015-03-07T04:19:43Z

@rwjblue also, I can't believe I've never asked this, but is the monkey patching a test-only fix?

seanpdoyle · 2015-03-28T23:05:20Z

@rwjblue how would I go about changing emberjs-build to include bower_components so that this line

data/tests/index.html

Line 7 in 6990154

loads qunit.js et al.?

I tried adding /bower_components/ to https://github.com/emberjs/emberjs-build/blob/e13695255dcc33ecabd509bd5d719a54e961335d/lib/config/test-config-tree.js#L11 but it wasn't included

rwjblue · 2015-03-29T00:10:11Z

@seanpdoyle - It is available at /qunit/qunit.js by default, you should be able to update that script tag to something like:

<script src="../qunit/qunit.js"></script>

seanpdoyle · 2015-03-29T17:50:46Z

@rwjblue this is green depending on emberjs/emberjs-build#89 being merged

rwjblue · 2015-03-29T18:54:20Z

@seanpdoyle - I do not believe that an update to emberjs-build is needed (at least, not to get qunit to load). Did you see my comment above?

seanpdoyle · 2015-03-29T22:37:32Z

@rwjblue I did, but ember data needs (wants?) the ember bower component.

We could probably get by without it, but that means we'd pull from builds.emberjs.com instead of the local file system

rwjblue · 2015-03-29T22:44:48Z

that means we'd pull from builds.emberjs.com instead of the local file system

Which unfortunately is what is happening today.

I agree that changes are needed, sorry for the quick reply without digging into the reasoning more. I commented on the emberjs-build pull request with some suggestions.

seanpdoyle · 2015-03-29T22:58:36Z

@rwjblue this is green for release, but for beta and canary, deprecation warnings are flooding travis and failing an otherwise green build.

https://travis-ci.org/emberjs/data/jobs/56345865#L229

DEPRECATION: Using the same function as getter and setter is deprecated. See http://emberjs.com/deprecations/v1.x/#toc_deprecate-using-the-same-function-as-getter-and-setter-in-computed-properties for more details.

This change is introduced in 1.12, so I can't introduce the fix without breaking release.

Is there a way to silence deprecations?

seanpdoyle · 2015-04-02T12:49:32Z

@rwjblue @fivetanley @bmac ping

rwjblue · 2015-04-02T13:25:16Z

@seanpdoyle the deprecations are fixed on master in #2961 but that is not what was causing it to fail. The actual issue which was causing the failure was fixed in #2959.

Can you rebase to get these updates?

seanpdoyle · 2015-04-02T13:40:09Z

@rwjblue what a time to be alive

seanpdoyle · 2015-04-02T14:11:12Z

Looks like the windows build is failing because it's using node 0.12.x (https://ci.appveyor.com/project/embercli/data/build/724#L325) instead of 0.10.x

rwjblue · 2015-04-02T14:11:46Z

Confirm that issue is being tracked in emberjs/emberjs-build#87, but I am unsure if @stefanpenner has had time to work on it more.

* Share build process found in [emberjs/emberjs-build][1] * Easiest approach was to copy paste from [emberjs/ember.js][2] * In the long term, we should move common build tasks / setup to [emberjs/emberjs-build][1] * Vendor `ember-inflector` ES6 package Silence Deprecations * Use `container._registry.has` instead of `container.has` * Use `env.registry` instead of `store.container` [1]: https://github.com/emberjs/emberjs-build [2]: https://github.com/emberjs/ember.js * Resolve JSCS infractions * Move `package-manager-files` for `emberjs-build` * Pass Bower Funnels into emberjs-build * Run appveyor against node `0.10`

seanpdoyle · 2015-06-04T01:34:41Z

note to self:

squashed and force pushed over

(function() {
+ window.EmberDev = window.EmberDev || {};
+ EmberDev.runningProdBuild = !!QUnit.urlParams.prod;
+ // hack qunit to not suck for Ember objects
+ var originalTypeof = QUnit.jsDump.typeOf;
+ QUnit.jsDump.typeOf = function(obj) {
+ if (Ember && Ember.Object && Ember.Object.detectInstance(obj)) {
+ return "emberObject";
+ }
+ return originalTypeof.call(this, obj);
+ };
+ // raises is deprecated, but we likely want to keep it around for our es3
+ // test runs.
+ QUnit.constructor.prototype.raises = QUnit['throws'];
+ window.raises = QUnit['throws'];
+ QUnit.jsDump.parsers.emberObject = function(obj) {
+ return obj.toString();
+ };
+ var EmberDevTestHelperAssert = window.Ember.__loader.require('ember-dev/test-helper/index')['default'];
+ var setupQUnit = window.Ember.__loader.require('ember-dev/test-helper/setup-qunit')['default'];
+ var testHelpers = new EmberDevTestHelperAssert(window.Ember, EmberDev.runningProdBuild);
+ setupQUnit(testHelpers, QUnit);
+ window.module = QUnit.module;

+ // Tests should time out after 5 seconds
+ QUnit.config.testTimeout = 5000;
+ // Hide passed tests by default
+ QUnit.config.hidepassed = true;

seanpdoyle · 2015-06-04T01:44:34Z

@stefanpenner still getting the same node 0.12.x Windows failure.

Has the landscape changed at all in the last few months since I've worked on this?

rwjblue · 2015-06-04T01:46:43Z

@seanpdoyle - Not that I am aware of, but we did miss you. 😸

seanpdoyle · 2015-06-04T01:52:40Z

@rwjblue I would love to get this merged during this pre-June 12th push.

seanpdoyle · 2015-06-04T02:24:10Z

@rwjblue @stefanpenner new and exciting failure:

› node -v
v0.10.38
› ember test
Future versions of Ember CLI will not support v0.10.38. Please update to Node 0.12 or io.js.
version: 0.2.7
Built project successfully. Stored in "/Users/Sean/src/ember-data/tmp/class-tests_dist-PTuvffjr.tmp".
dyld: lazy symbol binding failed: Symbol not found: _node_module_register
  Referenced from: /Users/Sean/src/ember-data/node_modules/ember-cli/node_modules/testem/node_modules/socket.io/node_modules/engine.io/node_modules/ws/build/Release/bufferutil.node
  Expected in: dynamic lookup

dyld: Symbol not found: _node_module_register
  Referenced from: /Users/Sean/src/ember-data/node_modules/ember-cli/node_modules/testem/node_modules/socket.io/node_modules/engine.io/node_modules/ws/build/Release/bufferutil.node
  Expected in: dynamic lookup

zsh: trace trap  ember test

wecc · 2015-12-03T15:20:12Z

I'm gonna go ahead and close this since ED now has been addonified.

@seanpdoyle Really appreciate your work on this even though it didn't get merged 👍

seanpdoyle · 2015-12-03T15:21:20Z

👏 I'm glad that's the direction this library has gone.

seanpdoyle force-pushed the use-emberjs-build branch from 243efd1 to b096ac7 Compare January 26, 2015 20:50

seanpdoyle reviewed Jan 26, 2015
View reviewed changes

seanpdoyle force-pushed the use-emberjs-build branch 2 times, most recently from 5e0122a to 5500641 Compare January 28, 2015 21:13

seanpdoyle reviewed Jan 28, 2015
View reviewed changes

seanpdoyle force-pushed the use-emberjs-build branch 2 times, most recently from 408dee3 to 9665fdb Compare January 28, 2015 21:30

seanpdoyle force-pushed the use-emberjs-build branch from 2068829 to 86a2bf0 Compare January 28, 2015 22:36

seanpdoyle reviewed Jan 29, 2015
View reviewed changes

seanpdoyle force-pushed the use-emberjs-build branch from 67bc1eb to cf14655 Compare March 29, 2015 00:44

seanpdoyle force-pushed the use-emberjs-build branch from 858e674 to 80513c0 Compare April 2, 2015 13:29

seanpdoyle force-pushed the use-emberjs-build branch 2 times, most recently from 649bd92 to 3ba24bc Compare April 15, 2015 22:42

wecc mentioned this pull request May 8, 2015

Extract util/computed-polyfill to it's own addon #3053

Merged

seanpdoyle force-pushed the use-emberjs-build branch from 71c3725 to baef116 Compare June 4, 2015 00:53

seanpdoyle force-pushed the use-emberjs-build branch from baef116 to dbd988f Compare June 4, 2015 01:34

wecc closed this Dec 3, 2015

seanpdoyle deleted the use-emberjs-build branch December 3, 2015 15:21

Run through Ember Build Pipeline #2687

Run through Ember Build Pipeline #2687

Conversation

seanpdoyle commented Jan 8, 2015

seanpdoyle commented Jan 8, 2015

seanpdoyle commented Jan 8, 2015

bmac commented Jan 16, 2015

seanpdoyle commented Jan 16, 2015

rwjblue commented Jan 16, 2015

seanpdoyle commented Jan 16, 2015

seanpdoyle commented Jan 26, 2015

seanpdoyle commented Jan 26, 2015

rwjblue commented Jan 26, 2015

fivetanley commented Jan 26, 2015

seanpdoyle commented Jan 26, 2015

rwjblue commented Jan 26, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanpdoyle commented Jan 28, 2015

seanpdoyle commented Jan 28, 2015

twokul commented Jan 28, 2015

seanpdoyle commented Jan 28, 2015

rwjblue commented Jan 29, 2015

seanpdoyle commented Jan 29, 2015

Choose a reason for hiding this comment

seanpdoyle commented Jan 29, 2015

rwjblue commented Jan 29, 2015

seanpdoyle commented Jan 29, 2015

seanpdoyle commented Mar 7, 2015

seanpdoyle commented Mar 28, 2015

rwjblue commented Mar 29, 2015

seanpdoyle commented Mar 29, 2015

rwjblue commented Mar 29, 2015

seanpdoyle commented Mar 29, 2015

rwjblue commented Mar 29, 2015

seanpdoyle commented Mar 29, 2015

seanpdoyle commented Apr 2, 2015

rwjblue commented Apr 2, 2015

seanpdoyle commented Apr 2, 2015

seanpdoyle commented Apr 2, 2015

rwjblue commented Apr 2, 2015

seanpdoyle commented Jun 4, 2015

seanpdoyle commented Jun 4, 2015

rwjblue commented Jun 4, 2015

seanpdoyle commented Jun 4, 2015

seanpdoyle commented Jun 4, 2015

wecc commented Dec 3, 2015

seanpdoyle commented Dec 3, 2015