Allow Configuration

[seanpdoyle]

Changes driven by attempting to integrate with emberjs/data

• configure an output build name and namespace
• skip building template compiler
• skip building the runtime

[twokul]

I'll review later tonight.

[seanpdoyle]

@twokul there was a typo that was causing a failure.

This should be passing now.

[twokul]

this._name, this._namespace and this._skipRuntime should be initialized as null in init method so object shape stays the same.

[seanpdoyle]

@twokul @rwjblue are skipTemplates and skipRuntime a good idea to pass in as options?

Should they live in build-config.js?

[twokul]

@seanpdoyle actually, good point. It seems like we don't need to dynamically include/exclude runtime or template compiler (happens once per build). So I think it's fine for it to be a environment flag.

[seanpdoyle]

@twokul moved to CLI arguments and ready for another look

[seanpdoyle]

@twokul actually, moving the config to ENV variables is problematic.

We're moving config from Ember Data's Brocfile.js to the package.json.

npm start becomes SKIP_TEMPLATES=true SKIP_RUNTIME=true NAME=ember-data NAMESPACE=DS ember serve. This is ok, except for the fact that npm build doesn't get the ENV variables, and neither does npm test.

ember serve doesn't pass them along to the pre-serve ember build

So we can either leave the config in Brocfile.js, or duplicate the variables across package.json scripts

"build": "SKIP_TEMPLATES=true SKIP_RUNTIME=true NAME=ember-data NAMESPACE=DS ember build",
"pretest": "SKIP_TEMPLATES=true SKIP_RUNTIME=true NAME=ember-data NAMESPACE=DS ember build",
"start": "SKIP_TEMPLATES=true SKIP_RUNTIME=true NAME=ember-data NAMESPACE=DS ember serve"

[twokul]

@seanpdoyle I thought you could set environment variables in .travis.yml, like here? Am I mistaken?

[seanpdoyle]

@twokul won't that only come into effect in CI?

[twokul]

@seanpdoyle yeah, we should probably keep it in Brocfile.js then.

[twokul]

@seanpdoyle thanks man!

[seanpdoyle]

@twokul this is still of a work in progress. Expect more config based PRs until I can figure out how to get ember data building properly.