Skip to content

Commit

Permalink
Merge pull request #2953 from bmac/bug-2948
Browse files Browse the repository at this point in the history
Do not assert reserved properties for static properties.
  • Loading branch information
igorT committed Mar 27, 2015
2 parents 060f2d3 + d90a64e commit 6990154
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
4 changes: 1 addition & 3 deletions packages/ember-data/lib/system/model/model.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ var forEach = Ember.ArrayPolyfills.forEach;
var map = Ember.ArrayPolyfills.map;
var intersection = Ember.EnumerableUtils.intersection;
var RESERVED_MODEL_PROPS = [
'attributes', 'currentState', 'data',
'relatedTypes', 'relationshipNames', 'relationships',
'relationshipsByName', 'transformedAttributes', 'store'
'currentState', 'data', 'store'
];

var retrieveFromCurrentState = Ember.computed('currentState', function(key, value) {
Expand Down
6 changes: 2 additions & 4 deletions packages/ember-data/tests/unit/model-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -725,11 +725,9 @@ test("A subclass of DS.Model can not use the `store` property", function() {
});

test("A subclass of DS.Model can not use reserved properties", function() {
expect(9);
expect(3);
[
'attributes', 'currentState', 'data',
'relatedTypes', 'relationshipNames', 'relationships',
'relationshipsByName', 'transformedAttributes', 'store'
'currentState', 'data', 'store'
].forEach(function(reservedProperty) {
var invalidExtendObject = {};
invalidExtendObject[reservedProperty] = DS.attr();
Expand Down

0 comments on commit 6990154

Please sign in to comment.