Skip to content
This repository has been archived by the owner on Nov 11, 2017. It is now read-only.

Accept bowerFunnels as EmberBuild option #89

Closed

Conversation

seanpdoyle
Copy link
Contributor

Include bower_components in test tree

Pass in bower dependencies so that Ember-Data's tests have access.

@@ -8,7 +8,7 @@ module.exports = function getTestConfigTree(opts) {
var options = opts || {};

var testConfig = new Funnel(options.libPath || 'tests', {
include: [ /html$/, /js$/ ],
include: [ /html$/, /js$/, "bower_components/*" ],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"bower_components/*" I believe this should be a regex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops, this snuck its way in there. It isn't necessary

Include `bower_components` in test tree

Pass in bower dependencies so that Ember-Data's tests have access.
@seanpdoyle seanpdoyle force-pushed the include-bower-components branch from b423a69 to 88c4a54 Compare March 29, 2015 22:39
@rwjblue
Copy link
Member

rwjblue commented Mar 29, 2015

I would prefer to simply allow "otherTrees" to be passed through (instead of changing how getBowerTres works).

So if in Ember Data you specified:

var emberTree = new Funnel('bower_components/ember', {
  destDir: 'ember'  
});

new EmberBuild({
  additionalTrees: emberTree
});

@seanpdoyle
Copy link
Contributor Author

@rwjblue 👌

is a Funnel instance an acceptable tree?

@rwjblue
Copy link
Member

rwjblue commented Mar 29, 2015

Yep, it is a tree.

@stefanpenner
Copy link
Member

this seems to have gone stale. @seanpdoyle I'm also working to get your ED patch in, so I may circle back and add this feature if needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants