Use new getter/setter for computed if available #2961
Conversation
|
👍 |
| if (arguments.length > 1) { | ||
| return computedConfig.set.call(this, key, value); | ||
| } | ||
| return computedConfig.get.call(this, key); |
There was a problem hiding this comment.
Could we move this logic into a shared util helper?
There was a problem hiding this comment.
I considered using https://github.com/rwjblue/ember-new-computed/blob/master/addon/index.js from @rwjblue but didn't know if it was worth it since we only have settable CPs in these two places in ED. If we use a helper like the one linked we should probably make sure that we use it everywhere within ED.
There was a problem hiding this comment.
That said, I'm happy to make it a shared helper too.
There was a problem hiding this comment.
If we are already putting supportsComputedGetterSetter into a shared util, but it's only used as part of this function, we should probably move this into the util as well.
wecc
force-pushed
the
beta-and-canary-deprecations
branch
from
3da44fc to
c5c0861
Compare
wecc
force-pushed
the
beta-and-canary-deprecations
branch
from
c5c0861 to
c53815f
Compare
|
|
I think the getter only cps are gonna stay only functions in 2.0 as well, so I don't think there is a need. |
Use new getter/setter for computed if available
This fixes the ~3400 deprecation warnings
Using the same function as getter and setter is deprecatedfor beta and canary builds.