Support old node versions #30
Conversation
|
@kevinsawicki I think you're going to have to do something similar to sumchecker, if you don't mind. |
Yeah, will do 👍 |
|
Well, that's different: https://travis-ci.org/electron-userland/electron-download/jobs/159396306 |
Yeah, these were actually occurring on the builds of #29 as well, https://travis-ci.org/electron-userland/electron-download/jobs/159380783 Super weird, I was chalking it up to a Travis bug/machine issue since I couldn't reproduce locally and the introduction of tape causing these crashes seems unlikely to be related (famous last words). |
kevinsawicki
force-pushed
the
support-old-node-versions
branch
from
50cd3c4 to
6147a02
Compare
|
The crashes on the mac workers were addressed by #32 |
That is bizarre. |
|
AppVeyor also needs to build against Node 0.10 and 0.12. |
kevinsawicki
force-pushed
the
support-old-node-versions
branch
from
6d9ba45 to
539789a
Compare
kevinsawicki
force-pushed
the
support-old-node-versions
branch
from
3a8ddea to
d91d74e
Compare
| @@ -25,12 +28,15 @@ | |||
| "home-path": "^1.0.1", | |||
| "minimist": "^1.2.0", | |||
| "nugget": "^2.0.0", | |||
| "path-exists": "^3.0.0", | |||
| "path-exists": "^2.1.0", | |||
| "rc": "^1.1.2", | |||
| "semver": "^5.3.0", | |||
| "sumchecker": "^1.1.0" | |||
There was a problem hiding this comment.
IMO sumchecker should be bumped to enforce a minimum version.
There was a problem hiding this comment.
So sorry, I accidentally deleted your commit while rebasing and force-pushing, my apologies, will bring it back shortly 😥
There was a problem hiding this comment.
So weird to get a notification for my own commit...
|
Thanks @malept for your help, review, and sumchecker updates on this one 👍 |
This pull requests adds babel support for support old node versions (0.10/0.12).
This precompiles the source files using babel so it does have the downside of not using the native ES6 support that is built into newer versions of node but it does still allow the source files to use these constructs making for cleaner code.
And since the new constructs used, arrow functions and classes, compile down pretty nicely, the resulting babel generated code is still pretty readable.
Refs electron-userland/electron-prebuilt#190
Closes #27
Closes #28
/cc @malept 👀