Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken install after ES6 conversion. #27

Closed
wants to merge 3 commits into from

Conversation

danmakenoise
Copy link

The usage of const outside of the module scope in index.js breaks the installation of this package for us, with the following error:

SyntaxError: Use of const in strict mode.

So, I went ahead and fixed it! Here is what I did:

  1. Create eslintrc.json to specify eslint to check for ES6.
  2. Remove use strict inside of modules, where it is not necessary.
  3. Revert index.js back to using var outside of the module scope, where const is not allowed.

@kevinsawicki
Copy link
Contributor

Thanks for this but #28 has been merged which uses babel to precompile the sources files to restore support for node 0.10/0.12 which should address this issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants