Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile using babel before publishing #1

Merged
merged 8 commits into from
Sep 14, 2016
Merged

Conversation

kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Sep 12, 2016

This pull requests publishes a babel-ified version of index.js so this module can be used in old node versions that don't support ES6 stuff.

Also adds a dependency on es6-promise that will be a fallback when global.Promise is missing.

Refs electron/get#30

@malept
Copy link
Owner

malept commented Sep 12, 2016

Ugh, I guess build.js needs to be blacklisted from eslint.

@kevinsawicki
Copy link
Contributor Author

Looks like the build is failing because of the code climate token.

No CODECLIMATE_REPO_TOKEN found. A CODECLIMATE_REPO_TOKEN must be specified as an environment variable.

@malept
Copy link
Owner

malept commented Sep 12, 2016

Looks like the build is failing because of the code climate token.

Weird. (Mostly because master didn't fail.) Let me add that to Travis.

@malept
Copy link
Owner

malept commented Sep 12, 2016

OK, this is really weird. I set CODECLIMATE_REPO_TOKEN in the Travis UI and it didn't take?

@kevinsawicki
Copy link
Contributor Author

I set CODECLIMATE_REPO_TOKEN in the Travis UI and it didn't take?

Hmm, is it private? I don't think private env vars are available to pull requests.

@malept
Copy link
Owner

malept commented Sep 12, 2016

Do you mind allowing me access to that branch via that nifty new checkbox? I will try to mess with it when I get home.

@kevinsawicki
Copy link
Contributor Author

Do you mind allowing me access to that branch via that nifty new checkbox? I will try to mess with it when I get home.

Yup, should be enabled, feel free to push at will.

@kevinsawicki
Copy link
Contributor Author

eslint only supports node 4+ so linting won't be possible on CIs using node 0.10 and 0.12

@malept malept merged commit d904a01 into malept:master Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants