Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old node versions #30

Merged
merged 12 commits into from
Sep 16, 2016
Merged

Support old node versions #30

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b8e8ff6
Build on node 0.10 and 0.12
kevinsawicki Sep 12, 2016
c3ead38
Add babel dev dependency
kevinsawicki Sep 12, 2016
6d2cee5
Test and publish using babel
kevinsawicki Sep 12, 2016
63bde10
Simply run scripts
kevinsawicki Sep 12, 2016
3623594
git/npm ignore npm-debug.log
kevinsawicki Sep 12, 2016
3e07330
Use path-exists that works on node 0.10/0.12
kevinsawicki Sep 12, 2016
a414bef
Lint using newer node version on CI
kevinsawicki Sep 12, 2016
eb386b8
Use full path to index requires
kevinsawicki Sep 12, 2016
539789a
Lint and test in script block
kevinsawicki Sep 16, 2016
d91d74e
Run windows build against multiple node versions
kevinsawicki Sep 16, 2016
e0c5966
Upgrade sumchecker to an old-Node-compatible version
malept Sep 16, 2016
f1e45ca
Run unit tests directly on AppVeyor
kevinsawicki Sep 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
node_modules
.DS_Store
.DS_Store
build
npm-debug.log
2 changes: 2 additions & 0 deletions .npmignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
.travis.yml
appveyor.yml
test
lib
npm-debug.log
8 changes: 8 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ os:
osx_image: xcode7.3
language: node_js
node_js:
- '0.10'
- '0.12'
- '4'
- '5'
- '6'
Expand All @@ -14,3 +16,9 @@ cache:
branches:
only:
- master
before_install:
- nvm install stable
script:
- npm run lint
- nvm use $TRAVIS_NODE_VERSION
- npm run unit-tests
10 changes: 9 additions & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,18 @@ branches:
only:
- master

environment:
matrix:
- nodejs_version: "0.10"
- nodejs_version: "0.12"
- nodejs_version: "4"
- nodejs_version: "5"
- nodejs_version: "6"

skip_tags: true

install:
- ps: Install-Product node LTS
- ps: Install-Product node $env:nodejs_version
- npm install npm
- .\node_modules\.bin\npm install

Expand Down
0 cli.js → lib/cli.js
View file
Open in desktop
File renamed without changes.
0 index.js → lib/index.js
View file
Open in desktop
File renamed without changes.
19 changes: 15 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,15 @@
"name": "electron-download",
"version": "2.2.0",
"description": "download electron prebuilt binary zips from github releases",
"main": "index.js",
"main": "build/index.js",
"bin": {
"electron-download": "cli.js"
"electron-download": "build/cli.js"
},
"scripts": {
"test": "tape test/*.js && eslint ."
"prepublish": "babel --out-dir build lib",
"lint": "eslint lib test",
"unit-tests": "tape -r babel-register test/*.js",
"test": "npm run unit-tests && npm run lint"
},
"repository": {
"type": "git",
Expand All @@ -25,12 +28,15 @@
"home-path": "^1.0.1",
"minimist": "^1.2.0",
"nugget": "^2.0.0",
"path-exists": "^3.0.0",
"path-exists": "^2.1.0",
"rc": "^1.1.2",
"semver": "^5.3.0",
"sumchecker": "^1.1.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO sumchecker should be bumped to enforce a minimum version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sorry, I accidentally deleted your commit while rebasing and force-pushing, my apologies, will bring it back shortly 😥

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird to get a notification for my own commit...

},
"devDependencies": {
"babel-cli": "^6.14.0",
"babel-preset-es2015": "^6.14.0",
"babel-register": "^6.14.0",
"eslint": "^3.2.0",
"eslint-config-standard": "^5.2.0",
"eslint-plugin-promise": "^2.0.0",
Expand All @@ -48,5 +54,10 @@
]
}
},
"babel": {
"presets": [
"es2015"
]
},
"keywords": []
}
2 changes: 1 addition & 1 deletion test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const download = require('..')
const download = require('../lib/index')
const test = require('tape')
const verifyDownloadedZip = require('./helpers').verifyDownloadedZip

Expand Down
2 changes: 1 addition & 1 deletion test/test_404.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const download = require('..')
const download = require('../lib/index')
const fs = require('fs')
const test = require('tape')

Expand Down
2 changes: 1 addition & 1 deletion test/test_symbols.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const download = require('..')
const download = require('../lib/index')
const test = require('tape')
const verifyDownloadedZip = require('./helpers').verifyDownloadedZip

Expand Down
2 changes: 1 addition & 1 deletion test/test_with_checksum.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict'

const download = require('..')
const download = require('../lib/index')
const test = require('tape')
const verifyDownloadedZip = require('./helpers').verifyDownloadedZip

Expand Down