Run tests via tape #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I was not a fan of the existing testsuite. If the testsuite were larger, I would suggest having a common function that asserted that |
Great point, I think that is in scope to this pull request, even though this library is small it makes sense to me to have a very comprehensive test suite given how important this project is, and adding some helpers now will making adding new tests in the future easier with less copy-pasta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request switches the tests to use tape and adds a few more assertions to verify the zip file exists and is non-empty.
This makes them easier to use with other tools that support tap output.
/cc @malept 👀