[SECURITY] Rename siem plugin to security_solution #67902

XavierM · 2020-06-01T20:47:09Z

Summary

Rename siem plugin to security_solution
Re-route old url from app/siem to app/security
Add navigation will be done in a follow up PR-> will do that in another PR
Re-route old url to the new ones -> will do that in another PR
update ml url with the new path -> will do that in another PR
Rename our graphql endpoint from api/siem/graphql to api/solutions/security/graphql

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-06-01T20:47:11Z

Pinging @elastic/endpoint-response (Team:Endpoint Response)

elasticmachine · 2020-06-01T20:47:12Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

elasticmachine · 2020-06-01T20:47:13Z

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

elasticmachine · 2020-06-01T20:47:15Z

Pinging @elastic/siem (Team:SIEM)

…gation

spalger

Operations: Jenkins, eslint, codeowners, storybook, and ts project configs all LGTM

…gation

lukeelmers · 2020-06-03T16:16:04Z

src/plugins/advanced_settings/public/management_app/lib/get_category_name.ts

@@ -46,8 +46,8 @@ const names: Record<string, string> = {
  search: i18n.translate('advancedSettings.categoryNames.searchLabel', {
    defaultMessage: 'Search',
  }),
-  siem: i18n.translate('advancedSettings.categoryNames.siemLabel', {
-    defaultMessage: 'SIEM',
+  securitySolution: i18n.translate('advancedSettings.categoryNames.securitySolutionLabel', {


I'm not certain you will want to change the securitySolution category key here, since x-pack/plugins/security_solution/server/ui_settings.ts is still using siem as the category name when registering settings, and I believe that's how we find the right category here.

It might be safer to leave the key as siem since it isn't surfaced in the UI, and just keep the new defaultMessage. (Or change all of the uiSettings you register to use the new category)

I think I will prefer to change it everywhere and avoid a mismatch of stuff

@lukeelmers Thank you so much for finding it!!!

After talking with some good folks, We will need to create a follow up to migrate our siem settings to securitySolution

mattkime

app arch changes lgtm

…gation

XavierM · 2020-06-03T19:37:58Z

Seeing an issue where the events filter in Timeline is not filtering-out non signal events. To reproduce:

Drag a host to the timeline that does not have signals associated with it

In the timeline, change the events filter from All events to Signal events

Expected result

The non-signal events are no longer displayed

Actual result

The non-signal events still appear

It is already broken in master let's create an issue to fix it.

stephmilovic

LGTM on Cases!

Checked out locally and manually tested the following:

all cases table and filters
create case
create case, no default connector
create new connector
create case, set default connector
case comment
delete case
close case
case updates
push case to 3rd party

Thanks for the biggest ~~SIEM~~ security_solution PR ever @XavierM

…gation

kibanamachine · 2020-06-04T04:24:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 813e216

History

💔 Build #51627 failed a982675
💔 Build #51598 failed 77307f6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (26 commits) [Console]remove completion for type for filter queries and aggs (elastic#68103) [ML] Transforms: Filter aggregation support (elastic#67591) [ES UI Shared] Monaco XJSON (elastic#67485) [Index Management] Add data streams functionality to indices tab (elastic#67940) [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577) [SECURITY] Rename siem plugin to security_solution (elastic#67902) [Uptime] Fix Telemetry Api flaky test (elastic#67358) [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) ...

* rename siem to security_solution * rename siem to security solution inside of code * rename translation keys * fix snapshot * replace siem for security solution in tutorial * missing translation to be renamed * fix types for api test integration * updates runner file to match the new path * change category for kibana settings * miss renaming in advance settings * fixes cypress tests * fix api integration test * fix new translation * fix unit test * update translation i18n * update translation i18n II Co-authored-by: Gloria Hornero <[email protected]>

* rename siem to security_solution * rename siem to security solution inside of code * rename translation keys * fix snapshot * replace siem for security solution in tutorial * missing translation to be renamed * fix types for api test integration * updates runner file to match the new path * change category for kibana settings * miss renaming in advance settings * fixes cypress tests * fix api integration test * fix new translation * fix unit test * update translation i18n * update translation i18n II Co-authored-by: Gloria Hornero <[email protected]> Co-authored-by: Gloria Hornero <[email protected]>

elasticmachine · 2021-09-23T14:34:03Z

Pinging @elastic/security-solution (Team: SecuritySolution)

rename siem to security_solution

cbc5943

XavierM added release_note:enhancement Team:SIEM v8.0.0 Team:Endpoint Response Endpoint Response Team Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Endpoint Management v7.9.0 labels Jun 1, 2020

XavierM added 2 commits June 2, 2020 16:55

rename siem to security solution inside of code

ead68f5

rename translation keys

68e4f1d

XavierM force-pushed the security-navigation branch from ffe38be to 68e4f1d Compare June 2, 2020 21:15

XavierM added 2 commits June 2, 2020 20:29

Merge branch 'master' of github.com:elastic/kibana into security-navi…

d48736b

…gation

fix snapshot

2ba9145

XavierM marked this pull request as ready for review June 3, 2020 00:47

XavierM requested review from a team as code owners June 3, 2020 00:47

spalger approved these changes Jun 3, 2020

View reviewed changes

XavierM added 3 commits June 2, 2020 21:10

replace siem for security solution in tutorial

f0ee47d

missing translation to be renamed

76762fa

Merge branch 'master' of github.com:elastic/kibana into security-navi…

5698af8

…gation

rw-access approved these changes Jun 3, 2020

View reviewed changes

lukeelmers reviewed Jun 3, 2020

View reviewed changes

mattkime approved these changes Jun 3, 2020

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into security-navi…

7a676cf

…gation

stephmilovic approved these changes Jun 3, 2020

View reviewed changes

XavierM added 8 commits June 3, 2020 17:06

fix api integration test

8d4203e

Merge branch 'master' of github.com:elastic/kibana into security-navi…

774e2e6

…gation

Merge branch 'master' of github.com:elastic/kibana into security-navi…

2586899

…gation

Merge branch 'master' of github.com:elastic/kibana into security-navi…

c7d7ee4

…gation

Merge branch 'master' of github.com:elastic/kibana into security-navi…

77307f6

…gation

fix new translation

7121d65

Merge branch 'master' of github.com:elastic/kibana into security-navi…

955a9ce

…gation

fix unit test

f86c062

elastic deleted a comment from kibanamachine Jun 4, 2020

XavierM added 4 commits June 3, 2020 21:11

update translation i18n

b332c7b

Merge branch 'master' of github.com:elastic/kibana into security-navi…

a982675

…gation

update translation i18n II

3017b1e

Merge branch 'master' of github.com:elastic/kibana into security-navi…

813e216

…gation

XavierM merged commit 1216b0f into elastic:master Jun 4, 2020

XavierM mentioned this pull request Jun 4, 2020

[7.x] [SECURITY] Rename siem plugin to security_solution (#67902) #68246

Merged

spong mentioned this pull request Jun 4, 2020

[SIEM][Detections] Restructure Detections page to reflect unified Alerts view #65946

Closed

angorayc mentioned this pull request Jun 4, 2020

[SIEM] Update links for add-data button #68240

Merged

7 tasks

cnasikas mentioned this pull request Jun 5, 2020

[SIEM][CASE] Change SIEM to Security #68365

Merged

1 task

spong mentioned this pull request Jun 16, 2020

[Security][Detections] Update ML Jobs group from SIEM to Security #69319

Closed

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

kibanamachine mentioned this pull request Jan 24, 2022

[SecuritySolution][Hosts] All hosts table OS column tooltip #123377

Merged

kibanamachine mentioned this pull request Feb 9, 2022

[Security Solution] Bugfix for inspect index pattern not aligned with data view index pattern #125007

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SECURITY] Rename siem plugin to security_solution #67902

[SECURITY] Rename siem plugin to security_solution #67902

XavierM commented Jun 1, 2020 •

edited

Loading

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

spalger left a comment

lukeelmers Jun 3, 2020

XavierM Jun 3, 2020

XavierM Jun 3, 2020

XavierM Jun 3, 2020

mattkime left a comment

XavierM commented Jun 3, 2020

stephmilovic left a comment •

edited

Loading

kibanamachine commented Jun 4, 2020

elasticmachine commented Sep 23, 2021

[SECURITY] Rename siem plugin to security_solution #67902

[SECURITY] Rename siem plugin to security_solution #67902

Conversation

XavierM commented Jun 1, 2020 • edited Loading

Summary

Checklist

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

elasticmachine commented Jun 1, 2020

spalger left a comment

Choose a reason for hiding this comment

lukeelmers Jun 3, 2020

Choose a reason for hiding this comment

XavierM Jun 3, 2020

Choose a reason for hiding this comment

XavierM Jun 3, 2020

Choose a reason for hiding this comment

XavierM Jun 3, 2020

Choose a reason for hiding this comment

mattkime left a comment

Choose a reason for hiding this comment

XavierM commented Jun 3, 2020

stephmilovic left a comment • edited Loading

Choose a reason for hiding this comment

kibanamachine commented Jun 4, 2020

💚 Build Succeeded

History

elasticmachine commented Sep 23, 2021

XavierM commented Jun 1, 2020 •

edited

Loading

stephmilovic left a comment •

edited

Loading