[ENDPOINT][INGEST]Task/endpoint ingest update #67234

parkiino · 2020-05-22T01:09:26Z

Summary

Create datasource flow in Ingest app has modified text specific to the endpoint data source
Edit datasource flow in Ingest app has modified text + link to policy details in the endpoint app

Issues:
https://github.com/elastic/endpoint-app-team/issues/400
https://github.com/elastic/endpoint-app-team/issues/382

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2020-05-22T01:09:30Z

Pinging @elastic/ingest-management (Team:Ingest Management)

elasticmachine · 2020-05-22T01:12:19Z

Pinging @elastic/endpoint-management (Team:Endpoint Management)

oatkiller · 2020-05-26T16:09:00Z

...t_manager/sections/agent_config/create_datasource_page/components/endpoint_configuration.tsx

+            id="xpack.ingestManager.editDatasource.stepConfigure.endpointConfiguration"
+            defaultMessage="See security app policy tab for additional configuration options: "
+          />
+          <EuiLink href={linkToSiemApp}>Click me to configure</EuiLink>


Missing i18n here.

Also, UX recommendation re: links. Phrase it like:

See <a href="">security app policy tab</a> for additional configuration options.

You can google ux "here" link to see a lot of articles which all agree (but with various reasonings.)

The a11y reason is that an assistive device that lists links would show 'Click me to configure' as a place you can link to. In this case 'security app policy tab' is a better description.

The usability reason is basically this: If a user scans for buttons/links in order to take their next action, they'll see a 'Click me...' link, and then have to scan the previous paragraph to figure out what it does. The idea is that by placing a description of where the link goes in the link itself, the user can scan the page for links and see what they do.

kevinlog · 2020-05-26T17:15:53Z

...t_manager/sections/agent_config/create_datasource_page/components/endpoint_configuration.tsx

+            id="xpack.ingestManager.editDatasource.stepConfigure.endpointConfiguration"
+            defaultMessage="See security app policy tab for additional configuration options: "
+          />
+          <EuiLink href={linkToSiemApp}>Click me to configure</EuiLink>


Since we'll be switching apps here, I think we have do a little bit more to avoid the full app refresh.

@paul-tavares does something similar here https://github.com/elastic/kibana/blob/master/x-pack/plugins/siem/public/endpoint_policy/view/policy_list.tsx#L137

parkiino · 2020-05-26T17:25:24Z

@oatkiller I am waiting on @caitlinbetz and @bfishel to confirm the new wording. Everything is just a placeholder right now. but i shall i18n!

…est-update

spalger · 2020-05-26T23:07:47Z

@elasticmachine merge upstream

spalger · 2020-05-26T23:08:17Z

(jenkins upgrade required killing all jobs)

jfsiii · 2020-05-26T23:24:56Z

Since other plugins might also need this ability, it'd be nice if we could do it in a way local to the plugin vs inside Ingest.

I don't want to stop progress because we don't have an answer today, but I think we should confirm other plugins need this and come up with reasonable way for them to do it.

Essentially, I would like an O(1) approach in Ingest vs O(n)

parkiino · 2020-05-27T15:10:03Z

@jfsiii We thought about this too and agree that it'd be preferred if the code lived inside the actual plugin, but went ahead with the workaround for now. I made a discussion ticket to track any conversation about this: https://github.com/elastic/endpoint-app-team/issues/443

paul-tavares · 2020-06-01T18:45:15Z

x-pack/plugins/ingest_manager/public/applications/ingest_manager/index.tsx

@@ -229,15 +230,15 @@ const IngestManagerApp = ({
  const isDarkMode = useObservable<boolean>(coreStart.uiSettings.get$('theme:darkMode'));
  return (
    <coreStart.i18n.Context>
-      <CoreContext.Provider value={coreStart}>
+      <KibanaContextProvider services={{ ...coreStart }}>


Ingest Team: FYI: I actually learned about this functionality from Kibana from one of you - maybe @jfsiii 😄

paul-tavares · 2020-06-01T18:52:17Z

...ager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx

+);
+
+export const CustomConfigureDatasource = (props: CustomConfigureDatasourceProps) => {
+  const ConfigureDatasourceContent =


@jen-huang The package definition has a flag called solution whose comment indicates that it should be the trigger for displaying a custom configuration UI - see: https://github.com/elastic/package-storage/blob/master/packages/endpoint/0.1.0/manifest.yml#L23

I don't see that property defined in Datasources type, so I assume that is future functionality?

Yes, we need to implement that on the ingest management side. Could you make an issue for it? I wasn't aware that flag was already implemented on registry side :)

Thanks @jen-huang . Created #67939 to track

paul-tavares · 2020-06-01T18:56:08Z

...t_manager/sections/agent_config/create_datasource_page/components/endpoint_configuration.tsx

+  return (
+    <>
+      {editMode === true ? (
+        <EuiLink


Can we move the components that are returned here to our source and export it from there?
It would be best if we keep all domain specific code in one place. Maybe you just need to add a Prop to the endpoint's <ConfigureEndpointDatasource> component called editMode and have it drive the returned UI.

++ to above, CustomConfigureDatasourceProps has property called from which you can test from === 'edit' to detect create vs edit mode

Edit: Oh, I think this is just a left over file from the initial POC and not referenced anywhere. There is an equivalent file under /siem in this PR

paul-tavares · 2020-06-01T18:58:45Z

x-pack/plugins/ingest_manager/public/index.ts

@@ -11,3 +11,5 @@ export { IngestManagerStart } from './plugin';
 export const plugin = (initializerContext: PluginInitializerContext) => {
  return new IngestManagerPlugin(initializerContext);
 };
+
+export { CustomConfigureDatasourceContent } from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';


Why is this exported out of Ingest?

CustomConfigureDatasourceContent is a type which Endpoint (and other consumers) should implement to ensure that the custom content will be rendered correctly by Ingest Manager. I believe @parkiino pulled this from my POC, I elaborate on this here: https://github.com/elastic/endpoint-app-team/issues/443#issuecomment-635021439

ahh. Got it. Thank @jen-huang
I had been importing types from ...ingest_manager/public/common so I was perhaps expecting it to come from there.

paul-tavares · 2020-06-01T18:59:10Z

x-pack/plugins/siem/public/index.ts

@@ -11,3 +11,5 @@ import { PluginSetup, PluginStart } from './types';
 export const plugin = (context: PluginInitializerContext): Plugin => new Plugin(context);

 export { Plugin, PluginSetup, PluginStart };
+
+export { ConfigureEndpointDatasource } from './management/pages/policy/view/ingest_manager_integration/configure_datasource';


We should add JSDocs to this, since its a plugin level export.

paul-tavares · 2020-06-01T19:01:24Z

...siem/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx

+import { EuiEmptyPrompt, EuiText } from '@elastic/eui';
+import { useKibana } from '../../../../../../../../../src/plugins/kibana_react/public';
+import { LinkToApp } from '../../../../../common/components/endpoint/link_to_app';
+import { CustomConfigureDatasourceContent } from '../../../../../../../ingest_manager/public';


Hmmm... 🤔 this was weird to me too. I will read up on what @oatkiller found with above link to understand better.

paul-tavares · 2020-06-01T19:04:36Z

...siem/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx

+export const ConfigureEndpointDatasource = memo<CustomConfigureDatasourceContent>(
+  ({ from }: { from: string }) => {
+    const { services } = useKibana();
+    const pathname = useLocation().pathname.split('/');


I don't suggest us using custom logic to parse out the URL. I suggest that this component be given the datasourceId as an input prop, and then drive the UI below based on that. It may also address my earlier comment about moving code from Ingest here.

…est-update

paul-tavares

👍
my comments were minor - I'm ok with this merging.

paul-tavares · 2020-06-02T19:40:59Z

x-pack/plugins/ingest_manager/common/types/models/datasource.ts

@@ -43,6 +43,9 @@ export interface DatasourceInput extends Omit<NewDatasourceInput, 'streams'> {
  streams: DatasourceInputStream[];
 }

+/**
+ * Type of `datasource` prop in CustomConfigureDatasourceContent


Not sure about this comment.
NewDatasource is the interface needed to supplement the create API for datasource and I think is reused on the server as well - so its not only a client side UI type.

ok i might just take that comment out

paul-tavares · 2020-06-02T19:45:37Z

...ns/ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx

  packageInfo: PackageInfo;
-  datasource: NewDatasource;
+  datasource: NewDatasource | (NewDatasource & { id: string });


maybe? 😬

If also export the CustomConfigureDatasourceProps, then you can:

Suggested change

datasource: NewDatasource | (NewDatasource & { id: string });

datasource: CustomConfigureDatasourceProps['datasource'];

paul-tavares · 2020-06-02T19:46:27Z

...ager/public/applications/ingest_manager/sections/agent_config/edit_datasource_page/index.tsx

@@ -69,7 +69,8 @@ export const EditDatasourcePage: React.FunctionComponent = () => {
  const [loadingError, setLoadingError] = useState<Error>();
  const [agentConfig, setAgentConfig] = useState<AgentConfig>();
  const [packageInfo, setPackageInfo] = useState<PackageInfo>();
-  const [datasource, setDatasource] = useState<NewDatasource>({
+  const [datasource, setDatasource] = useState<NewDatasource & { id: string }>({


Same here for the type, if you like 😃

paul-tavares · 2020-06-02T19:47:59Z

x-pack/plugins/ingest_manager/public/index.ts

@@ -11,3 +11,5 @@ export { IngestManagerStart } from './plugin';
 export const plugin = (initializerContext: PluginInitializerContext) => {
  return new IngestManagerPlugin(initializerContext);
 };
+
+export { CustomConfigureDatasourceContent } from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';


ahh. Got it. Thank @jen-huang
I had been importing types from ...ingest_manager/public/common so I was perhaps expecting it to come from there.

paul-tavares · 2020-06-02T19:48:30Z

x-pack/plugins/siem/public/index.ts

@@ -11,3 +11,9 @@ import { PluginSetup, PluginStart } from './types';
 export const plugin = (context: PluginInitializerContext): Plugin => new Plugin(context);

 export { Plugin, PluginSetup, PluginStart };
+
+/**


did you forget to move these comments to the actual component?

oatkiller · 2020-06-02T19:54:51Z

...siem/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx

+    if (from === 'edit') {
+      policyUrl = getManagementUrl({
+        name: 'policyDetails',
+        policyId: (datasource as DatasourceWithId).id,


is this cast safe? or should you be checking if datasource has an id? (just asking, not familiar w/ the code.)

@oatkiller The cast is safe and necessary since tsserver doesn't realize that datasource does have an id if it's coming from the edit flow. the edit flow always sends in the id of the datasource

jfsiii

Sorry this didn't submit earlier. I'm back at my computer now and will look into it more deeply

jfsiii · 2020-06-02T12:56:37Z

...ager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx

+import React from 'react';
+import { FormattedMessage } from '@kbn/i18n/react';
+import { EuiEmptyPrompt, EuiText } from '@elastic/eui';
+import { ConfigureEndpointDatasource } from '../../../../../../../../siem/public';


Doesn't this create a circular dependency? Ingest now depends on SIEM which already depends on Ingest.

I'm away from my computer for a bit so I can't dig in, but can Ingest definite/export this instead?

jfsiii · 2020-06-02T21:43:05Z

Did a quick test, but have to step away for evening routine.

How about something like this? The Ingest Manager will export a registerXYZ function from public directory or start lifecycle, etc that siem and others can import and call when they need to?

Like I said, I didn't get to run this through in the UI but the TS types work in the editor and I think the flow works.

If so, Ingest no longer knows anything about siem and the cross dependency would be resolved.

🤞 Take a look and let me know

diff --git a/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx b/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx
index 0c350b407e8..dc0d7693eea 100644
--- a/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx
+++ b/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx
@@ -6,7 +6,6 @@
 import React from 'react';
 import { FormattedMessage } from '@kbn/i18n/react';
 import { EuiEmptyPrompt, EuiText } from '@elastic/eui';
-import { ConfigureEndpointDatasource } from '../../../../../../../../siem/public';
 import { NewDatasource } from '../../../../types';
 import { CreateDatasourceFrom } from '../types';

@@ -22,9 +21,17 @@ export interface CustomConfigureDatasourceProps {
  */
 export type CustomConfigureDatasourceContent = React.FC<CustomConfigureDatasourceProps>;

-const ConfigureDatasourceMapping: { [key: string]: CustomConfigureDatasourceContent } = {
-  endpoint: ConfigureEndpointDatasource,
-};
+type AllowedDatasourceKey = 'endpoint';
+const ConfigureDatasourceMapping: {
+  [key: string]: CustomConfigureDatasourceContent; // I don't know why AllowedDatasourceKey isn't a valid type
+} = {};
+
+export function registerDatasource(
+  key: AllowedDatasourceKey,
+  value: CustomConfigureDatasourceContent
+) {
+  ConfigureDatasourceMapping[key] = value;
+}

 const EmptyConfigureDatasource: CustomConfigureDatasourceContent = () => (
   <EuiEmptyPrompt
diff --git a/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/index.ts b/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/index.ts
index 42848cc0f5e..b2e004dc41c 100644
--- a/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/index.ts
+++ b/x-pack/plugins/ingest_manager/public/applications/ingest_manager/sections/agent_config/create_datasource_page/components/index.ts
@@ -6,4 +6,4 @@
 export { CreateDatasourcePageLayout } from './layout';
 export { DatasourceInputPanel } from './datasource_input_panel';
 export { DatasourceInputVarField } from './datasource_input_var_field';
-export { CustomConfigureDatasource } from './custom_configure_datasource';
+export { CustomConfigureDatasource, registerDatasource } from './custom_configure_datasource';
diff --git a/x-pack/plugins/ingest_manager/public/index.ts b/x-pack/plugins/ingest_manager/public/index.ts
index 10a7eff30fa..0fbcbb43967 100644
--- a/x-pack/plugins/ingest_manager/public/index.ts
+++ b/x-pack/plugins/ingest_manager/public/index.ts
@@ -12,6 +12,9 @@ export const plugin = (initializerContext: PluginInitializerContext) => {
   return new IngestManagerPlugin(initializerContext);
 };

-export { CustomConfigureDatasourceContent } from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';
+export {
+  CustomConfigureDatasourceContent,
+  registerDatasource,
+} from './applications/ingest_manager/sections/agent_config/create_datasource_page/components/custom_configure_datasource';

 export { NewDatasource } from './applications/ingest_manager/types';

jen-huang

I don't think the current import/export from Ingest and SIEM create a circular dependency as the import of the Endpoint component from Ingest is just a static file import. I like @jfsiii's approach to of exposing registration from Ingest's /public (and I agree that exposing from lifecycle method would be even better).

Giving this a 👍 as the code between plugins is separated and we can iterate on the custom component registration logic from here.

paul-tavares · 2020-06-03T13:48:39Z

I also like the approach detailed by @jfsiii in exposing these methods via the Plugin's lifecycle - I think it fits even more into the overall architecture. As @jen-huang mentioned, I'm also ok with getting this in and opening up an issue to iterate over its implementation.
👍

…est-update

kevinlog · 2020-06-03T20:47:22Z

x-pack/plugins/siem/public/plugin.tsx

@@ -131,6 +132,7 @@ export class Plugin implements IPlugin<PluginSetup, PluginStart, SetupPlugins, S

  public start(core: CoreStart, plugins: StartPlugins) {
    KibanaServices.init({ ...core, ...plugins, kibanaVersion: this.kibanaVersion });
+    plugins.ingestManager.registerDatasource('endpoint', ConfigureEndpointDatasource);


this is cool

kibanamachine · 2020-06-03T21:28:32Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 165c0fb

History

💚 Build #51216 succeeded 635d035
💚 Build #51147 succeeded 4f4e14c
💚 Build #51127 succeeded 9ee8750
💚 Build #50912 succeeded 2208beb
💚 Build #50870 succeeded 04dee90

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Custom endpoint Datasource configuration in ingest Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Jen Huang <[email protected]>

Custom endpoint Datasource configuration in ingest Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Jen Huang <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Jen Huang <[email protected]>

…ms-column * 'master' of github.com:elastic/kibana: (63 commits) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) Update documentation/examples of deprecated namespaceAgnostic field (elastic#68039) [DOCS] Updates Canvas docs with new menus (elastic#66061) chore(NA): avoids imports of server or public code into common (elastic#67231) [SIEM] Fix GetOneTimeline graphql type (elastic#68137) skip flaky suite (elastic#67838) [Uptime] Add loading message for monitor list no items (elastic#67378) [Ingest Manager] Update indexing strategy docs to use dataset.* (elastic#68068) [Ingest Manager] Fix datasource validation for streams without vars (elastic#67950) ... # Conflicts: # x-pack/plugins/index_management/__jest__/client_integration/helpers/index.ts # x-pack/plugins/index_management/__jest__/client_integration/home.test.ts # x-pack/plugins/index_management/__jest__/client_integration/home/index_templates_tab.helpers.ts

* master: (26 commits) [Console]remove completion for type for filter queries and aggs (elastic#68103) [ML] Transforms: Filter aggregation support (elastic#67591) [ES UI Shared] Monaco XJSON (elastic#67485) [Index Management] Add data streams functionality to indices tab (elastic#67940) [Discover] Fix renaming of saved search not displayed in breadcrumb (elastic#67577) [SECURITY] Rename siem plugin to security_solution (elastic#67902) [Uptime] Fix Telemetry Api flaky test (elastic#67358) [Data plugin] Add configuration property to enable / disable autocomplete (elastic#67847) remove scripts. prettire update has been done (elastic#68130) Closes elastic#68055 by detecting the local Kibana version and using that as (elastic#68198) [apm] docs: add deployment annotation example (elastic#67408) [ML] Extend population preview chart to show actual and typical value (elastic#67569) Refactor index management client integration tests for scalability (elastic#67917) Add generator function that creates multiple alerts (elastic#67713) chore(NA): remove config arg from os packages (elastic#67871) [Reporting] Move code out of Legacy (elastic#67904) [Metrics UI] Add overrides to Snapshot API to support alert previews (elastic#68125) [Security] [Cases] Manage timeline UI API (elastic#67719) [ENDPOINT][INGEST]Task/endpoint ingest update (elastic#67234) Fix code coverage for jest, upload merged reports (elastic#68149) ...

…68721)

* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...

parkiino added 5 commits May 21, 2020 18:18

endpoint advanced config. changed message

e300f90

add edit mode

11c3837

no more endpoint

0cf3ae9

wow it werks but after going down the wrong path

82b20af

fix type script error

2b0fa3e

botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label May 22, 2020

parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Endpoint Management v7.9.0 v8.0.0 labels May 22, 2020

rename linky

4ccc118

parkiino marked this pull request as ready for review May 26, 2020 15:49

parkiino requested a review from a team May 26, 2020 15:49

oatkiller reviewed May 26, 2020

View reviewed changes

kevinlog reviewed May 26, 2020

View reviewed changes

parkiino added 2 commits May 26, 2020 14:10

Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…

3398ed6

…est-update

use navigatetoapp, no refresh

f232a7c

Merge branch 'master' into task/endpoint-injest-update

b1777d9

jen-huang self-requested a review May 27, 2020 00:44

parkiino changed the title ~~[POC][ENDPOINT]Task/endpoint ingest update~~ [ENDPOINT][INGEST]Task/endpoint ingest update May 27, 2020

parkiino changed the title ~~[ENDPOINT][INGEST]Task/endpoint ingest update~~ [POC][ENDPOINT][INGEST]Task/endpoint ingest update May 27, 2020

parkiino changed the title ~~[POC][ENDPOINT][INGEST]Task/endpoint ingest update~~ [ENDPOINT][INGEST]Task/endpoint ingest update May 27, 2020

fixed wording

8444aec

paul-tavares reviewed Jun 1, 2020

View reviewed changes

paul-tavares mentioned this pull request Jun 2, 2020

[Ingest Manager] Refactor Datasource create/edit forms to recognize and support the package's solution field to drive displaying a custom UI for configuration #67939

Closed

parkiino added 3 commits June 2, 2020 11:48

grab policyId from datasource

b43801e

Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…

9ee8750

…est-update

update doc comments

4f4e14c

paul-tavares approved these changes Jun 2, 2020

View reviewed changes

oatkiller reviewed Jun 2, 2020

View reviewed changes

jfsiii reviewed Jun 2, 2020

View reviewed changes

pauls comments

635d035

jen-huang approved these changes Jun 2, 2020

View reviewed changes

parkiino added 2 commits June 3, 2020 15:50

registerDatasource from plugin lifecycle

ac2441d

Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…

165c0fb

…est-update

kevinlog reviewed Jun 3, 2020

View reviewed changes

kevinlog approved these changes Jun 3, 2020

View reviewed changes

parkiino merged commit dd86ccf into elastic:master Jun 3, 2020

parkiino mentioned this pull request Jun 3, 2020

[7.x] [ENDPOINT][INGEST]Task/endpoint ingest update (#67234) #68181

Merged

jen-huang added a commit to jen-huang/kibana that referenced this pull request Jun 8, 2020

Fix edit datasource not working following changes in elastic#67234

37362fe

jen-huang mentioned this pull request Jun 8, 2020

[Ingest Manager] Fix edit data source not working #68583

Merged

jen-huang added a commit that referenced this pull request Jun 9, 2020

Fix edit datasource not working following changes in #67234 (#68583)

4f2c199

jen-huang mentioned this pull request Jun 9, 2020

[7.x] Fix edit datasource not working following changes in #67234 (#68583) #68721

Merged

jen-huang added a commit that referenced this pull request Jun 10, 2020

Fix edit datasource not working following changes in #67234 (#68583) (#…

fa5585f

…68721)

parkiino deleted the task/endpoint-injest-update branch July 27, 2020 19:06

	datasource: NewDatasource \| (NewDatasource & { id: string });
	datasource: CustomConfigureDatasourceProps['datasource'];

[ENDPOINT][INGEST]Task/endpoint ingest update #67234

[ENDPOINT][INGEST]Task/endpoint ingest update #67234

Conversation

parkiino commented May 22, 2020 • edited Loading

Summary

Checklist

For maintainers

elasticmachine commented May 22, 2020

elasticmachine commented May 22, 2020

oatkiller May 26, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parkiino commented May 26, 2020

spalger commented May 26, 2020

spalger commented May 26, 2020

jfsiii commented May 26, 2020

parkiino commented May 27, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paul-tavares left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfsiii left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jfsiii commented Jun 2, 2020

jen-huang left a comment

Choose a reason for hiding this comment

paul-tavares commented Jun 3, 2020

Choose a reason for hiding this comment

kibanamachine commented Jun 3, 2020

💚 Build Succeeded

History

parkiino commented May 22, 2020 •

edited

Loading

oatkiller May 26, 2020 •

edited

Loading