Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert of "Sync Kerberos + Anonymous access tests with the latest security/_authenticate API (user roles now include roles of anonymous user)." #68624

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin commented Jun 9, 2020

Partial revert of #65421 since ES team decided to revert the change that this test was validating.

We can merge this PR only once ES change is included into recent 7.8/7.x/master snapshots we use on CI.

@azasypkin azasypkin added test chore Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Security/Authentication Platform Security - Authentication v7.8.0 v7.9.0 labels Jun 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

…test `security/_authenticate` API (user roles now include roles of anonymous user)."
@azasypkin azasypkin force-pushed the issue-xxx-revert-kerberos-tests branch from c2e512d to 4621296 Compare June 10, 2020 04:22
@tylersmalley
Copy link
Contributor

You will want to re-run CI once the snapshot is promoted here: https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/878/

@tylersmalley
Copy link
Contributor

tylersmalley commented Jun 10, 2020

It was promoted

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #52932 succeeded c2e512d3d11f3ae6d25f2addd50df8b3b0a2c3cc

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@azasypkin azasypkin requested a review from watson June 10, 2020 06:57
Copy link
Contributor

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@azasypkin azasypkin merged commit 204977c into elastic:master Jun 10, 2020
@azasypkin azasypkin deleted the issue-xxx-revert-kerberos-tests branch June 10, 2020 07:10
azasypkin added a commit to azasypkin/kibana that referenced this pull request Jun 10, 2020
…test `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624)
azasypkin added a commit to azasypkin/kibana that referenced this pull request Jun 10, 2020
…test `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 10, 2020
* master: (22 commits)
  Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624)
  adapt some snapshot test (elastic#68489)
  [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486)
  [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user
  [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294)
  Surface data streams in Index Management. (elastic#67806)
  Fix edit datasource not working following changes in elastic#67234 (elastic#68583)
  [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654)
  APM Storybook fixes (elastic#68671)
  Upgrade EUI to v24.1.0 (elastic#68141)
  [ML] DF Analytics: Creation wizard part 2 (elastic#68462)
  [Uptime] Fix race on overview page query (elastic#67843)
  Prefer using npm_execpath when spawning Yarn (elastic#68673)
  [Security] [Cases] Attach timeline to existing case (elastic#68580)
  Use Search API in Vega (elastic#68257)
  [Component templates] Table view (elastic#68031)
  [Uptime] Added relative date info in cert status column (elastic#67612)
  [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445)
  run page_load_metrics tests in visual regresssion jobs (elastic#68570)
  Enable exhaustive-deps; correct any lint warnings (elastic#68453)
  ...
azasypkin added a commit that referenced this pull request Jun 10, 2020
…the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (#68624) (#68742)
@azasypkin
Copy link
Member Author

azasypkin commented Jun 10, 2020

7.8/7.8.0: ffa479d
7.x/7.9.0: f954f7b

@tylersmalley
Copy link
Contributor

tylersmalley commented Jun 10, 2020

I just triggered a build/verify of 7.x/7.9 https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/880/

azasypkin added a commit that referenced this pull request Jun 10, 2020
…the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (#68624) (#68741)
@azasypkin
Copy link
Member Author

I just triggered a build/verify of 7.x/7.9 https://kibana-ci.elastic.co/job/elasticsearch+snapshots+verify/880/

Thanks! CI passed, backported to 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported chore Feature:Security/Authentication Platform Security - Authentication release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! test v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants