Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial revert of "Sync Kerberos + Anonymous access tests with the latest security/_authenticate API (user roles now include roles of anonymous user)." #68624

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Partial revert of "Sync Kerberos + Anonymous access tests with the latest security/_authenticate API (user roles now include roles of anonymous user)." #68624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4621296
Partial revert of "Sync Kerberos + Anonymous access tests with the la…
azasypkin Jun 9, 2020
988239b
Merge branch 'master' into issue-xxx-revert-kerberos-tests
elasticmachine Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions x-pack/test/kerberos_api_integration/apis/security/kerberos_login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,7 @@ export default function ({ getService }: FtrProviderContext) {
});

describe('finishing SPNEGO', () => {
// Skipped: https://github.com/elastic/kibana/issues/68720
it.skip('should properly set cookie and authenticate user', async () => {
it('should properly set cookie and authenticate user', async () => {
const response = await supertest
.get('/internal/security/me')
.set('Authorization', `Negotiate ${spnegoToken}`)
Expand All @@ -116,14 +115,7 @@ export default function ({ getService }: FtrProviderContext) {
const sessionCookie = request.cookie(cookies[0])!;
checkCookieIsSet(sessionCookie);

const isAnonymousAccessEnabled = (config.get(
'esTestCluster.serverArgs'
) as string[]).some((setting) => setting.startsWith('xpack.security.authc.anonymous'));

// `superuser_anonymous` role is derived from the enabled anonymous access.
const expectedUserRoles = isAnonymousAccessEnabled
? ['kibana_admin', 'superuser_anonymous']
: ['kibana_admin'];
const expectedUserRoles = ['kibana_admin'];

await supertest
.get('/internal/security/me')
Expand Down