-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENDPOINT][INGEST]Task/endpoint ingest update #67234
Merged
parkiino
merged 25 commits into
elastic:master
from
parkiino:task/endpoint-injest-update
Jun 3, 2020
Merged
Changes from 6 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e300f90
endpoint advanced config. changed message
parkiino 11c3837
add edit mode
parkiino 0cf3ae9
no more endpoint
parkiino 82b20af
wow it werks but after going down the wrong path
parkiino 2b0fa3e
fix type script error
parkiino 4ccc118
rename linky
parkiino 3398ed6
Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…
parkiino f232a7c
use navigatetoapp, no refresh
parkiino b1777d9
Merge branch 'master' into task/endpoint-injest-update
elasticmachine 8444aec
fixed wording
parkiino 057f440
Merge branch 'task/endpoint-injest-update' of github.com:parkiino/kib…
parkiino f9852af
POC for custom configure data source panel from outside plugin
jen-huang ad71c88
added security text
parkiino 3efce1c
Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…
parkiino 8586e3b
it werks
parkiino 412f5e0
Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…
parkiino 7583c48
removed redundant import, type error
parkiino 04dee90
i18n fix
parkiino 2208beb
remove unused file
parkiino b43801e
grab policyId from datasource
parkiino 9ee8750
Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…
parkiino 4f4e14c
update doc comments
parkiino 635d035
pauls comments
parkiino ac2441d
registerDatasource from plugin lifecycle
parkiino 165c0fb
Merge remote-tracking branch 'upstream/master' into task/endpoint-inj…
parkiino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
34 changes: 34 additions & 0 deletions
34
...anager/sections/agent_config/create_datasource_page/components/endpoint_configuration.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License; | ||
* you may not use this file except in compliance with the Elastic License. | ||
*/ | ||
|
||
import React, { memo } from 'react'; | ||
import { FormattedMessage } from '@kbn/i18n/react'; | ||
import { useLocation } from 'react-router-dom'; | ||
import { EuiLink } from '@elastic/eui'; | ||
|
||
export const EndpointConfiguration = memo<{ editMode: boolean }>(({ editMode }) => { | ||
const pathname = useLocation().pathname.split('/'); | ||
const policyId = pathname[pathname.length - 1]; | ||
const linkToSiemApp = `/app/siem#/policy/${policyId}`; | ||
return ( | ||
<> | ||
{editMode === true ? ( | ||
<> | ||
<FormattedMessage | ||
id="xpack.ingestManager.editDatasource.stepConfigure.endpointConfiguration" | ||
defaultMessage="See security app policy tab for additional configuration options: " | ||
/> | ||
<EuiLink href={linkToSiemApp}>Click me to configure</EuiLink> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since we'll be switching apps here, I think we have do a little bit more to avoid the full app refresh. @paul-tavares does something similar here https://github.com/elastic/kibana/blob/master/x-pack/plugins/siem/public/endpoint_policy/view/policy_list.tsx#L137 |
||
</> | ||
) : ( | ||
<FormattedMessage | ||
id="xpack.ingestManager.createDatasource.stepConfigure.endpointConfiguration" | ||
defaultMessage="See security app policy tab for additional configuration" | ||
/> | ||
)} | ||
</> | ||
); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing i18n here.
Also, UX recommendation re: links. Phrase it like:
You can google
ux "here" link
to see a lot of articles which all agree (but with various reasonings.)The a11y reason is that an assistive device that lists links would show 'Click me to configure' as a place you can link to. In this case 'security app policy tab' is a better description.
The usability reason is basically this: If a user scans for buttons/links in order to take their next action, they'll see a 'Click me...' link, and then have to scan the previous paragraph to figure out what it does. The idea is that by placing a description of where the link goes in the link itself, the user can scan the page for links and see what they do.