Fix edit datasource not working following changes in elastic#67234

jen-huang · Jun 8, 2020 · 37362fe · 37362fe
1 parent 1e45e98
commit 37362fe
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 17 deletions.
diff --git a/...r/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx b/...r/sections/agent_config/create_datasource_page/components/custom_configure_datasource.tsx
@@ -12,7 +12,8 @@ import { CreateDatasourceFrom } from '../types';
 export interface CustomConfigureDatasourceProps {
   packageName: string;
   from: CreateDatasourceFrom;
-  datasource: NewDatasource | (NewDatasource & { id: string });
+  datasource: NewDatasource;
+  datasourceId?: string;
 }
 
 /**

diff --git a/...ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx b/...ingest_manager/sections/agent_config/create_datasource_page/step_configure_datasource.tsx
@@ -16,14 +16,16 @@ import { CreateDatasourceFrom } from './types';
 export const StepConfigureDatasource: React.FunctionComponent<{
   from?: CreateDatasourceFrom;
   packageInfo: PackageInfo;
-  datasource: NewDatasource | (NewDatasource & { id: string });
+  datasource: NewDatasource;
+  datasourceId?: string;
   updateDatasource: (fields: Partial<NewDatasource>) => void;
   validationResults: DatasourceValidationResults;
   submitAttempted: boolean;
 }> = ({
   from = 'config',
   packageInfo,
   datasource,
+  datasourceId,
   updateDatasource,
   validationResults,
   submitAttempted,
@@ -70,9 +72,10 @@ export const StepConfigureDatasource: React.FunctionComponent<{
     ) : (
       <EuiPanel>
         <CustomConfigureDatasource
+          from={from}
           packageName={packageInfo.name}
           datasource={datasource}
-          from={from}
+          datasourceId={datasourceId}
         />
       </EuiPanel>
     );

diff --git a/...r/public/applications/ingest_manager/sections/agent_config/edit_datasource_page/index.tsx b/...r/public/applications/ingest_manager/sections/agent_config/edit_datasource_page/index.tsx
@@ -69,8 +69,7 @@ export const EditDatasourcePage: React.FunctionComponent = () => {
   const [loadingError, setLoadingError] = useState<Error>();
   const [agentConfig, setAgentConfig] = useState<AgentConfig>();
   const [packageInfo, setPackageInfo] = useState<PackageInfo>();
-  const [datasource, setDatasource] = useState<NewDatasource & { id: string }>({
-    id: '',
+  const [datasource, setDatasource] = useState<NewDatasource>({
     name: '',
     description: '',
     config_id: '',
@@ -94,6 +93,7 @@ export const EditDatasourcePage: React.FunctionComponent = () => {
         }
         if (datasourceData?.item) {
           const {
+            id,
             revision,
             inputs,
             created_by,
@@ -302,6 +302,7 @@ export const EditDatasourcePage: React.FunctionComponent = () => {
                     from={'edit'}
                     packageInfo={packageInfo}
                     datasource={datasource}
+                    datasourceId={datasourceId}
                     updateDatasource={updateDatasource}
                     validationResults={validationResults!}
                     submitAttempted={formState === 'INVALID'}

diff --git a/...n/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx b/...n/public/management/pages/policy/view/ingest_manager_integration/configure_datasource.tsx
@@ -12,30 +12,21 @@ import { LinkToApp } from '../../../../../common/components/endpoint/link_to_app
 import {
   CustomConfigureDatasourceContent,
   CustomConfigureDatasourceProps,
-  NewDatasource,
 } from '../../../../../../../ingest_manager/public';
 import { getManagementUrl } from '../../../..';
 
-type DatasourceWithId = NewDatasource & { id: string };
-
 /**
  * Exports Endpoint-specific datasource configuration instructions
  * for use in the Ingest app create / edit datasource config
  */
 export const ConfigureEndpointDatasource = memo<CustomConfigureDatasourceContent>(
-  ({
-    from,
-    datasource,
-  }: {
-    from: string;
-    datasource: CustomConfigureDatasourceProps['datasource'];
-  }) => {
+  ({ from, datasourceId }: CustomConfigureDatasourceProps) => {
     const { services } = useKibana();
     let policyUrl = '';
-    if (from === 'edit') {
+    if (from === 'edit' && datasourceId) {
       policyUrl = getManagementUrl({
         name: 'policyDetails',
-        policyId: (datasource as DatasourceWithId).id,
+        policyId: datasourceId,
       });
     }