-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SECURITY] Rename siem plugin to security_solution #67902
Merged
+11,016
−9,594
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
cbc5943
rename siem to security_solution
XavierM ead68f5
rename siem to security solution inside of code
XavierM 68e4f1d
rename translation keys
XavierM d48736b
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 2ba9145
fix snapshot
XavierM f0ee47d
replace siem for security solution in tutorial
XavierM 76762fa
missing translation to be renamed
XavierM 5698af8
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM d3f6299
fix types for api test integration
XavierM b22fa31
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM df6e7c5
updates runner file to match the new path
MadameSheema b69a88d
Merge branch 'security-navigation' of https://github.com/XavierM/kiba…
MadameSheema 42cec67
change category for kibana settings
XavierM 3342d4e
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 21c89d0
miss renaming in advance settings
XavierM 2fdb92b
Merge branch 'security-navigation' of github.com:XavierM/kibana into …
XavierM 0639936
fixes cypress tests
MadameSheema d2f4d33
Merge branch 'security-navigation' of https://github.com/XavierM/kiba…
MadameSheema af134eb
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 4fa7fbf
Merge branch 'security-navigation' of github.com:XavierM/kibana into …
XavierM 7a676cf
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 8d4203e
fix api integration test
XavierM 774e2e6
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 2586899
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM c7d7ee4
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 77307f6
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 7121d65
fix new translation
XavierM 955a9ce
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM f86c062
fix unit test
XavierM b332c7b
update translation i18n
XavierM a982675
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM 3017b1e
update translation i18n II
XavierM 813e216
Merge branch 'master' of github.com:elastic/kibana into security-navi…
XavierM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rename siem to security solution inside of code
commit ead68f5e5fb0423d38c884c5a4d99b8732d39c59
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../network/components/embeddables/__snapshots__/index_patterns_missing_prompt.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain you will want to change the
securitySolution
category key here, sincex-pack/plugins/security_solution/server/ui_settings.ts
is still usingsiem
as the category name when registering settings, and I believe that's how we find the right category here.It might be safer to leave the key as
siem
since it isn't surfaced in the UI, and just keep the newdefaultMessage
. (Or change all of the uiSettings you register to use the new category)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will prefer to change it everywhere and avoid a mismatch of stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukeelmers Thank you so much for finding it!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After talking with some good folks, We will need to create a follow up to migrate our siem settings to securitySolution