[SIEM] Update links for add-data button #68240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
reviewed
Jun 4, 2020
| @@ -1233,7 +1233,6 @@ | |||
| "home.addData.metrics.nameTitle": "メトリック", | |||
| "home.addData.sampleDataLink": "データセットと Kibana ダッシュボードを読み込む", | |||
| "home.addData.sampleDataTitle": "サンプルデータの追加", | |||
| "home.addData.siem.addSiemEventsButtonLabel": "イベントを追加", | |||
There was a problem hiding this comment.
do not delete just rename the key to home.addData.security.addSecurityEventsButtonLabel
XavierM
reviewed
Jun 4, 2020
| @@ -1367,7 +1366,6 @@ | |||
| "home.tutorial.tabs.loggingTitle": "ログ", | |||
| "home.tutorial.tabs.metricsTitle": "メトリック", | |||
| "home.tutorial.tabs.sampleDataTitle": "サンプルデータ", | |||
| "home.tutorial.tabs.siemTitle": "SIEM", | |||
There was a problem hiding this comment.
do not delete, just rename the key to home.tutorial.tabs.securityTitle and value to Security
XavierM
reviewed
Jun 4, 2020
| @@ -1236,7 +1236,6 @@ | |||
| "home.addData.metrics.nameTitle": "指标", | |||
| "home.addData.sampleDataLink": "加载数据集和 Kibana 仪表板", | |||
| "home.addData.sampleDataTitle": "添加样例数据", | |||
| "home.addData.siem.addSiemEventsButtonLabel": "添加事件", | |||
There was a problem hiding this comment.
Do not delete just rename the key
XavierM
reviewed
Jun 4, 2020
| @@ -1370,7 +1369,6 @@ | |||
| "home.tutorial.tabs.loggingTitle": "日志", | |||
| "home.tutorial.tabs.metricsTitle": "指标", | |||
| "home.tutorial.tabs.sampleDataTitle": "样例数据", | |||
| "home.tutorial.tabs.siemTitle": "SIEM", | |||
There was a problem hiding this comment.
do not delete just rename the key and value to Security
jbudz
reviewed
Jun 4, 2020
XavierM
approved these changes
Jun 4, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Jun 5, 2020
* update links for add-data button * update links * rename SIEM with security * add back missing key * fixup * fixup # Conflicts: # x-pack/plugins/security_solution/public/overview/pages/summary.tsx
angorayc
added a commit
that referenced
this pull request
Jun 5, 2020
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR depends on #67902
Found add data content is not rendered properly after renaming the folder
app/kibana#/home/tutorial_directory/siem => app/kibana#/home/tutorial_directory/security
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibility, including a check against IE11For maintainers
This was checked for breaking API changes and was labeled appropriately