Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Update links for add-data button #68240

Merged
merged 6 commits into from
Jun 4, 2020
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/home/public/application/components/add_data.js
Original file line number Diff line number Diff line change
@@ -221,11 +221,11 @@ const AddDataUi = ({ apmUiEnabled, isNewKibanaInstance, intl, mlEnabled }) => {
footer={
<EuiButton
className="homAddData__button"
href="#/tutorial_directory/siem"
href="#/tutorial_directory/security"
aria-describedby={siemData.ariaDescribedby}
>
<FormattedMessage
id="home.addData.siem.addSiemEventsButtonLabel"
id="home.addData.security.addSecurityEventsButtonLabel"
defaultMessage="Add events"
/>
</EuiButton>
Original file line number Diff line number Diff line change
@@ -75,10 +75,10 @@ class TutorialDirectoryUi extends React.Component {
}),
},
{
id: 'siem',
id: 'security',
name: this.props.intl.formatMessage({
id: 'home.tutorial.tabs.siemTitle',
defaultMessage: 'SIEM',
id: 'home.tutorial.tabs.securityTitle',
defaultMessage: 'Security',
}),
},
{
1 change: 1 addition & 0 deletions x-pack/plugins/security_solution/common/constants.ts
Original file line number Diff line number Diff line change
@@ -8,6 +8,7 @@ export const APP_ID = 'securitySolution';
export const APP_NAME = 'Security';
export const APP_ICON = 'securityAnalyticsApp';
export const APP_PATH = `/app/security`;
export const ADD_DATA_PATH = `/app/home#/tutorial_directory/security`;
export const DEFAULT_BYTES_FORMAT = 'format:bytes:defaultPattern';
export const DEFAULT_DATE_FORMAT = 'dateFormat';
export const DEFAULT_DATE_FORMAT_TZ = 'dateFormat:tz';
Original file line number Diff line number Diff line change
@@ -9,12 +9,13 @@ import React from 'react';
import { useKibana } from '../../../common/lib/kibana';
import { EmptyPage } from '../../../common/components/empty_page';
import * as i18n from '../../../common/translations';
import { ADD_DATA_PATH } from '../../../../common/constants';

export const DetectionEngineEmptyPage = React.memo(() => (
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${useKibana().services.http.basePath.get()}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${useKibana().services.http.basePath.get()}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Original file line number Diff line number Diff line change
@@ -18,6 +18,7 @@ import { MlPopover } from '../ml_popover/ml_popover';
import { SiemNavigation } from '../navigation';
import * as i18n from './translations';
import { indicesExistOrDataTemporarilyUnavailable, WithSource } from '../../containers/source';
import { ADD_DATA_PATH } from '../../../../common/constants';

const Wrapper = styled.header`
${({ theme }) => css`
@@ -86,7 +87,7 @@ export const HeaderGlobal = React.memo<HeaderGlobalProps>(({ hideDetectionEngine
<FlexItem grow={false}>
<EuiButtonEmpty
data-test-subj="add-data"
href="home#/tutorial_directory/siem"
href={ADD_DATA_PATH}
iconType="plusInCircle"
>
{i18n.BUTTON_ADD_DATA}
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ import React from 'react';
import { EmptyPage } from '../../common/components/empty_page';
import { useKibana } from '../../common/lib/kibana';
import * as i18n from '../../common/translations';
import { ADD_DATA_PATH } from '../../../common/constants';

export const HostsEmptyPage = React.memo(() => {
const { http, docLinks } = useKibana().services;
@@ -18,7 +19,7 @@ export const HostsEmptyPage = React.memo(() => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ import React from 'react';
import { useKibana } from '../../common/lib/kibana';
import { EmptyPage } from '../../common/components/empty_page';
import * as i18n from '../../common/translations';
import { ADD_DATA_PATH } from '../../../common/constants';

export const NetworkEmptyPage = React.memo(() => {
const { http, docLinks } = useKibana().services;
@@ -18,7 +19,7 @@ export const NetworkEmptyPage = React.memo(() => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ import React from 'react';
import * as i18nCommon from '../../../common/translations';
import { EmptyPage } from '../../../common/components/empty_page';
import { useKibana } from '../../../common/lib/kibana';
import { ADD_DATA_PATH } from '../../../../common/constants';

const OverviewEmptyComponent: React.FC = () => {
const { http, docLinks } = useKibana().services;
@@ -18,7 +19,7 @@ const OverviewEmptyComponent: React.FC = () => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18nCommon.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18nCommon.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Original file line number Diff line number Diff line change
@@ -8,6 +8,8 @@ import React from 'react';
import { EuiFlexItem, EuiLink, EuiText } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';

import { ADD_DATA_PATH } from '../../../common/constants';

import { useKibana } from '../../common/lib/kibana';

export const Summary = React.memo(() => {
@@ -37,7 +39,7 @@ export const Summary = React.memo(() => {
</EuiLink>
),
data: (
<EuiLink href="kibana#home/tutorial_directory/siem">
<EuiLink href={ADD_DATA_PATH}>
<FormattedMessage
id="xpack.securitySolution.overview.startedText.dataLinkText"
defaultMessage="ingesting data"
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
@@ -1233,7 +1233,6 @@
"home.addData.metrics.nameTitle": "メトリック",
"home.addData.sampleDataLink": "データセットと Kibana ダッシュボードを読み込む",
"home.addData.sampleDataTitle": "サンプルデータの追加",
"home.addData.siem.addSiemEventsButtonLabel": "イベントを追加",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not delete just rename the key to home.addData.security.addSecurityEventsButtonLabel

"home.addData.siem.nameDescription": "即利用可能なビジュアライゼーションで、セキュリティイベントをまとめてインタラクティブな調査を可能にします。",
"home.addData.siem.nameTitle": "SIEM",
"home.addData.title.observability": "オブザーバビリティ",
@@ -1367,7 +1366,6 @@
"home.tutorial.tabs.loggingTitle": "ログ",
"home.tutorial.tabs.metricsTitle": "メトリック",
"home.tutorial.tabs.sampleDataTitle": "サンプルデータ",
"home.tutorial.tabs.siemTitle": "SIEM",
Copy link
Contributor

@XavierM XavierM Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not delete, just rename the key to home.tutorial.tabs.securityTitle and value to Security

"home.tutorial.unexpectedStatusCheckStateErrorDescription": "予期せぬステータス確認ステータス {statusCheckState}",
"home.tutorial.unhandledInstructionTypeErrorDescription": "予期せぬ指示タイプ {visibleInstructions}",
"home.tutorials.activemqLogs.artifacts.dashboards.linkLabel": "ActiveMQ アプリケーションイベント",
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
@@ -1236,7 +1236,6 @@
"home.addData.metrics.nameTitle": "指标",
"home.addData.sampleDataLink": "加载数据集和 Kibana 仪表板",
"home.addData.sampleDataTitle": "添加样例数据",
"home.addData.siem.addSiemEventsButtonLabel": "添加事件",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not delete just rename the key

"home.addData.siem.nameDescription": "集中安全事件,以通过即用型可视化实现交互式调查。",
"home.addData.siem.nameTitle": "SIEM",
"home.addData.title.observability": "可观测性",
@@ -1370,7 +1369,6 @@
"home.tutorial.tabs.loggingTitle": "日志",
"home.tutorial.tabs.metricsTitle": "指标",
"home.tutorial.tabs.sampleDataTitle": "样例数据",
"home.tutorial.tabs.siemTitle": "SIEM",
Copy link
Contributor

@XavierM XavierM Jun 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not delete just rename the key and value to Security

"home.tutorial.unexpectedStatusCheckStateErrorDescription": "意外的状态检查状态 {statusCheckState}",
"home.tutorial.unhandledInstructionTypeErrorDescription": "未处理的指令类型 {visibleInstructions}",
"home.tutorials.activemqLogs.artifacts.dashboards.linkLabel": "ActiveMQ 应用程序事件",