Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Update links for add-data button #68240

Merged
merged 6 commits into from
Jun 4, 2020
Merged

[SIEM] Update links for add-data button #68240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
365a2c5
update links for add-data button
angorayc Jun 4, 2020
73b7299
update links
angorayc Jun 4, 2020
28555ce
rename SIEM with security
angorayc Jun 4, 2020
bd4af43
add back missing key
angorayc Jun 4, 2020
921c6f9
fixup
angorayc Jun 4, 2020
94af1db
fixup
angorayc Jun 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/plugins/home/public/application/components/__snapshots__/add_data.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions src/plugins/home/public/application/components/add_data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ const AddDataUi = ({ apmUiEnabled, isNewKibanaInstance, intl, mlEnabled }) => {
};
const siemData = {
title: intl.formatMessage({
id: 'home.addData.siem.nameTitle',
defaultMessage: 'SIEM',
id: 'home.addData.securitySolution.nameTitle',
defaultMessage: 'Security',
}),
description: intl.formatMessage({
id: 'home.addData.siem.nameDescription',
id: 'home.addData.securitySolution.nameDescription',
defaultMessage:
'Centralize security events for interactive investigation in ready-to-go visualizations.',
}),
Expand Down Expand Up @@ -221,11 +221,11 @@ const AddDataUi = ({ apmUiEnabled, isNewKibanaInstance, intl, mlEnabled }) => {
footer={
<EuiButton
className="homAddData__button"
href="#/tutorial_directory/siem"
href="#/tutorial_directory/security"
aria-describedby={siemData.ariaDescribedby}
>
<FormattedMessage
id="home.addData.siem.addSiemEventsButtonLabel"
id="home.addData.securitySolution.addSecurityEventsButtonLabel"
defaultMessage="Add events"
/>
</EuiButton>
Expand Down
6 changes: 3 additions & 3 deletions src/plugins/home/public/application/components/tutorial_directory.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ class TutorialDirectoryUi extends React.Component {
}),
},
{
id: 'siem',
id: 'security',
name: this.props.intl.formatMessage({
id: 'home.tutorial.tabs.siemTitle',
defaultMessage: 'SIEM',
id: 'home.tutorial.tabs.securitySolutionTitle',
defaultMessage: 'Security',
}),
},
{
Expand Down
1 change: 1 addition & 0 deletions x-pack/plugins/security_solution/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export const APP_ID = 'securitySolution';
export const APP_NAME = 'Security';
export const APP_ICON = 'securityAnalyticsApp';
export const APP_PATH = `/app/security`;
export const ADD_DATA_PATH = `/app/home#/tutorial_directory/security`;
export const DEFAULT_BYTES_FORMAT = 'format:bytes:defaultPattern';
export const DEFAULT_DATE_FORMAT = 'dateFormat';
export const DEFAULT_DATE_FORMAT_TZ = 'dateFormat:tz';
Expand Down
3 changes: 2 additions & 1 deletion ...ns/security_solution/public/alerts/pages/detection_engine/detection_engine_empty_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ import React from 'react';
import { useKibana } from '../../../common/lib/kibana';
import { EmptyPage } from '../../../common/components/empty_page';
import * as i18n from '../../../common/translations';
import { ADD_DATA_PATH } from '../../../../common/constants';

export const DetectionEngineEmptyPage = React.memo(() => (
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${useKibana().services.http.basePath.get()}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${useKibana().services.http.basePath.get()}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/security_solution/public/common/components/header_global/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import { MlPopover } from '../ml_popover/ml_popover';
import { SiemNavigation } from '../navigation';
import * as i18n from './translations';
import { indicesExistOrDataTemporarilyUnavailable, WithSource } from '../../containers/source';
import { ADD_DATA_PATH } from '../../../../common/constants';

const Wrapper = styled.header`
${({ theme }) => css`
Expand Down Expand Up @@ -86,7 +87,7 @@ export const HeaderGlobal = React.memo<HeaderGlobalProps>(({ hideDetectionEngine
<FlexItem grow={false}>
<EuiButtonEmpty
data-test-subj="add-data"
href="home#/tutorial_directory/siem"
href={ADD_DATA_PATH}
iconType="plusInCircle"
>
{i18n.BUTTON_ADD_DATA}
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/security_solution/public/hosts/pages/hosts_empty_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import React from 'react';
import { EmptyPage } from '../../common/components/empty_page';
import { useKibana } from '../../common/lib/kibana';
import * as i18n from '../../common/translations';
import { ADD_DATA_PATH } from '../../../common/constants';

export const HostsEmptyPage = React.memo(() => {
const { http, docLinks } = useKibana().services;
Expand All @@ -18,7 +19,7 @@ export const HostsEmptyPage = React.memo(() => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/security_solution/public/network/pages/network_empty_page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import React from 'react';
import { useKibana } from '../../common/lib/kibana';
import { EmptyPage } from '../../common/components/empty_page';
import * as i18n from '../../common/translations';
import { ADD_DATA_PATH } from '../../../common/constants';

export const NetworkEmptyPage = React.memo(() => {
const { http, docLinks } = useKibana().services;
Expand All @@ -18,7 +19,7 @@ export const NetworkEmptyPage = React.memo(() => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18n.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18n.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Expand Down
3 changes: 2 additions & 1 deletion x-pack/plugins/security_solution/public/overview/components/overview_empty/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import React from 'react';
import * as i18nCommon from '../../../common/translations';
import { EmptyPage } from '../../../common/components/empty_page';
import { useKibana } from '../../../common/lib/kibana';
import { ADD_DATA_PATH } from '../../../../common/constants';

const OverviewEmptyComponent: React.FC = () => {
const { http, docLinks } = useKibana().services;
Expand All @@ -18,7 +19,7 @@ const OverviewEmptyComponent: React.FC = () => {
<EmptyPage
actionPrimaryIcon="gear"
actionPrimaryLabel={i18nCommon.EMPTY_ACTION_PRIMARY}
actionPrimaryUrl={`${basePath}/app/home#/tutorial_directory/siem`}
actionPrimaryUrl={`${basePath}${ADD_DATA_PATH}`}
actionSecondaryIcon="popout"
actionSecondaryLabel={i18nCommon.EMPTY_ACTION_SECONDARY}
actionSecondaryTarget="_blank"
Expand Down
4 changes: 3 additions & 1 deletion x-pack/plugins/security_solution/public/overview/pages/summary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import React from 'react';
import { EuiFlexItem, EuiLink, EuiText } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';

import { ADD_DATA_PATH } from '../../../common/constants';

import { useKibana } from '../../common/lib/kibana';

export const Summary = React.memo(() => {
Expand Down Expand Up @@ -37,7 +39,7 @@ export const Summary = React.memo(() => {
</EuiLink>
),
data: (
<EuiLink href="kibana#home/tutorial_directory/siem">
<EuiLink href={ADD_DATA_PATH}>
<FormattedMessage
id="xpack.securitySolution.overview.startedText.dataLinkText"
defaultMessage="ingesting data"
Expand Down
Loading