Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution][Hosts] All hosts table OS column tooltip #123377

Merged

Conversation

semd
Copy link
Contributor

@semd semd commented Jan 19, 2022

Summary

issue: #122205

The Operating System fields (os.name, os.version, ...) fields can be multi-valuated once aggregated by host.name. Currently, we are displaying the most recent value.
A tooltip has been added to the Hosts table column header, to inform users that the OS data displayed is the most recent.

Os column tooltip

@semd semd added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Explore labels Jan 19, 2022
@semd semd requested a review from a team as a code owner January 19, 2022 15:43
@semd semd self-assigned this Jan 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@semd
Copy link
Contributor Author

semd commented Jan 20, 2022

@elasticmachine merge upstream

@monina-n
Copy link

hey @semd, overall the design of the tooltip and interaction itself is all good.

The only thing I want to doublecheck is the actual working of the message in the tooltip.

  • I would spell out OS as "Operating system"
  • I'm not sure if this phrase is grammatically correct. Something like "Last observed operating system" might be better phrasing.

I would ask for some feedback from the docs team about the message

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple solution, I like it. Please just fix the spelling as @monina-n requested and LGTM

@semd semd added the v8.1.0 label Jan 20, 2022
@semd
Copy link
Contributor Author

semd commented Jan 24, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 4.6MB 4.6MB +297.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

@semd semd merged commit e76cedb into elastic:main Jan 24, 2022
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.0 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0:
- [SECURITY] Rename siem plugin to security_solution (#67902)

How to fix

Re-run the backport manually:

node scripts/backport --pr 123377

Questions ?

Please refer to the Backport tool documentation

semd added a commit to semd/kibana that referenced this pull request Jan 24, 2022
Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e76cedb)

# Conflicts:
#	x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx
#	x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts
semd added a commit that referenced this pull request Jan 24, 2022
* tooltip added to OS column (#123377)

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit e76cedb)

# Conflicts:
#	x-pack/plugins/security_solution/public/hosts/components/hosts_table/columns.tsx
#	x-pack/plugins/security_solution/public/hosts/components/hosts_table/translations.ts

* remove not needed translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.0.0 v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants