-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [Detections] BLOCKERS Bugs #56333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
Fixes for quality problems that affect the customer experience
blocker
critical
Team:SIEM
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.0
v7.6.0
labels
Jan 29, 2020
Pinging @elastic/siem (Team:SIEM) |
fix duplicates rules allow no filter on detail rule
XavierM
force-pushed
the
detections-fix-edit-url
branch
from
January 29, 2020 19:45
2a56f9b
to
68a817d
Compare
10 tasks
dhurley14
approved these changes
Jan 29, 2020
patrykkopycinski
approved these changes
Jan 29, 2020
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/advanced_job·ts.machine learning anomaly detection advanced job with categorization detector and default datafeed settings job creation displays details for the created job in the job listStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
spong
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While already merged, I did want to comment on what I had tested locally:
- Checked out and performed a
./hard_reset.sh
(to remove all pre-packaged rules + signal index) - Installed pre-packaged rules via UI
- Ran
./post_rule.sh rules/test_cases/queries/query_with_errors.json
to create a rule that would fail and populatelast_failure_at
andlast_failure_message
- Successfully duplicated failed rule with
last_failure_
fields
- Successfully duplicated failed rule with
- Duplicated all pre-packaged rules
- Exported duplicated pre-packaged rules (112 rules)
- Imported duplicated pre-packaged rules (both with overwrite=true and overwrite=false)
- Request timed out, but import was successful. Non-blocker that @XavierM is addressing
- Verified edit rule with and w/o filter functioned
- Verified edit rule redirect was successful and no app crash
- Verified create rule flow using all fields
- Verified bulk activate/deactivate on a mix of pre-packaged, custom, and success/failed rules
Thanks for the quick fixes here @XavierM -- LGTM 👍
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 30, 2020
fix duplicates rules allow no filter on detail rule
XavierM
added a commit
that referenced
this pull request
Jan 30, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 31, 2020
…56356 * '7.x' of github.com:elastic/kibana: (23 commits) Fix setting filters without $store value (elastic#56304) (elastic#56475) [ML] Fix Data Visualizer responsive layout (elastic#56372) (elastic#56472) [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471) [APM] Fit service map to container (elastic#56336) (elastic#56463) Add animation to service map layout (elastic#56042) (elastic#56460) chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422) [APM] Storybook support (elastic#54970) (elastic#56445) [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454) [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320) [DOCS] Adds breaking changes for 7.6 (elastic#56437) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421) [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436) [7.x] System index templates can't be edited (elastic#55229) (elastic#56417) Add missing docker settings (elastic#56411) [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386) fix edit rule for detections (elastic#56333) (elastic#56405) [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385) [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757) Move tsvb server to new platform (elastic#55310) (elastic#56394) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers