Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix Check for New Data button on empty indices screen #56239

Merged
merged 1 commit into from
Jan 29, 2020
Merged

[Logs UI] Fix Check for New Data button on empty indices screen #56239

merged 1 commit into from
Jan 29, 2020

Conversation

Zacqary
Copy link
Contributor

@Zacqary Zacqary commented Jan 28, 2020

Summary

Fixes #56036

Clicking Check for New Data on a logs stream with empty indices will now request new data instead of doing a no-op.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@Zacqary Zacqary added bug Fixes for quality problems that affect the customer experience v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 28, 2020
@Zacqary Zacqary requested a review from a team January 28, 2020 21:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@simianhacker simianhacker self-requested a review January 28, 2020 22:26
simianhacker
simianhacker approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I loaded some Filebeat data, delete the events, and then clicked "check for new data". The browser sent an XHR each time I clicked, I assume that's the correct behavior.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Zacqary Zacqary merged commit 759663c into elastic:master Jan 29, 2020
@Zacqary Zacqary deleted the 56036-check-new-data-fix branch January 29, 2020 17:27
This was referenced Jan 29, 2020
Merged
Merged
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jan 29, 2020
@Zacqary
[Logs UI] Fix Check for New Data button on empty indices screen (elas…
e5a7ce6 
…tic#56239)
Zacqary added a commit to Zacqary/kibana that referenced this pull request Jan 29, 2020
@Zacqary
[Logs UI] Fix Check for New Data button on empty indices screen (elas…
0d2806b 
…tic#56239)
Zacqary added a commit that referenced this pull request Jan 30, 2020
@Zacqary
[Logs UI] Fix Check for New Data button on empty indices screen (#56239…
3136463 
…) (#56321)
Zacqary added a commit that referenced this pull request Jan 30, 2020
@Zacqary @elasticmachine
[Logs UI] Fix Check for New Data button on empty indices screen (#56239…
caac198 
…) (#56320)

Co-authored-by: Elastic Machine <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 31, 2020
@jloleysens
Merge branch '7.x' of github.com:elastic/kibana into backport/7.x/pr-…
f8afb1b 
…56356

* '7.x' of github.com:elastic/kibana: (23 commits)
  Fix setting filters without $store value (elastic#56304) (elastic#56475)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372) (elastic#56472)
  [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471)
  [APM] Fit service map to container (elastic#56336) (elastic#56463)
  Add animation to service map layout (elastic#56042) (elastic#56460)
  chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422)
  [APM] Storybook support (elastic#54970) (elastic#56445)
  [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454)
  [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320)
  [DOCS] Adds breaking changes for 7.6 (elastic#56437)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436)
  [7.x] System index templates can't be edited (elastic#55229) (elastic#56417)
  Add missing docker settings (elastic#56411)
  [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386)
  fix edit rule for detections (elastic#56333) (elastic#56405)
  [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385)
  [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757)
  Move tsvb server to new platform (elastic#55310) (elastic#56394)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] "Check for new data" button on empty indices screen not working
4 participants
@Zacqary @elasticmachine @kibanamachine @simianhacker