Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kuery_autocomplete -> convert remaining items to TS/Jest #56316

Merged
merged 5 commits into from
Jan 31, 2020

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 29, 2020

Closes #55487

Summary

What was done it that PR:

  • kql_query_suggestion/escape_kuery to TS + tests to jest
  • kql_query_suggestion/field to TS + tests to jest
  • kql_query_suggestion/index to TS
  • kql_query_suggestion/operator to TS + tests to jest
  • kql_query_suggestion/value to TS
  • remove any remaining @ts-ignores

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elastic elastic deleted a comment from kibanamachine Jan 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp self-assigned this Jan 30, 2020
@alexwizp alexwizp marked this pull request as ready for review January 30, 2020 13:15
@alexwizp alexwizp requested a review from a team as a code owner January 30, 2020 13:15
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukeelmers lukeelmers self-requested a review January 30, 2020 16:59
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a close look at the code and everything looks great to me! 🚀

@alexwizp alexwizp merged commit 08f4b55 into elastic:master Jan 31, 2020
alexwizp added a commit to alexwizp/kibana that referenced this pull request Jan 31, 2020
* kuery_autocomplete -> convert remaining items to TS/Jest

Closes elastic#55487

* QuerySuggestionsTypes rename values

* remove ref to npStart

* conjunction.test.ts it -> test

* remove ts-ignore
alexwizp added a commit that referenced this pull request Jan 31, 2020
…6471)

* kuery_autocomplete -> convert remaining items to TS/Jest

Closes #55487

* QuerySuggestionsTypes rename values

* remove ref to npStart

* conjunction.test.ts it -> test

* remove ts-ignore
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 31, 2020
* master: (53 commits)
  Fix setting filters without $store value (elastic#56304)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316)
  [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935)
  [reporting] remove a legacy cross-plugin import (elastic#56354)
  [DOCS] Updates example in Timelion doc (elastic#56444)
  [APM] Service map center button (elastic#56434)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372)
  Add missing docker settings (elastic#56411)
  [Endpoint] Add Endpoint Details route (elastic#55746)
  chore(NA): delete data/optimize with kbn clean (elastic#55890)
  System index templates can't be edited (elastic#55229)
  Sync badge (elastic#55113)
  Only fire appState changes when there is a change (elastic#56183)
  Import appropriate files to setup plugin system at the correct time (elastic#55956)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215)
  [ML] conditional rison encoding for query params (elastic#56380)
  Move tsvb server to new platform (elastic#55310)
  exclude tutorial resources from code ownership (elastic#55987)
  [Watcher] Follow up on flaky functional test (elastic#56384)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 31, 2020
…56356

* '7.x' of github.com:elastic/kibana: (23 commits)
  Fix setting filters without $store value (elastic#56304) (elastic#56475)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372) (elastic#56472)
  [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471)
  [APM] Fit service map to container (elastic#56336) (elastic#56463)
  Add animation to service map layout (elastic#56042) (elastic#56460)
  chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422)
  [APM] Storybook support (elastic#54970) (elastic#56445)
  [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454)
  [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320)
  [DOCS] Adds breaking changes for 7.6 (elastic#56437)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436)
  [7.x] System index templates can't be edited (elastic#55229) (elastic#56417)
  Add missing docker settings (elastic#56411)
  [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386)
  fix edit rule for detections (elastic#56333) (elastic#56405)
  [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385)
  [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757)
  Move tsvb server to new platform (elastic#55310) (elastic#56394)
  ...
jfsiii pushed a commit to jfsiii/kibana that referenced this pull request Feb 4, 2020
* kuery_autocomplete -> convert remaining items to TS/Jest

Closes elastic#55487

* QuerySuggestionsTypes rename values

* remove ref to npStart

* conjunction.test.ts it -> test

* remove ts-ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kuery_autocomplete -> convert remaining items to TS/Jest
4 participants