-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CANVAS] Import appropriate files to setup plugin system at the correct time #55956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crob611
added
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
loe:small
Small Level of Effort
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
v7.6.0
labels
Jan 25, 2020
Pinging @elastic/kibana-canvas (Team:Canvas) |
crob611
changed the title
Import appropriate files to setup plugin system at the correct time
[CANVAS] Import appropriate files to setup plugin system at the correct time
Jan 25, 2020
poffdeluxe
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have the "TODO" item tracked anywhere for our NP conversion work?
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 30, 2020
…lastic#55956) Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Jan 30, 2020
…lastic#55956) Co-authored-by: Elastic Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 31, 2020
* master: (53 commits) Fix setting filters without $store value (elastic#56304) kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935) [reporting] remove a legacy cross-plugin import (elastic#56354) [DOCS] Updates example in Timelion doc (elastic#56444) [APM] Service map center button (elastic#56434) [skip-ci] Add example for migrating pre-handlers (elastic#56080) [ML] Fix Data Visualizer responsive layout (elastic#56372) Add missing docker settings (elastic#56411) [Endpoint] Add Endpoint Details route (elastic#55746) chore(NA): delete data/optimize with kbn clean (elastic#55890) System index templates can't be edited (elastic#55229) Sync badge (elastic#55113) Only fire appState changes when there is a change (elastic#56183) Import appropriate files to setup plugin system at the correct time (elastic#55956) [Monitoring] Change all configs to `monitoring.*` (elastic#56215) [ML] conditional rison encoding for query params (elastic#56380) Move tsvb server to new platform (elastic#55310) exclude tutorial resources from code ownership (elastic#55987) [Watcher] Follow up on flaky functional test (elastic#56384) ...
crob611
pushed a commit
that referenced
this pull request
Jan 31, 2020
…55956) (#56401) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
crob611
pushed a commit
that referenced
this pull request
Jan 31, 2020
…55956) (#56402) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:critical
This issue should be addressed immediately due to a critical level of impact on the product.
loe:small
Small Level of Effort
release_note:skip
Skip the PR/issue when compiling release notes
review
Team:Presentation
Presentation Team for Dashboard, Input Controls, and Canvas
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR just adds the imports necessary to initialize what's needed for the 3rd party plugin system to work.
Fixes #55904