[Logs UI] Fix Check for New Data button on empty indices screen (#56239…

…) (#56321)
elastic · Jan 30, 2020 · 3136463 · 3136463
1 parent 0314efc
commit 3136463
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/...ugins/infra/public/components/logging/log_text_stream/scrollable_log_text_stream_view.tsx b/...ugins/infra/public/components/logging/log_text_stream/scrollable_log_text_stream_view.tsx
@@ -51,6 +51,7 @@ interface ScrollableLogTextStreamViewProps {
     fromScroll: boolean;
   }) => any;
   loadNewerItems: () => void;
+  reloadItems: () => void;
   setFlyoutItem: (id: string) => void;
   setFlyoutVisibility: (visible: boolean) => void;
   highlightedItem: string | null;
@@ -269,10 +270,10 @@ export class ScrollableLogTextStreamView extends React.PureComponent<
   };
 
   private handleReload = () => {
-    const { jumpToTarget, target } = this.props;
+    const { reloadItems } = this.props;
 
-    if (target) {
-      jumpToTarget(target);
+    if (reloadItems) {
+      reloadItems();
     }
   };
 

diff --git a/x-pack/legacy/plugins/infra/public/containers/logs/log_entries/index.ts b/x-pack/legacy/plugins/infra/public/containers/logs/log_entries/index.ts
@@ -67,6 +67,7 @@ export type LogEntriesStateParams = {
 
 export interface LogEntriesCallbacks {
   fetchNewerEntries: () => Promise<TimeKey | null | undefined>;
+  checkForNewEntries: () => Promise<void>;
 }
 export const logEntriesInitialCallbacks = {
   fetchNewerEntries: async () => {},
@@ -231,16 +232,16 @@ const useFetchEntriesEffect = (
   useEffect(fetchMoreEntriesEffect, fetchMoreEntriesEffectDependencies);
   useEffect(streamEntriesEffect, streamEntriesEffectDependencies);
 
-  return { fetchNewerEntries };
+  return { fetchNewerEntries, checkForNewEntries: runFetchNewEntriesRequest };
 };
 
 export const useLogEntriesState: (
   props: LogEntriesProps
 ) => [LogEntriesStateParams, LogEntriesCallbacks] = props => {
   const [state, dispatch] = useReducer(logEntriesStateReducer, logEntriesInitialState);
 
-  const { fetchNewerEntries } = useFetchEntriesEffect(state, dispatch, props);
-  const callbacks = { fetchNewerEntries };
+  const { fetchNewerEntries, checkForNewEntries } = useFetchEntriesEffect(state, dispatch, props);
+  const callbacks = { fetchNewerEntries, checkForNewEntries };
 
   return [state, callbacks];
 };

diff --git a/x-pack/legacy/plugins/infra/public/pages/logs/stream/page_logs_content.tsx b/x-pack/legacy/plugins/infra/public/pages/logs/stream/page_logs_content.tsx
@@ -82,6 +82,7 @@ export const LogsPageLogsContent: React.FunctionComponent = () => {
             items,
             lastLoadedTime,
             fetchNewerEntries,
+            checkForNewEntries,
           }) => (
             <ScrollableLogTextStreamView
               columnConfigurations={(source && source.configuration.logColumns) || []}
@@ -94,6 +95,7 @@ export const LogsPageLogsContent: React.FunctionComponent = () => {
               jumpToTarget={jumpToTargetPosition}
               lastLoadedTime={lastLoadedTime}
               loadNewerItems={fetchNewerEntries}
+              reloadItems={checkForNewEntries}
               reportVisibleInterval={reportVisiblePositions}
               scale={textScale}
               target={targetPosition}