fix edit rule for detections (elastic#56333)

fix duplicates rules allow no filter on detail rule
XavierM · Jan 30, 2020 · c6ff9fb · c6ff9fb
1 parent 1d315e8
commit c6ff9fb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/x-pack/legacy/plugins/siem/public/components/link_to/redirect_to_detection_engine.tsx b/x-pack/legacy/plugins/siem/public/components/link_to/redirect_to_detection_engine.tsx
@@ -57,9 +57,7 @@ export const RedirectToEditRulePage = ({
   location: { search },
 }: DetectionEngineComponentProps) => {
   return (
-    <RedirectWrapper
-      to={`/${DETECTION_ENGINE_PAGE_NAME}/rules/rule-details/${detailName}${search}/edit`}
-    />
+    <RedirectWrapper to={`/${DETECTION_ENGINE_PAGE_NAME}/rules/id/${detailName}/edit${search}`} />
   );
 };
 

diff --git a/x-pack/legacy/plugins/siem/public/containers/detection_engine/rules/api.ts b/x-pack/legacy/plugins/siem/public/containers/detection_engine/rules/api.ts
@@ -217,6 +217,8 @@ export const duplicateRules = async ({ rules }: DuplicateRulesProps): Promise<Ru
           immutable: undefined,
           last_success_at: undefined,
           last_success_message: undefined,
+          last_failure_at: undefined,
+          last_failure_message: undefined,
           status: undefined,
           status_date: undefined,
         }))

diff --git a/...cy/plugins/siem/public/pages/detection_engine/rules/components/description_step/index.tsx b/...cy/plugins/siem/public/pages/detection_engine/rules/components/description_step/index.tsx
@@ -115,7 +115,7 @@ const getDescriptionItem = (
   indexPatterns?: IIndexPattern
 ): ListItems[] => {
   if (field === 'queryBar') {
-    const filters = addFilterStateIfNotThere(get('queryBar.filters', value));
+    const filters = addFilterStateIfNotThere(get('queryBar.filters', value) ?? []);
     const query = get('queryBar.query', value) as Query;
     const savedId = get('queryBar.saved_id', value);
     return buildQueryBarDescription({