Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix edit rule for detections #56337

Merged
merged 1 commit into from
Jan 29, 2020
Merged

fix edit rule for detections #56337

merged 1 commit into from
Jan 29, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jan 29, 2020 •
edited
Loading

Summary

  • Fix edit rule link
  • Duplicate rule
  • Open rule detail without filter

#56333

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM
fix edit rule for detections
43a8f7a 
fix duplicates rules

allow no filter on detail rule
@XavierM XavierM added bug Fixes for quality problems that affect the customer experience blocker backport critical Team:SIEM release_note:skip Skip the PR/issue when compiling release notes impact:critical This issue should be addressed immediately due to a critical level of impact on the product. v7.6.0 labels Jan 29, 2020
@XavierM XavierM self-assigned this Jan 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

dhurley14
dhurley14 approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

FrankHassanabad
FrankHassanabad approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XavierM XavierM merged commit 7da3097 into elastic:7.6 Jan 29, 2020
@XavierM XavierM deleted the detections-blocker-7.6 branch June 4, 2020 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@XavierM XavierM

Labels
backport blocker bug Fixes for quality problems that affect the customer experience critical impact:critical This issue should be addressed immediately due to a critical level of impact on the product. release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @elasticmachine @kibanamachine @dhurley14 @FrankHassanabad