TSVB add markdown tests #30642

vitalics · 2019-02-11T13:51:59Z

Summary

add new tsvb markdown tests
Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-02-11T14:46:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-12T09:53:41Z

Pinging @elastic/kibana-app

test/functional/apps/visualize/_tsvb_markdown.js

test/functional/page_objects/visual_builder_page.js

test/functional/apps/visualize/_tsvb_markdown.js

test/functional/page_objects/visual_builder_page.js

vitalics · 2019-02-12T14:55:33Z

this tests related for #23418, #28168 and #30625

elasticmachine · 2019-02-13T17:06:47Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-02-14T09:49:30Z

I added several more comments. Branch is ~120 commits behind master, suggesting to merge latest master.

test/functional/apps/visualize/_tsvb_markdown.js

test/functional/page_objects/visual_builder_page.js

dmlemeshko

All good, but need to get rid of sleep: we are trying to remove existing ones, so lets not add new ones :)

dmlemeshko · 2019-02-18T13:24:01Z

test/functional/page_objects/visual_builder_page.js

@@ -59,6 +60,17 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
    async enterMarkdown(markdown) {
      const prevRenderingCount = await PageObjects.visualize.getVisualizationRenderingCount();
      const input = await find.byCssSelector('.tvbMarkdownEditor__editor textarea');
+      await this.clearMarkdown();
+      await input.type(markdown);
+      await PageObjects.common.sleep(500);


I don't think we need sleep here. waitForRenderingCount for checking condition is doing retry up to ~40 sec

dmlemeshko · 2019-02-18T13:25:38Z

test/functional/page_objects/visual_builder_page.js

    }

    async getMarkdownText() {
      const el = await find.byCssSelector('.tvbEditorVisualization');
+      await PageObjects.common.sleep(300);


Is there a way to replace it with any wait condition?

no, since getting element so fast and best option is use sleep with a timeout. Actual element text is

and current text for same element is

dmlemeshko · 2019-02-18T13:29:42Z

test/functional/page_objects/visual_builder_page.js

@@ -94,6 +164,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
      await PageObjects.header.waitUntilLoadingHasFinished();
    }

+


Redundant empty line

dmlemeshko · 2019-02-18T13:32:49Z

test/functional/page_objects/visual_builder_page.js

+        const value = await subVars[1].getVisibleText();
+        return { key, value, selector };
+      }));
+      log.debug(`markdown table variables is: ${variablesKeyValueSelectorMap}`);


markdown variables table is or markdown table variables are

elasticmachine · 2019-02-18T13:59:44Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-02-18T17:21:37Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-02-18T22:03:07Z

@vitalics you need to merge the latest master to your branch.

vitalics · 2019-02-20T08:31:05Z

retest

elasticmachine · 2019-02-20T09:12:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

vitalics · 2019-02-20T13:39:28Z

retest

elasticmachine · 2019-02-20T14:49:00Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

vitalics · 2019-02-21T08:35:27Z

retest

elasticmachine · 2019-02-21T09:15:39Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

sorenlouv · 2019-02-22T14:14:00Z

@vitalics No worries. Can you remove the teams you don't need feedback from?

vitalics · 2019-02-22T14:16:38Z

Unfourchantly I can't. Could you please remove canvas, ml-ui, security, design and apm-ui teams from reviewers

elasticmachine · 2019-02-22T14:33:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

This deprecates our own implementation of `stateFactory()`. This utility was able to manage shared state across angular and react code including persisting it to the URL using `AppState`. This PR replaces it with a simpler way using RxJs' Observables.

* [Logs UI] Add link-to router for logs (without a node) * Fixing snapshots * Update x-pack/plugins/infra/public/pages/link_to/redirect_to_logs.tsx Co-Authored-By: simianhacker <[email protected]>

* test: assets and structures routes * chore: unify the workpad update handler the 3 functions were pretty much the same already

* Update embeddables metadata to support multiple index patterns * ts lint errors * another try at ts lint errors * fix dashboard_state tests * use lodash compact to remove undefined * revert _.compact to make TS linter happy * rename simulateNewEmbeddableWithIndexPattern => simulateNewEmbeddableWithIndexPatterns

Currently, if the Cloud plugin is disabled the server will fail to start Fixes #31612 Signed-off-by: Tyler Smalley <[email protected]>

… hasJobs (#31830)

Fixes time_filter state Removed console logs Cleaned up changes Removed unused prop in time_filter Moved propTypes Fixed bug with changing columns Added comment

…ed (#31816) * [Maps] fix app crash where details panel calls getId on undefined * add jest test ensuring no errors when selectedLayer is undefined

…31799) * [APM] Avoid crashing transaction details page if trace duration is 0 * Remove snapshot

* [UA] Support previously re-indexed ML/Watcher indices Previously we were comparing the start of the indices to determine if ML/Watcher should be stopped before re-indexing. Since we are now pre-pending the index name we should compare the index names without the re-indexed portion. Signed-off-by: Tyler Smalley <[email protected]>

errno is not set for ECONNRESET https://github.com/hapijs/wreck/blob/29d8f4b5eaa12c5d44c642130cd6002c1d83ffd2/lib/index.js#L290 Closes #22225 Example: { Error: socket hang up at TLSSocket.onSocketClose (_tls_wrap.js:761:23) at TLSSocket.emit (events.js:194:15) at _handle.close (net.js:600:12) at Socket.done (_tls_wrap.js:388:7) at Object.onceWrapper (events.js:277:13) at Socket.emit (events.js:189:13) at TCP._handle.close (net.js:600:12) code: 'ECONNRESET' Signed-off-by: Tyler Smalley <[email protected]>

…ups. (#31869) * Remove duplicate license header.

add test for table checking

fix flacky for markdown table variables

elasticmachine · 2019-02-25T07:31:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

vitalics · 2019-02-25T12:13:18Z

reopened #31893

vitalics requested review from timroes and dmlemeshko February 11, 2019 13:52

dmlemeshko added the test_ui_functional label Feb 12, 2019

vitalics mentioned this pull request Feb 12, 2019

TSVB Visual Builder test automation meta issue #29724

Closed

2 tasks

vitalics requested a review from LeeDr February 12, 2019 09:53

vitalics added Feature:TSVB TSVB (Time Series Visual Builder) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 12, 2019

dmlemeshko requested review from LeeDr and removed request for LeeDr February 12, 2019 11:09

dmlemeshko reviewed Feb 12, 2019

View reviewed changes

alexwizp mentioned this pull request Feb 13, 2019

Missing variables preview in TSVB markdown #30830

Merged

7 tasks

dmlemeshko reviewed Feb 14, 2019

View reviewed changes

vitalics force-pushed the tsvb_markdown branch from 3a013b6 to 7bd6a29 Compare February 18, 2019 13:15

dmlemeshko requested changes Feb 18, 2019

View reviewed changes

vitalics requested review from a team as code owners February 22, 2019 12:24

walterra and others added 23 commits February 22, 2019 15:35

[Logs UI] Add link-to router for logs (without a node) (#31653)

79a7fdf

* [Logs UI] Add link-to router for logs (without a node) * Fixing snapshots * Update x-pack/plugins/infra/public/pages/link_to/redirect_to_logs.tsx Co-Authored-By: simianhacker <[email protected]>

Add RFC README and template (#31650)

bae87b0

chore: unify the workpad update handler (#31218)

101d30a

* test: assets and structures routes * chore: unify the workpad update handler the 3 functions were pretty much the same already

[UA] Protects against Cloud plugin being disabled (#31637)

fc55ca5

Currently, if the Cloud plugin is disabled the server will fail to start Fixes #31612 Signed-off-by: Tyler Smalley <[email protected]>

Add new platform code to dev watcher (#31622)

d3dd071

Fix Rollup Job List test, which broke due to change from jobs prop to…

748df35

… hasJobs (#31830)

Refactor time_filter (#31641)

0982c4e

Fixes time_filter state Removed console logs Cleaned up changes Removed unused prop in time_filter Moved propTypes Fixed bug with changing columns Added comment

[Maps] fix app crash where layer details panel calls getId on undefin…

1ecfff1

…ed (#31816) * [Maps] fix app crash where details panel calls getId on undefined * add jest test ensuring no errors when selectedLayer is undefined

[APM] Avoid crashing transaction details page if trace duration is 0 (#…

61c2754

…31799) * [APM] Avoid crashing transaction details page if trace duration is 0 * Remove snapshot

fix: hours label container size (#31838)

c6ea4dc

Fix spacing error in license header in CCR, Remote Clusters, and Roll…

c5023a1

…ups. (#31869) * Remove duplicate license header.

reorganize tsvb markdown test

9e6a412

add test for table checking

add new tests for markdown

97e6b18

fix PR review issues

62629f8

remove unused services

f8c1359

fix flacky for markdown table variables

fix flaky tests

8f0493a

remove markdown tests from _tsvb_chart file

d1c4d2b

skip first table test for ci check

91e6f86

rebase

5f12d9d

vitalics closed this Feb 25, 2019

vitalics deleted the tsvb_markdown branch February 25, 2019 12:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TSVB add markdown tests #30642

TSVB add markdown tests #30642

vitalics commented Feb 11, 2019

elasticmachine commented Feb 11, 2019

elasticmachine commented Feb 12, 2019

vitalics commented Feb 12, 2019

elasticmachine commented Feb 13, 2019

dmlemeshko commented Feb 14, 2019

dmlemeshko left a comment

dmlemeshko Feb 18, 2019

dmlemeshko Feb 18, 2019

vitalics Feb 18, 2019

dmlemeshko Feb 18, 2019

dmlemeshko Feb 18, 2019

elasticmachine commented Feb 18, 2019

elasticmachine commented Feb 18, 2019

dmlemeshko commented Feb 18, 2019

vitalics commented Feb 20, 2019

elasticmachine commented Feb 20, 2019

vitalics commented Feb 20, 2019

elasticmachine commented Feb 20, 2019

vitalics commented Feb 21, 2019

elasticmachine commented Feb 21, 2019

sorenlouv commented Feb 22, 2019

vitalics commented Feb 22, 2019 •

edited

Loading

elasticmachine commented Feb 22, 2019

elasticmachine commented Feb 25, 2019

vitalics commented Feb 25, 2019

		@@ -94,6 +164,7 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }) {
		await PageObjects.header.waitUntilLoadingHasFinished();
		}

TSVB add markdown tests #30642

TSVB add markdown tests #30642

Conversation

vitalics commented Feb 11, 2019

Summary

Checklist

For maintainers

elasticmachine commented Feb 11, 2019

💚 Build Succeeded

elasticmachine commented Feb 12, 2019

vitalics commented Feb 12, 2019

elasticmachine commented Feb 13, 2019

💚 Build Succeeded

dmlemeshko commented Feb 14, 2019

dmlemeshko left a comment

Choose a reason for hiding this comment

dmlemeshko Feb 18, 2019

Choose a reason for hiding this comment

dmlemeshko Feb 18, 2019

Choose a reason for hiding this comment

vitalics Feb 18, 2019

Choose a reason for hiding this comment

dmlemeshko Feb 18, 2019

Choose a reason for hiding this comment

dmlemeshko Feb 18, 2019

Choose a reason for hiding this comment

elasticmachine commented Feb 18, 2019

💔 Build Failed

elasticmachine commented Feb 18, 2019

💔 Build Failed

dmlemeshko commented Feb 18, 2019

vitalics commented Feb 20, 2019

elasticmachine commented Feb 20, 2019

💔 Build Failed

vitalics commented Feb 20, 2019

elasticmachine commented Feb 20, 2019

💔 Build Failed

vitalics commented Feb 21, 2019

elasticmachine commented Feb 21, 2019

💔 Build Failed

sorenlouv commented Feb 22, 2019

vitalics commented Feb 22, 2019 • edited Loading

elasticmachine commented Feb 22, 2019

💔 Build Failed

elasticmachine commented Feb 25, 2019

💔 Build Failed

vitalics commented Feb 25, 2019

vitalics commented Feb 22, 2019 •

edited

Loading