Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new platform code to dev watcher #31622

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add new platform code to dev watcher #31622

merged 1 commit into from
Feb 22, 2019

Conversation

joshdover
Copy link
Contributor

Summary

This adds the new platform code to the paths for --dev watch mode. This will enable restarting the server or re-optimizing frontend bundles when the source changes.

@joshdover joshdover added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v8.0.0 v7.2.0 labels Feb 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

mistic
mistic approved these changes Feb 20, 2019
View reviewed changes
Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@epixa
Copy link
Contributor

epixa commented Feb 21, 2019

Wait, what? This doesn't work today?

@joshdover
Copy link
Contributor Author

@epixa Changes to public do trigger an optimizer rebuild, but changes to server do not trigger a server restart when they should.

@joshdover
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@joshdover
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@joshdover joshdover merged commit d3dd071 into elastic:master Feb 22, 2019
@joshdover joshdover deleted the watch-np-server branch February 22, 2019 19:11
@joshdover joshdover mentioned this pull request Feb 22, 2019
Merged
joshdover added a commit to joshdover/kibana that referenced this pull request Feb 22, 2019
@joshdover
Add new platform code to dev watcher (elastic#31622)
4e13dc4
joshdover added a commit that referenced this pull request Feb 22, 2019
@joshdover
Add new platform code to dev watcher (#31622) (#31829)
93872f2
@joshdover joshdover added the non-issue Indicates to automation that a pull request should not appear in the release notes label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistic mistic mistic approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.2.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joshdover @elasticmachine @epixa @tylersmalley @mistic