[TSVB]: initial markdown test implementation #31893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalics
changed the title
💚 Build Succeeded |
💔 Build Failed |
dmlemeshko
reviewed
Feb 26, 2019
|
Flakiness is caused by the way visualisation loading handled here. Check my commit 738afe0388b5131f637a18da0469c2b6a1d894c1 |
💔 Build Failed |
w33ble
reviewed
Feb 26, 2019
| @@ -22,7 +22,6 @@ export const advancedFilter = () => ({ | |||
| ); | |||
|
|
|||
| handlers.onDestroy(() => { | |||
| handlers.setFilter(''); | |||
There was a problem hiding this comment.
Is this the result of a bad rebase/merge? I think all the Canvas changes you have here are in master already.
There was a problem hiding this comment.
yeah, it's result of a bad rebase/merge
vitalics
force-pushed
the
tsvb-markdown-tests
branch
from
176500b to
be9146c
Compare
💔 Build Failed |
vitalics
force-pushed
the
tsvb-markdown-tests
branch
from
be9146c to
80d8ace
Compare
💔 Build Failed |
💔 Build Failed |
vitalics
force-pushed
the
tsvb-markdown-tests
branch
from
be4df47 to
4630026
Compare
💔 Build Failed |
💔 Build Failed |
vitalics
force-pushed
the
tsvb-markdown-tests
branch
from
adba49c to
493d8f7
Compare
💚 Build Succeeded |
dmlemeshko
requested changes
Mar 1, 2019
💚 Build Succeeded |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
vitalics
added
test
Team:QA
|
Pinging @elastic/kibana-qa |
|
Pinging @elastic/kibana-app |
💔 Build Failed |
remove redundant method
💔 Build Failed |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
vitalics
added a commit
to vitalics/kibana
that referenced
this pull request
Mar 5, 2019
* Improve test coverage for TSVB markdown
vitalics
added a commit
that referenced
this pull request
Mar 5, 2019
This was referenced Mar 5, 2019
vitalics
added a commit
to vitalics/kibana
that referenced
this pull request
Mar 7, 2019
vitalics
added a commit
that referenced
this pull request
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extanding test coverage for TSVB mardown
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately