[Maps] fix app crash where layer details panel calls getId on undefined #31816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
v7.0.0
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
nreese
commented
Feb 22, 2019
| removeTrackedLayerStateForSelectedLayer | ||
| } from '../../../actions/store_actions'; | ||
|
|
||
| const mapDispatchToProps = (dispatch) => { | ||
| return { | ||
| cancelLayerPanel: async () => { | ||
| await dispatch(updateFlyout(FLYOUT_STATE.NONE)); | ||
| await dispatch(rollbackToTrackedLayerStateForSelectedLayer()); |
There was a problem hiding this comment.
I removed the call to rollbackToTrackedLayerStateForSelectedLayer since it is already called as part of setSelectedLayer
thomasneirynck
approved these changes
Feb 22, 2019
💔 Build Failed |
|
flaky x-pack jest test plugins/rollup/public/crud_app/sections/job_list/job_list.test.js jenkins, test this |
💔 Build Failed |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2019
…ed (elastic#31816) * [Maps] fix app crash where details panel calls getId on undefined * add jest test ensuring no errors when selectedLayer is undefined
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2019
…ed (elastic#31816) * [Maps] fix app crash where details panel calls getId on undefined * add jest test ensuring no errors when selectedLayer is undefined
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Feb 22, 2019
…ed (elastic#31816) * [Maps] fix app crash where details panel calls getId on undefined * add jest test ensuring no errors when selectedLayer is undefined
nreese
added
non-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31744
LayerPanelassumesprops.selectedLayerwill always be provided. There is a race condition that sometimes results inprops.selectedLayerbeing undefined.The layer details flyout is open and closed with an animation. The race condition occurs when the flyout is closing and selectedLayer is set to null. Sometimes, selectedLayer is set to null before the closing animation completes and
props.selectedLayeris updated to null beforeLayerPanelis unmounted.This PR hardens
LayerPanelsoprops.selectedLayercan safely be set to undefined