chore: unify the workpad update handler #31218
Conversation
w33ble
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
|
|
💚 Build Succeeded |
the 3 functions were pretty much the same already
w33ble
force-pushed
the
chore/workpad-update-handler
branch
from
cd52ece to
3081d90
Compare
💚 Build Succeeded |
| import { workpad } from './workpad'; | ||
|
|
||
| const routePrefix = API_ROUTE_WORKPAD; | ||
| const routePrefixAssets = API_ROUTE_WORKPAD_ASSETS; | ||
| const routePrefixStructures = API_ROUTE_WORKPAD_STRUCTURES; |
There was a problem hiding this comment.
Are the routes kept separate because route unification is tangential to what this PR is needed for, or because you have second thoughts about its desirability? (not suggesting that unification be done in this one, just wishing to know esp. if it's the latter)
There was a problem hiding this comment.
because route unification is tangential to what this PR is needed for
That ;)
Having a single handler makes the changes I'm planning easier, the route unification is separate, and still seems worth doing. And now that there's tests, we can just update the api path in them and confirm they still work the same way.
* test: assets and structures routes * chore: unify the workpad update handler the 3 functions were pretty much the same already
* test: assets and structures routes * chore: unify the workpad update handler the 3 functions were pretty much the same already
I'm planning to fix the workpad persist order issue we've had for a while, and unifying the update handler is going to make that a lot easier. The 3 functions were pretty much the same already, so using the same
updateWorkpadhandler for all 3 routes was a pretty easy change.Related: #29930 (which is about unifying the routes, this PR only unifies the handler for all 3 routes)