Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rule Registry] Rewrite APM registry rules for Observability #117740

Merged
merged 15 commits into from
Dec 6, 2021
Merged

[Rule Registry] Rewrite APM registry rules for Observability #117740

merged 15 commits into from
Dec 6, 2021

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Nov 5, 2021 •
edited
Loading

Summary

This PR closes #110637 by rewriting APM's Registry Rules test and moving it to the Rule Registry tests.

Checklist

@simianhacker simianhacker added v8.0.0 Feature:Observability RAC v8.1.0 Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 5, 2021
@simianhacker simianhacker marked this pull request as ready for review November 10, 2021 16:45
@simianhacker simianhacker requested a review from a team as a code owner November 10, 2021 16:45
@dgieselaar
Copy link
Member

@simianhacker fwiw, this was already an API test?

@simianhacker simianhacker added release_note:fix release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Nov 10, 2021
@simianhacker
Copy link
Member Author

@dgieselaar Not sure what you mean? It was an API test under APM. From the description in the linked issue, @weltenwort wanted it moved to Observability.

@dgieselaar
Copy link
Member

@simianhacker this issue description says:

This PR closes #110637 by rewriting APM's Registry Rules test (originally written with Cypress) to use Kibana's API testing framework.

But APM's Registry Rules tests were already part of the Kibana API tests. They were not written with Cypress.

@simianhacker
Copy link
Member Author

@dgieselaar Sorry... I misunderstood, I thought the tests under apm_api_integration where running with Cypress. Updated description. I think they still wanted it moved but it looks like I should have put it under x-pack/test/rule_registry instead of x-pack/test/observability_api_integration.

@simianhacker simianhacker marked this pull request as draft November 10, 2021 17:38
@simianhacker simianhacker changed the title [Actionable Observability] Rewrite APM registry rules for Observability [Rule Registry] Rewrite APM registry rules for Observability Nov 10, 2021
@simianhacker simianhacker marked this pull request as ready for review November 10, 2021 22:57
@simianhacker
Copy link
Member Author

@dgieselaar I'm not sure if you want to "re-review" this. I moved all the tests under x-pack/test/rule_registry. I think when you reviewed it everything was under x-pack/test/observability_api_integration.

@simianhacker simianhacker requested review from dgieselaar and a team November 11, 2021 16:48
@elastic elastic deleted a comment from kibanamachine Nov 15, 2021
claudiopro
claudiopro reviewed Nov 29, 2021
View reviewed changes
x-pack/test/rule_registry/spaces_only/tests/trial/index.ts
@@ -22,8 +22,9 @@ export default ({ loadTestFile, getService }: FtrProviderContext): void => {
await deleteSpaces(getService);
});

// Basic
// Trial
Copy link
Contributor

@claudiopro claudiopro Nov 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was Basic the old marketing name? Nevermind, it seems you're fixing some copypasta.

@claudiopro
Copy link
Contributor

FYI the link to APM's Registry Rules test in the description is broken.

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 6, 2021
@simianhacker simianhacker merged commit 3c0c315 into elastic:main Dec 6, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 6, 2021
@simianhacker @kibanamachine
[Rule Registry] Rewrite APM registry rules for Observability (elastic…
3d418fa 
…#117740)

* [Actionable Observability] Rewrite APM registry rules for Observability

* removing apm's rule registry test

* Moving everything under observability_api_integration

* removing old observability directory under api_integrations since it's not being used

* removing observability from api_integration tests

* renaming file

* moving test to x-pack/test/rule_registry

* Adding error handing to cleanupTargetIndices

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Dec 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 7, 2021
@kibanamachine @simianhacker
[Rule Registry] Rewrite APM registry rules for Observability (#117740) (
99f26c9 
#120557)

* [Actionable Observability] Rewrite APM registry rules for Observability

* removing apm's rule registry test

* Moving everything under observability_api_integration

* removing old observability directory under api_integrations since it's not being used

* removing observability from api_integration tests

* renaming file

* moving test to x-pack/test/rule_registry

* Adding error handing to cleanupTargetIndices

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Chris Cowan <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 7, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/close…
364ffac 
…-chromium-before-compiling-pdf

* 'main' of github.com:elastic/kibana: (121 commits)
  FTR should use the new kibana_system user (elastic#120436)
  [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488)
  [Reporting] Fix slow CSV with large max size bytes (elastic#120365)
  [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations -  (elastic#120459)
  [Dashboard] Added KibanaThemeProvider.  (elastic#120122)
  add more rule_registry unit tests (elastic#120323)
  [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478)
  [Fleet] Simplified package policy create API, enriching default values (elastic#119739)
  mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324)
  [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455)
  [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437)
  [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147)
  [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411)
  Add support for threat.feed.name (elastic#120250)
  [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740)
  [docs] Fix artifact layout formatting (elastic#119386)
  [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764)
  add osquery notes for 7.16 (elastic#120407)
  chore(NA): splits types from code on @kbn/docs-utils (elastic#120533)
  [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@simianhacker @kibanamachine @TinLe
[Rule Registry] Rewrite APM registry rules for Observability (elastic…
bc2007f 
…#117740)

* [Actionable Observability] Rewrite APM registry rules for Observability

* removing apm's rule registry test

* Moving everything under observability_api_integration

* removing old observability directory under api_integrations since it's not being used

* removing observability from api_integration tests

* renaming file

* moving test to x-pack/test/rule_registry

* Adding error handing to cleanupTargetIndices

Co-authored-by: Kibana Machine <[email protected]>
@simianhacker simianhacker deleted the issue-110637-rewrite-apm-rule-registry-test branch April 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiopro claudiopro claudiopro approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Observability RAC release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RAC] [Observability] Move rule registry tests from APM to rule_registry
5 participants
@simianhacker @dgieselaar @claudiopro @kibana-ci @kibanamachine