Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTR should use the new kibana_system user #120436

Merged
merged 3 commits into from
Dec 7, 2021
Merged

FTR should use the new kibana_system user #120436

merged 3 commits into from
Dec 7, 2021

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Dec 4, 2021 •
edited
Loading

Summary

This avoids creating deprecation logs during our tests
Related #120043

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Dec 4, 2021
@rudolf rudolf marked this pull request as ready for review December 6, 2021 22:22
@rudolf rudolf requested review from a team as code owners December 6, 2021 22:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@rudolf
Copy link
Contributor Author

rudolf commented Dec 7, 2021

@elasticmachine merge upstream

@rudolf rudolf added v8.0.0 v8.1.0 release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v7.16.1 and removed v7.16.0 labels Dec 7, 2021
@rudolf rudolf enabled auto-merge (squash) December 7, 2021 09:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit 48d1846 into elastic:main Dec 7, 2021
jloleysens added a commit to jloleysens/kibana that referenced this pull request Dec 7, 2021
@jloleysens
Merge branch 'main' of github.com:elastic/kibana into reporting/close…
364ffac 
…-chromium-before-compiling-pdf

* 'main' of github.com:elastic/kibana: (121 commits)
  FTR should use the new kibana_system user (elastic#120436)
  [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488)
  [Reporting] Fix slow CSV with large max size bytes (elastic#120365)
  [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations -  (elastic#120459)
  [Dashboard] Added KibanaThemeProvider.  (elastic#120122)
  add more rule_registry unit tests (elastic#120323)
  [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478)
  [Fleet] Simplified package policy create API, enriching default values (elastic#119739)
  mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324)
  [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455)
  [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437)
  [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147)
  [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411)
  Add support for threat.feed.name (elastic#120250)
  [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740)
  [docs] Fix artifact layout formatting (elastic#119386)
  [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764)
  add osquery notes for 7.16 (elastic#120407)
  chore(NA): splits types from code on @kbn/docs-utils (elastic#120533)
  [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110)
  ...

# Conflicts:
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts
#	x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts
#	x-pack/plugins/reporting/server/lib/screenshots/observable.ts
#	x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
@rudolf rudolf deleted the ftr-kibana-system-user branch December 7, 2021 14:39
@rudolf rudolf added the auto-backport Deprecated - use backport:version if exact versions are needed label Dec 7, 2021
@kibanamachine kibanamachine mentioned this pull request Dec 7, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2021
@rudolf @kibanamachine
FTR should use the new kibana_system user (elastic#120436)
a8ac71d 
* FTR should use the new kibana_system user

* Fix security api integration tests

Co-authored-by: Kibana Machine <[email protected]>
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 7, 2021
@rudolf @kibanamachine
FTR should use the new kibana_system user (elastic#120436)
4e3c843 
* FTR should use the new kibana_system user

* Fix security api integration tests

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Dec 7, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 8.0
✅ 7.16

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Dec 7, 2021
@kibanamachine @rudolf
FTR should use the new kibana_system user (#120436) (#120626)
2aaca46 
* FTR should use the new kibana_system user

* Fix security api integration tests

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Rudolf Meijering <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 7, 2021
@kibanamachine @rudolf
FTR should use the new kibana_system user (#120436) (#120627)
74fda46 
* FTR should use the new kibana_system user

* Fix security api integration tests

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Rudolf Meijering <[email protected]>
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
@rudolf @kibanamachine @TinLe
FTR should use the new kibana_system user (elastic#120436)
6c660f8 
* FTR should use the new kibana_system user

* Fix security api integration tests

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jportner jportner jportner approved these changes

@tylersmalley tylersmalley tylersmalley approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.16.1 v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rudolf @elasticmachine @kibana-ci @kibanamachine @tylersmalley @jportner