[Lens] Temporarily exclude Mosaic/Waffle from the suggestions list #120488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexwizp
added
release_note:skip
|
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
alexwizp
added
Feature:Lens
backport:skip
flash1293
reviewed
Dec 6, 2021
| @@ -784,7 +784,8 @@ describe('suggestions', () => { | |||
| ).toHaveLength(0); | |||
| }); | |||
|
|
|||
| it('mosaic type should be added only in case of 2 groups', () => { | |||
| /** The following test should be activated when Experimental flag will be removed from the Mosaic chart **/ | |||
| it.skip('mosaic type should be added only in case of 2 groups', () => { | |||
There was a problem hiding this comment.
We could turn these into tests to check whether the hidden suggestions are correct, what do you think?
There was a problem hiding this comment.
just the tests below check that and since we always have hide: true it doesn't really make much sense to keep both.
There was a problem hiding this comment.
OK, then let's just remove them.
| hasIntervalScale(groups) || | ||
| (state && state.shape === 'mosaic'), | ||
| hide: true, | ||
| /** The following code should be uncomment when Experimental flag will be removed from Mosaic chart **/ |
There was a problem hiding this comment.
Could you move these into a new issue "Get mosaic out of experimental" instead of having commented out code in here?
flash1293
approved these changes
Dec 6, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @alexwizp |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 7, 2021
…-chromium-before-compiling-pdf * 'main' of github.com:elastic/kibana: (121 commits) FTR should use the new kibana_system user (elastic#120436) [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list (elastic#120488) [Reporting] Fix slow CSV with large max size bytes (elastic#120365) [CTI] Threat Intel Card on Overview page needs to accommodate Fleet TI integrations - (elastic#120459) [Dashboard] Added KibanaThemeProvider. (elastic#120122) add more rule_registry unit tests (elastic#120323) [Lens] update xpack.lens.pie.smallValuesWarningMessage text (elastic#120478) [Fleet] Simplified package policy create API, enriching default values (elastic#119739) mock `elastic-apm-node` in `@kbn/test` jest preset (elastic#120324) [RAC] Rename occurrences of alert_type to rule_type in Infra (elastic#120455) [Security Solutions] Removes tech debt of exporting all from linter rule for timeline plugin (elastic#120437) [Workplace Search] Add API Keys view to replace Access tokens (elastic#120147) [Security Solutions] Removes tech debt of exporting all from linter rule for cases plugin in the server section (elastic#120411) Add support for threat.feed.name (elastic#120250) [Rule Registry] Rewrite APM registry rules for Observability (elastic#117740) [docs] Fix artifact layout formatting (elastic#119386) [Workplace Search] Add a technical preview of connecting GitHub via GitHub apps (elastic#119764) add osquery notes for 7.16 (elastic#120407) chore(NA): splits types from code on @kbn/docs-utils (elastic#120533) [Reporting] Decouple screenshotting plugin from the reporting (elastic#120110) ... # Conflicts: # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.test.ts # x-pack/plugins/reporting/server/browsers/chromium/driver_factory/index.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.test.ts # x-pack/plugins/reporting/server/lib/screenshots/observable.ts # x-pack/plugins/reporting/server/test_helpers/create_mock_browserdriverfactory.ts
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
…lastic#120488) * [Lens] Temporarily exclude Mosaic/Waffle from the suggestions list * Update suggestions.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By analogy with the previous visualizations with the
experimentalflag, we decided to temporarily not showWaffle/Mosaiccharts in theSuggestionslistThis PR excludes them from the list.