Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAC] [Observability] Move rule registry tests from APM to rule_registry #110637

Closed
Tracked by #110615
weltenwort opened this issue Aug 31, 2021 · 1 comment · Fixed by #117740
Closed
Tracked by #110615

[RAC] [Observability] Move rule registry tests from APM to rule_registry #110637

weltenwort opened this issue Aug 31, 2021 · 1 comment · Fixed by #117740
Assignees
@simianhacker
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" test Theme: rac label obsolete v8.0.0

Comments

@weltenwort
Copy link
Member

📓 Summary

We should move the rule registry tests that currently live in the APM plugin into the functional test directory of the rule registry.

✔️ Acceptance criteria

⚠️ When you pick this up, please spend a minute to think about and expand on these ACs.

  • The tests specific to the rule registry live in the rule_registry test directory.
  • The tests don't depend on any APM-specific test helpers.
@weltenwort weltenwort added test Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this issue Aug 31, 2021
Closed
9 tasks
@jasonrhodes jasonrhodes added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Oct 29, 2021
@simianhacker simianhacker self-assigned this Nov 3, 2021
@simianhacker simianhacker mentioned this issue Nov 5, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simianhacker simianhacker

Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" test Theme: rac label obsolete v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Rule Registry] Rewrite APM registry rules for Observability simianhacker/kibana
4 participants
@simianhacker @jasonrhodes @weltenwort @elasticmachine