Skip to content

Commit

Permalink
Merge branch 'main' of github.com:elastic/kibana into issue-110637-re…
Browse files Browse the repository at this point in the history
…write-apm-rule-registry-test
  • Loading branch information
simianhacker committed Nov 17, 2021
2 parents 778f014 + 8f158e6 commit 4e70255
Show file tree
Hide file tree
Showing 897 changed files with 17,536 additions and 12,218 deletions.
8 changes: 4 additions & 4 deletions .buildkite/scripts/bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ if ! yarn kbn bootstrap; then
yarn kbn bootstrap
fi

if [[ "$DISABLE_BOOTSTRAP_VALIDATION" != "true" ]]; then
verify_no_git_changes 'yarn kbn bootstrap'
fi

###
### upload ts-refs-cache artifacts as quickly as possible so they are available for download
###
Expand All @@ -27,7 +31,3 @@ if [[ "${BUILD_TS_REFS_CACHE_CAPTURE:-}" == "true" ]]; then
gsutil cp "*.zip" 'gs://kibana-ci-ts-refs-cache/'
cd "$KIBANA_DIR"
fi

if [[ "$DISABLE_BOOTSTRAP_VALIDATION" != "true" ]]; then
verify_no_git_changes 'yarn kbn bootstrap'
fi
2 changes: 2 additions & 0 deletions .buildkite/scripts/common/util.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ is_pr() {

verify_no_git_changes() {
RED='\033[0;31m'
YELLOW='\033[0;33m'
C_RESET='\033[0m' # Reset color

GIT_CHANGES="$(git ls-files --modified -- . ':!:.bazelrc')"
if [ "$GIT_CHANGES" ]; then
echo -e "\n${RED}ERROR: '$1' caused changes to the following files:${C_RESET}\n"
echo -e "$GIT_CHANGES\n"
echo -e "\n${YELLOW}TO FIX: Run '$1' locally, commit the changes and push to your branch${C_RESET}\n"
exit 1
fi
}
Expand Down
1 change: 1 addition & 0 deletions .buildkite/scripts/steps/checks.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

set -euo pipefail

export DISABLE_BOOTSTRAP_VALIDATION=false
.buildkite/scripts/bootstrap.sh

.buildkite/scripts/steps/checks/commit/commit.sh
Expand Down
4 changes: 4 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,10 @@ module.exports = {
name: 'semver',
message: 'Please use "semver/*/{function}" instead',
},
{
name: '@kbn/rule-data-utils',
message: `Import directly from @kbn/rule-data-utils/* submodules in public/common code`,
},
],
},
],
Expand Down
14 changes: 9 additions & 5 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@
# Security Solution sub teams
/x-pack/plugins/cases @elastic/security-threat-hunting
/x-pack/plugins/timelines @elastic/security-threat-hunting
/x-pack/test/case_api_integration @elastic/security-threat-hunting
/x-pack/test/cases_api_integration @elastic/security-threat-hunting
/x-pack/plugins/lists @elastic/security-detections-response

## Security Solution sub teams - security-onboarding-and-lifecycle-mgt
Expand All @@ -415,11 +415,15 @@
/x-pack/plugins/security_solution/scripts/endpoint/trusted_apps/ @elastic/security-onboarding-and-lifecycle-mgt
/x-pack/test/security_solution_endpoint/apps/endpoint/ @elastic/security-onboarding-and-lifecycle-mgt

## Security Solution sub teams - security-telemetry (Data Engineering)
x-pack/plugins/security_solution/server/usage/ @elastic/security-telemetry
x-pack/plugins/security_solution/server/lib/telemetry/ @elastic/security-telemetry

## Security Solution sub teams - security-engineering-productivity
x-pack/plugins/security_solution/cypress/ccs_integration
x-pack/plugins/security_solution/cypress/upgrade_integration
x-pack/plugins/security_solution/cypress/README.md
x-pack/test/security_solution_cypress
x-pack/plugins/security_solution/cypress/ccs_integration @elastic/security-engineering-productivity
x-pack/plugins/security_solution/cypress/upgrade_integration @elastic/security-engineering-productivity
x-pack/plugins/security_solution/cypress/README.md @elastic/security-engineering-productivity
x-pack/test/security_solution_cypress @elastic/security-engineering-productivity

# Security Intelligence And Analytics
/x-pack/plugins/security_solution/server/lib/detection_engine/rules/prepackaged_rules @elastic/security-intelligence-analytics
Expand Down
2 changes: 1 addition & 1 deletion dev_docs/contributing/how_we_use_github.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ In order to assist with developer tooling we ask that all Elastic engineers use
1. Update the git config for your current repository to commit with your `@elastic.co` email:

```bash
git config --local user.email [email protected]
git config user.email [email protected]
```

1. Create a commit using the new email address
Expand Down
46 changes: 23 additions & 23 deletions docs/apm/correlations.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ in a table below the chart. The table is sorted by correlation coefficients that
range from 0 to 1. Attributes with higher correlation values are more likely to
contribute to high latency transactions. By default, the attribute with the
highest correlation value is added to the chart. To see the latency distribution
for other attributes, hover over their row in the table.
for other attributes, select their row in the table.

If a correlated attribute seems noteworthy, use the **Filter** quick links:

Expand All @@ -47,12 +47,14 @@ the selected value.
* `-` creates a new query in the {apm-app} to filter out transactions containing
the selected value.

In this example screenshot, transactions with the field
`labels.orderPriceRange` and value `large` are skewed to the right with slower
response times than the overall latency distribution. If you select the `+`
filter in the appropriate row of the table, it creates a new query in the
{apm-app} for transactions with this attribute. With the "noise" now filtered
out, you can begin viewing sample traces to continue your investigation.
You can also click the icon beside the field name to view and filter its most
popular values.

In this example screenshot, there are transactions that are skewed to the right
with slower response times than the overall latency distribution. If you select
the `+` filter in the appropriate row of the table, it creates a new query in
the {apm-app} for transactions with this attribute. With the "noise" now
filtered out, you can begin viewing sample traces to continue your investigation.

[discrete]
[[correlations-error-rate]]
Expand All @@ -67,25 +69,23 @@ is determined by its {ecs-ref}/ecs-event.html#field-event-outcome[event.outcome]
value. For example, APM agents set the `event.outcome` to `failure` when an HTTP
transaction returns a `5xx` status code.

// The chart highlights the failed transactions in the overall latency distribution for the transaction group.
If there are attributes that have a statistically significant correlation with
failed transactions, they are listed in a table. The table is sorted by scores,
which are mapped to high, medium, or low impact levels. Attributes with high
impact levels are more likely to contribute to failed transactions.
// By default, the attribute with the highest score is added to the chart. To see a different attribute in the chart, hover over its row in the table.
The chart highlights the failed transactions in the overall latency distribution
for the transaction group. If there are attributes that have a statistically
significant correlation with failed transactions, they are listed in a table.
The table is sorted by scores, which are mapped to high, medium, or low impact
levels. Attributes with high impact levels are more likely to contribute to
failed transactions. By default, the attribute with the highest score is added
to the chart. To see a different attribute in the chart, select its row in the
table.

For example, in the screenshot below, the field
`kubernetes.pod.name` and value `frontend-node-59dff47885-fl5lb` has a medium
impact level and existed in 19% of the failed transactions.
For example, in the screenshot below, there are attributes such as a specific
node and pod name that have medium impact on the failed transactions.

[role="screenshot"]
image::apm/images/correlations-failed-transactions.png[Failed transaction correlations]

TIP: Some details, such as the failure and success percentages, are available
only when the
<<observability-enable-inspect-es-queries,observability:enableInspectEsQueries>>
advanced setting is enabled.

Select the `+` filter to create a new query in the {apm-app} for transactions
with this attribute. You might do his for multiple attributes--each time
filtering out more and more noise and bringing you closer to a diagnosis.
with one or more of these attributes. If you are unfamiliar with a field, click
the icon beside its name to view its most popular values and optionally filter
on those values too. Each time that you add another attribute, it is filtering
out more and more noise and bringing you closer to a diagnosis.
Binary file modified docs/apm/images/correlations-failed-transactions.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/apm/images/correlations-hover.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion docs/developer/contributing/development-github.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ In order to assist with developer tooling we ask that all Elastic engineers use
+
["source","shell"]
-----------
git config --local user.email [email protected]
git config user.email [email protected]
-----------
4. Create a commit using the new email address
+
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ export interface AppMountParameters<HistoryLocationState = unknown>
| [history](./kibana-plugin-core-public.appmountparameters.history.md) | ScopedHistory&lt;HistoryLocationState&gt; | A scoped history instance for your application. Should be used to wire up your applications Router. |
| [onAppLeave](./kibana-plugin-core-public.appmountparameters.onappleave.md) | (handler: AppLeaveHandler) =&gt; void | A function that can be used to register a handler that will be called when the user is leaving the current application, allowing to prompt a confirmation message before actually changing the page.<!-- -->This will be called either when the user goes to another application, or when trying to close the tab or manually changing the url. |
| [setHeaderActionMenu](./kibana-plugin-core-public.appmountparameters.setheaderactionmenu.md) | (menuMount: MountPoint \| undefined) =&gt; void | A function that can be used to set the mount point used to populate the application action container in the chrome header.<!-- -->Calling the handler multiple time will erase the current content of the action menu with the mount from the latest call. Calling the handler with <code>undefined</code> will unmount the current mount point. Calling the handler after the application has been unmounted will have no effect. |
| [theme$](./kibana-plugin-core-public.appmountparameters.theme_.md) | Observable&lt;CoreTheme&gt; | An observable emitting [Core's theme](./kibana-plugin-core-public.coretheme.md)<!-- -->. Should be used when mounting the application to include theme information. |

Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [AppMountParameters](./kibana-plugin-core-public.appmountparameters.md) &gt; [theme$](./kibana-plugin-core-public.appmountparameters.theme_.md)

## AppMountParameters.theme$ property

An observable emitting [Core's theme](./kibana-plugin-core-public.coretheme.md)<!-- -->. Should be used when mounting the application to include theme information.

<b>Signature:</b>

```typescript
theme$: Observable<CoreTheme>;
```

## Example

When mounting a react application:

```ts
// application.tsx
import React from 'react';
import ReactDOM from 'react-dom';

import { AppMountParameters } from 'src/core/public';
import { wrapWithTheme } from 'src/plugins/kibana_react';
import { MyApp } from './app';

export renderApp = ({ element, theme$ }: AppMountParameters) => {
ReactDOM.render(wrapWithTheme(<MyApp/>, theme$), element);
return () => ReactDOM.unmountComponentAtNode(element);
}
```

Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ export interface CoreSetup<TPluginsStart extends object = object, TStart = unkno
| [http](./kibana-plugin-core-public.coresetup.http.md) | HttpSetup | [HttpSetup](./kibana-plugin-core-public.httpsetup.md) |
| [injectedMetadata](./kibana-plugin-core-public.coresetup.injectedmetadata.md) | { getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown; } | exposed temporarily until https://github.com/elastic/kibana/issues/41990 done use \*only\* to retrieve config values. There is no way to set injected values in the new platform. |
| [notifications](./kibana-plugin-core-public.coresetup.notifications.md) | NotificationsSetup | [NotificationsSetup](./kibana-plugin-core-public.notificationssetup.md) |
| [theme](./kibana-plugin-core-public.coresetup.theme.md) | ThemeServiceSetup | [ThemeServiceSetup](./kibana-plugin-core-public.themeservicesetup.md) |
| [uiSettings](./kibana-plugin-core-public.coresetup.uisettings.md) | IUiSettingsClient | [IUiSettingsClient](./kibana-plugin-core-public.iuisettingsclient.md) |

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [CoreSetup](./kibana-plugin-core-public.coresetup.md) &gt; [theme](./kibana-plugin-core-public.coresetup.theme.md)

## CoreSetup.theme property

[ThemeServiceSetup](./kibana-plugin-core-public.themeservicesetup.md)

<b>Signature:</b>

```typescript
theme: ThemeServiceSetup;
```
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,6 @@ export interface CoreStart
| [notifications](./kibana-plugin-core-public.corestart.notifications.md) | NotificationsStart | [NotificationsStart](./kibana-plugin-core-public.notificationsstart.md) |
| [overlays](./kibana-plugin-core-public.corestart.overlays.md) | OverlayStart | [OverlayStart](./kibana-plugin-core-public.overlaystart.md) |
| [savedObjects](./kibana-plugin-core-public.corestart.savedobjects.md) | SavedObjectsStart | [SavedObjectsStart](./kibana-plugin-core-public.savedobjectsstart.md) |
| [theme](./kibana-plugin-core-public.corestart.theme.md) | ThemeServiceStart | [ThemeServiceStart](./kibana-plugin-core-public.themeservicestart.md) |
| [uiSettings](./kibana-plugin-core-public.corestart.uisettings.md) | IUiSettingsClient | [IUiSettingsClient](./kibana-plugin-core-public.iuisettingsclient.md) |

Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [CoreStart](./kibana-plugin-core-public.corestart.md) &gt; [theme](./kibana-plugin-core-public.corestart.theme.md)

## CoreStart.theme property

[ThemeServiceStart](./kibana-plugin-core-public.themeservicestart.md)

<b>Signature:</b>

```typescript
theme: ThemeServiceStart;
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [CoreTheme](./kibana-plugin-core-public.coretheme.md) &gt; [darkMode](./kibana-plugin-core-public.coretheme.darkmode.md)

## CoreTheme.darkMode property

is dark mode enabled or not

<b>Signature:</b>

```typescript
readonly darkMode: boolean;
```
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!-- Do not edit this file. It is automatically generated by API Documenter. -->

[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [CoreTheme](./kibana-plugin-core-public.coretheme.md)

## CoreTheme interface

Contains all the required information to apply Kibana's theme at the various levels it can be used.

<b>Signature:</b>

```typescript
export interface CoreTheme
```

## Properties

| Property | Type | Description |
| --- | --- | --- |
| [darkMode](./kibana-plugin-core-public.coretheme.darkmode.md) | boolean | is dark mode enabled or not |

Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ readonly links: {
readonly luceneQuerySyntax: string;
readonly percolate: string;
readonly queryDsl: string;
readonly autocompleteChanges: string;
};
readonly date: {
readonly dateMath: string;
Expand Down Expand Up @@ -212,7 +211,11 @@ readonly links: {
uptimeDurationAnomaly: string;
}>;
readonly alerting: Record<string, string>;
readonly maps: Record<string, string>;
readonly maps: Readonly<{
guide: string;
importGeospatialPrivileges: string;
gdalTutorial: string;
}>;
readonly monitoring: Record<string, string>;
readonly security: Readonly<{
apiKeyServiceSettings: string;
Expand Down
Loading

0 comments on commit 4e70255

Please sign in to comment.