Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v37.3.0 #109157

Merged
merged 12 commits into from
Aug 23, 2021
Merged

Upgrade EUI to v37.3.0 #109157

merged 12 commits into from
Aug 23, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 18, 2021 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

  • "Fixed EuiButtonGroup firing onChange twice" required changing some tests from click to change

37.3.0

  • Updated copyClipboard glyph in EuiIcon to be centered (#5023)
  • Updated EuiFilePicker removeFiles method to enable programmatic selection clearing (#5017)
  • Updated EuiFlyout testenv mock to pass-through onKeyDown prop (#5029)
  • Enabled EuiCodeBlock copy button in EuiMarkdownFormat (#5032)
  • Changed copy icon to copyClipboard in EuiCodeBlock (#5018)

Bug fixes

  • Fixed content in EuiFilterButton when numFilters is not passed (#5012)
  • Fixed default value of outsideClickCloses prop of EuiFlyout (#5027)
  • Fixed EuiSelectable's double click bug (#5021)
  • Fixed overflowing controls when EuiCodeBlock is short in height (#5018)
  • Fixed EuiButtonGroup firing onChange twice (#5033)

37.2.0

  • Added isDisabled prop to EuiFormLabel and passed it down from EuiFormRow (#5009)

Bug fixes

  • Fixed usage of outsideClickCloses prop of EuiFlyout (#4986)
  • Fixed EuiFormRow ignoring isDisabled prop on the child element. (#5022)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.16.0 labels Aug 18, 2021
@thompsongl thompsongl marked this pull request as ready for review August 19, 2021 04:52
@thompsongl thompsongl requested a review from a team August 19, 2021 04:52
@thompsongl thompsongl requested review from a team as code owners August 19, 2021 04:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

kertal
kertal approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test, looked at KibanaApp owned code, happy the the navigating flyout with the arrow key test can be unskipped 👍

sabarasaba
sabarasaba approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stack Management changes lgtm, tested locally and works fine 🚀

@afharo afharo mentioned this pull request Aug 20, 2021
Closed
@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

@thompsongl
Copy link
Contributor Author

@elasticmachine merge upstream

@thompsongl
Copy link
Contributor Author

Snapshot changes only for remaining codeowner reviews. Will merge on next successful CI run.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.5MB +198.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 423.1KB 423.1KB +13.0B
kbnUiSharedDeps-css 534.1KB 534.9KB +739.0B
kbnUiSharedDeps-elastic 2.6MB 2.6MB +1.8KB
kbnUiSharedDeps-js 6.5MB 6.5MB +2.0B
total +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl merged commit 873f2e2 into elastic:master Aug 23, 2021
@thompsongl thompsongl mentioned this pull request Aug 23, 2021
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Aug 23, 2021
@thompsongl @kibanamachine
Upgrade EUI to v37.3.0 (elastic#109157)
9440d02 
* eui to 37.3.0

* i18n tokens

* reinstate discover_grid_flyout test

* more i18n tokens

* snapshot updates

* fix jest failures

* update cell position pattern

* clean up pattern

* buttongroup click -> change

Co-authored-by: Kibana Machine <[email protected]>
thompsongl added a commit that referenced this pull request Aug 23, 2021
@thompsongl @kibanamachine
[7.x] Upgrade EUI to v37.3.0 (#109157) (#109691)
5e5c7c3 
* Upgrade EUI to v37.3.0 (#109157)

* eui to 37.3.0

* i18n tokens

* reinstate discover_grid_flyout test

* more i18n tokens

* snapshot updates

* fix jest failures

* update cell position pattern

* clean up pattern

* buttongroup click -> change

Co-authored-by: Kibana Machine <[email protected]>

* fix bad merge

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@sabarasaba sabarasaba sabarasaba approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thompsongl @elasticmachine @kibanamachine @kertal @sabarasaba @pgayvallet @jbudz