Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiFilePicker] Better removeFiles exposure #5017

Merged
merged 12 commits into from
Aug 13, 2021

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 11, 2021

Summary

Closes #5001 by simplifying the removeFiles class method and adding documentation for its use.

Checklist

- [ ] Check against all themes for compatibility in both light and dark modes
- [ ] Checked in mobile
- [ ] Checked in Chrome, Safari, Edge, and Firefox
- [ ] Props have proper autodocs and playground toggles

- [ ] Added or updated jest tests

  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣 I was literally just about to push a commit that put that example in it's own section. 💯

LGTM! Just some quick suggestions.

src-docs/src/views/form_controls/file_picker_remove.js Outdated Show resolved Hide resolved
src-docs/src/views/form_controls/form_controls_example.js Outdated Show resolved Hide resolved
src-docs/src/views/form_controls/form_controls_example.js Outdated Show resolved Hide resolved
src-docs/src/views/form_controls/form_controls_example.js Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/

@thompsongl thompsongl merged commit b9b80e6 into elastic:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiFilePicker] Expose files attribute
4 participants