-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiFilePicker] Better removeFiles
exposure
#5017
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 I was literally just about to push a commit that put that example in it's own section. 💯
LGTM! Just some quick suggestions.
Preview documentation changes for this PR: https://eui.elastic.co/pr_5017/ |
Summary
Closes #5001 by simplifying the
removeFiles
class method and adding documentation for its use.Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Checked in Chrome, Safari, Edge, and Firefox- [ ] Props have proper autodocs and playground toggles- [ ] Added or updated jest tests