Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global search] It always takes 2 clicks to open #98851

Closed
wylieconlon opened this issue Apr 29, 2021 · 10 comments
Closed

[Global search] It always takes 2 clicks to open #98851

wylieconlon opened this issue Apr 29, 2021 · 10 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Header Work related to the header section of the Kibana app. Feature:Navigational Search Global search bar Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@wylieconlon
Copy link
Contributor

Tested this in Chrome and Firefox, in Kibana 7.12 and the latest code on master. Here is a GIF of the issue in Firefox on 7.12:

focus issue in global search

@wylieconlon wylieconlon added bug Fixes for quality problems that affect the customer experience Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Header Work related to the header section of the Kibana app. labels Apr 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added the Feature:Navigational Search Global search bar label Apr 30, 2021
@joshdover
Copy link
Contributor

Grooming notes:

  • Need to confirm we can reproduce on master
  • If it reproducible, likely an EUI change since we have not done work in this area recently

@wylieconlon
Copy link
Contributor Author

@joshdover I just tested on master, and it appears that this is still happening. I think the important part of the reproduction steps is that you need to:

  1. Type slowly into the search bar
  2. Wait for results to come back
  3. Try to click any of the results

@afharo
Copy link
Member

afharo commented Aug 11, 2021

I just tested this on the master branch, and I can't reproduce it on Firefox. However, it's still happening on Google Chrome and Safari. Interestingly, once the first 2-click navigation has occurred, the rest work as expected.

I'll dig in to find the root cause.

@afharo
Copy link
Member

afharo commented Aug 11, 2021

More findings: it does not affect if any of the viewable items are clicked. But the moment you scroll through the list, the issue may occur. Sometimes, even if wildly scrolling up and down, on the 2nd attempt, it may require an additional click.

@afharo
Copy link
Member

afharo commented Aug 12, 2021

I managed to replicate the issue in the eui docs, so I created the issue elastic/eui#5020 in that project to fix it upstream.

@afharo
Copy link
Member

afharo commented Aug 16, 2021

The fix has been merged in the @elastic/eui library. This issue will be closed when the module is published and upgraded.

Keeping the issue open in the meanwhile for tracking purposes.

The intention is to backport it to 7.15.0 and 7.14.1.

cc @thompsongl

@afharo
Copy link
Member

afharo commented Aug 20, 2021

This PR will apply the fixes to 7.16.0+: #109157

@afharo
Copy link
Member

afharo commented Aug 26, 2021

The changes have also been backported to:

Closing this issue now 🎉

@afharo afharo closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Header Work related to the header section of the Kibana app. Feature:Navigational Search Global search bar Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

6 participants